* [PATCH] MIPS: 74K/1074K: Fix typo in erratum workaround.
@ 2015-01-06 10:39 Tony Wu
2015-01-06 20:07 ` Leonid Yegoshin
0 siblings, 1 reply; 2+ messages in thread
From: Tony Wu @ 2015-01-06 10:39 UTC (permalink / raw)
To: ralf, macro; +Cc: linux-mips, Steven.Hill, Leonid.Yegoshin
In commit 9213ad (MIPS: 74K/1074K: Correct erratum workaround.),
MIPS_CACHE_VTAG should go to icache.flags.
Signed-off-by: Tony Wu <tung7970@gmail.com>
Cc: Maciej W. Rozycki <macro@linux-mips.org>
Cc: Steven J. Hill <Steven.Hill@imgtec.com>
Cc: Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>
diff --git a/arch/mips/mm/c-r4k.c b/arch/mips/mm/c-r4k.c
index dd261df..deebd0b 100644
--- a/arch/mips/mm/c-r4k.c
+++ b/arch/mips/mm/c-r4k.c
@@ -902,13 +902,13 @@ static inline void alias_74k_erratum(struct cpuinfo_mips *c)
switch (imp) {
case PRID_IMP_74K:
if (rev <= PRID_REV_ENCODE_332(2, 4, 0))
- c->dcache.flags |= MIPS_CACHE_VTAG;
+ c->icache.flags |= MIPS_CACHE_VTAG;
if (rev == PRID_REV_ENCODE_332(2, 4, 0))
write_c0_config6(read_c0_config6() | MIPS_CONF6_SYND);
break;
case PRID_IMP_1074K:
if (rev <= PRID_REV_ENCODE_332(1, 1, 0)) {
- c->dcache.flags |= MIPS_CACHE_VTAG;
+ c->icache.flags |= MIPS_CACHE_VTAG;
write_c0_config6(read_c0_config6() | MIPS_CONF6_SYND);
}
break;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] MIPS: 74K/1074K: Fix typo in erratum workaround.
2015-01-06 10:39 [PATCH] MIPS: 74K/1074K: Fix typo in erratum workaround Tony Wu
@ 2015-01-06 20:07 ` Leonid Yegoshin
0 siblings, 0 replies; 2+ messages in thread
From: Leonid Yegoshin @ 2015-01-06 20:07 UTC (permalink / raw)
To: Tony Wu, ralf@linux-mips.org, macro@linux-mips.org
Cc: linux-mips@linux-mips.org, Steven J. Hill
On 01/06/2015 02:39 AM, Tony Wu wrote:
> In commit 9213ad (MIPS: 74K/1074K: Correct erratum workaround.),
> MIPS_CACHE_VTAG should go to icache.flags.
>
> Signed-off-by: Tony Wu <tung7970@gmail.com>
> Cc: Maciej W. Rozycki <macro@linux-mips.org>
> Cc: Steven J. Hill <Steven.Hill@imgtec.com>
> Cc: Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>
>
> diff --git a/arch/mips/mm/c-r4k.c b/arch/mips/mm/c-r4k.c
> index dd261df..deebd0b 100644
> --- a/arch/mips/mm/c-r4k.c
> +++ b/arch/mips/mm/c-r4k.c
> @@ -902,13 +902,13 @@ static inline void alias_74k_erratum(struct cpuinfo_mips *c)
> switch (imp) {
> case PRID_IMP_74K:
> if (rev <= PRID_REV_ENCODE_332(2, 4, 0))
> - c->dcache.flags |= MIPS_CACHE_VTAG;
> + c->icache.flags |= MIPS_CACHE_VTAG;
> if (rev == PRID_REV_ENCODE_332(2, 4, 0))
> write_c0_config6(read_c0_config6() | MIPS_CONF6_SYND);
> break;
> case PRID_IMP_1074K:
> if (rev <= PRID_REV_ENCODE_332(1, 1, 0)) {
> - c->dcache.flags |= MIPS_CACHE_VTAG;
> + c->icache.flags |= MIPS_CACHE_VTAG;
> write_c0_config6(read_c0_config6() | MIPS_CONF6_SYND);
> }
> break;
It is not a typo, it is a special case and an original patch should
follow the patch
http://patchwork.linux-mips.org/patch/8459/
which has a use of 'cpu_has_vtag_dcache'
- Leonid.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-06 20:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-06 10:39 [PATCH] MIPS: 74K/1074K: Fix typo in erratum workaround Tony Wu
2015-01-06 20:07 ` Leonid Yegoshin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.