From: Felipe Balbi <balbi@ti.com>
To: David Miller <davem@davemloft.net>
Cc: balbi@ti.com, netdev@vger.kernel.org, linux-omap@vger.kernel.org,
stable@vger.kernel.org, mugunthanvnm@ti.com
Subject: Re: [PATCH] net: ethernet: cpsw: ignore VLAN ID 1
Date: Tue, 6 Jan 2015 16:04:10 -0600 [thread overview]
Message-ID: <20150106220410.GH32308@saruman> (raw)
In-Reply-To: <20150106.165911.604916635790072318.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 698 bytes --]
Hi,
On Tue, Jan 06, 2015 at 04:59:11PM -0500, David Miller wrote:
> From: Felipe Balbi <balbi@ti.com>
> Date: Tue, 6 Jan 2015 14:31:19 -0600
>
> > What you're saying here is that you prefer to drop a feature that works
> > for all other 1023 IDs because 1 ID is quirky. Sounds like overkill
> > to me.
>
> The other option is to software fallback only for VLAN 1.
now we're talking. Keep in mind, however, that this IP runs on mere
single-core cortex A8 and single-core cortex A9 devices which already
have somewhat of a hard-time keeping up with the non-accelerated
checksum calculations. But fair enough, if that's the way to go, it is
the way to go.
cheers
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@ti.com>
To: David Miller <davem@davemloft.net>
Cc: <balbi@ti.com>, <netdev@vger.kernel.org>,
<linux-omap@vger.kernel.org>, <stable@vger.kernel.org>,
<mugunthanvnm@ti.com>
Subject: Re: [PATCH] net: ethernet: cpsw: ignore VLAN ID 1
Date: Tue, 6 Jan 2015 16:04:10 -0600 [thread overview]
Message-ID: <20150106220410.GH32308@saruman> (raw)
In-Reply-To: <20150106.165911.604916635790072318.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 698 bytes --]
Hi,
On Tue, Jan 06, 2015 at 04:59:11PM -0500, David Miller wrote:
> From: Felipe Balbi <balbi@ti.com>
> Date: Tue, 6 Jan 2015 14:31:19 -0600
>
> > What you're saying here is that you prefer to drop a feature that works
> > for all other 1023 IDs because 1 ID is quirky. Sounds like overkill
> > to me.
>
> The other option is to software fallback only for VLAN 1.
now we're talking. Keep in mind, however, that this IP runs on mere
single-core cortex A8 and single-core cortex A9 devices which already
have somewhat of a hard-time keeping up with the non-accelerated
checksum calculations. But fair enough, if that's the way to go, it is
the way to go.
cheers
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-01-06 22:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 17:43 [PATCH] net: ethernet: cpsw: ignore VLAN ID 1 Felipe Balbi
2015-01-06 17:43 ` Felipe Balbi
2015-01-06 19:13 ` David Miller
2015-01-06 20:31 ` Felipe Balbi
2015-01-06 20:31 ` Felipe Balbi
2015-01-06 21:59 ` David Miller
2015-01-06 22:04 ` Felipe Balbi [this message]
2015-01-06 22:04 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150106220410.GH32308@saruman \
--to=balbi@ti.com \
--cc=davem@davemloft.net \
--cc=linux-omap@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.