* [PATCH] writeback: fix simple_return.cocci warnings [not found] <201501071230.5cIaA8Xy%fengguang.wu@intel.com> @ 2015-01-07 4:25 ` kbuild test robot 0 siblings, 0 replies; 4+ messages in thread From: kbuild test robot @ 2015-01-07 4:25 UTC (permalink / raw) To: Tejun Heo Cc: kbuild-all, Jens Axboe, Jan Kara, Andrew Morton, Linux Memory Management List, Paul E. McKenney, Maxim Patlasov, Johannes Weiner, Derek Basehore, linux-kernel mm/backing-dev.c:513:1-4: WARNING: end returns can be simpified and declaration on line 502 can be dropped Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> --- backing-dev.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) --- a/mm/backing-dev.c +++ b/mm/backing-dev.c @@ -499,8 +499,6 @@ static void bdi_wb_exit(struct bdi_write int bdi_init(struct backing_dev_info *bdi) { - int err; - bdi->dev = NULL; bdi->min_ratio = 0; @@ -510,11 +508,7 @@ int bdi_init(struct backing_dev_info *bd INIT_LIST_HEAD(&bdi->bdi_list); INIT_LIST_HEAD(&bdi->work_list); - err = bdi_wb_init(&bdi->wb, bdi); - if (err) - return err; - - return 0; + return bdi_wb_init(&bdi->wb, bdi); } EXPORT_SYMBOL(bdi_init); -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] writeback: fix simple_return.cocci warnings @ 2015-01-07 4:25 ` kbuild test robot 0 siblings, 0 replies; 4+ messages in thread From: kbuild test robot @ 2015-01-07 4:25 UTC (permalink / raw) To: Tejun Heo Cc: kbuild-all, Jens Axboe, Jan Kara, Andrew Morton, Linux Memory Management List, Paul E. McKenney, Maxim Patlasov, Johannes Weiner, Derek Basehore, linux-kernel mm/backing-dev.c:513:1-4: WARNING: end returns can be simpified and declaration on line 502 can be dropped Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> --- backing-dev.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) --- a/mm/backing-dev.c +++ b/mm/backing-dev.c @@ -499,8 +499,6 @@ static void bdi_wb_exit(struct bdi_write int bdi_init(struct backing_dev_info *bdi) { - int err; - bdi->dev = NULL; bdi->min_ratio = 0; @@ -510,11 +508,7 @@ int bdi_init(struct backing_dev_info *bd INIT_LIST_HEAD(&bdi->bdi_list); INIT_LIST_HEAD(&bdi->work_list); - err = bdi_wb_init(&bdi->wb, bdi); - if (err) - return err; - - return 0; + return bdi_wb_init(&bdi->wb, bdi); } EXPORT_SYMBOL(bdi_init); ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] writeback: fix simple_return.cocci warnings 2015-01-07 4:25 ` kbuild test robot @ 2015-01-07 8:41 ` Jan Kara -1 siblings, 0 replies; 4+ messages in thread From: Jan Kara @ 2015-01-07 8:41 UTC (permalink / raw) To: kbuild test robot Cc: Tejun Heo, kbuild-all, Jens Axboe, Jan Kara, Andrew Morton, Linux Memory Management List, Paul E. McKenney, Maxim Patlasov, Johannes Weiner, Derek Basehore, linux-kernel On Wed 07-01-15 12:25:35, Wu Fengguang wrote: > mm/backing-dev.c:513:1-4: WARNING: end returns can be simpified and declaration on line 502 can be dropped > > Simplify a trivial if-return sequence. Possibly combine with a > preceding function call. > Generated by: scripts/coccinelle/misc/simple_return.cocci > > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> Looks good. Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > > backing-dev.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > --- a/mm/backing-dev.c > +++ b/mm/backing-dev.c > @@ -499,8 +499,6 @@ static void bdi_wb_exit(struct bdi_write > > int bdi_init(struct backing_dev_info *bdi) > { > - int err; > - > bdi->dev = NULL; > > bdi->min_ratio = 0; > @@ -510,11 +508,7 @@ int bdi_init(struct backing_dev_info *bd > INIT_LIST_HEAD(&bdi->bdi_list); > INIT_LIST_HEAD(&bdi->work_list); > > - err = bdi_wb_init(&bdi->wb, bdi); > - if (err) > - return err; > - > - return 0; > + return bdi_wb_init(&bdi->wb, bdi); > } > EXPORT_SYMBOL(bdi_init); > -- Jan Kara <jack@suse.cz> SUSE Labs, CR -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] writeback: fix simple_return.cocci warnings @ 2015-01-07 8:41 ` Jan Kara 0 siblings, 0 replies; 4+ messages in thread From: Jan Kara @ 2015-01-07 8:41 UTC (permalink / raw) To: kbuild test robot Cc: Tejun Heo, kbuild-all, Jens Axboe, Jan Kara, Andrew Morton, Linux Memory Management List, Paul E. McKenney, Maxim Patlasov, Johannes Weiner, Derek Basehore, linux-kernel On Wed 07-01-15 12:25:35, Wu Fengguang wrote: > mm/backing-dev.c:513:1-4: WARNING: end returns can be simpified and declaration on line 502 can be dropped > > Simplify a trivial if-return sequence. Possibly combine with a > preceding function call. > Generated by: scripts/coccinelle/misc/simple_return.cocci > > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> Looks good. Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > > backing-dev.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > --- a/mm/backing-dev.c > +++ b/mm/backing-dev.c > @@ -499,8 +499,6 @@ static void bdi_wb_exit(struct bdi_write > > int bdi_init(struct backing_dev_info *bdi) > { > - int err; > - > bdi->dev = NULL; > > bdi->min_ratio = 0; > @@ -510,11 +508,7 @@ int bdi_init(struct backing_dev_info *bd > INIT_LIST_HEAD(&bdi->bdi_list); > INIT_LIST_HEAD(&bdi->work_list); > > - err = bdi_wb_init(&bdi->wb, bdi); > - if (err) > - return err; > - > - return 0; > + return bdi_wb_init(&bdi->wb, bdi); > } > EXPORT_SYMBOL(bdi_init); > -- Jan Kara <jack@suse.cz> SUSE Labs, CR ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-07 8:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <201501071230.5cIaA8Xy%fengguang.wu@intel.com>
2015-01-07 4:25 ` [PATCH] writeback: fix simple_return.cocci warnings kbuild test robot
2015-01-07 4:25 ` kbuild test robot
2015-01-07 8:41 ` Jan Kara
2015-01-07 8:41 ` Jan Kara
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.