All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Terje Bergström" <tbergstrom@nvidia.com>,
	"David Airlie" <airlied@linux.ie>,
	"Stephen Warren" <swarren@wwwdotorg.org>,
	"Alexandre Courbot" <gnurou@gmail.com>,
	"Grant Likely" <grant.likely@linaro.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [patch] drm/tegra: bad irqsave/restore in tegra_dc_finish_page_flip()
Date: Wed, 07 Jan 2015 13:46:45 +0000	[thread overview]
Message-ID: <20150107134644.GD6988@ulmo> (raw)
In-Reply-To: <20150107110126.GA14864@mwanda>

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

On Wed, Jan 07, 2015 at 02:01:26PM +0300, Dan Carpenter wrote:
> We can't save two values to the IRQ flags at the same time so the IRQs
> are not enabled at the end.  This kind of bug is easy to miss in testing
> if the function is normally called with IRQs disabled so we wouldn't
> enable IRQs anyway.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Good catch, applied.

Thanks,
Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Terje Bergström" <tbergstrom@nvidia.com>,
	"David Airlie" <airlied@linux.ie>,
	"Stephen Warren" <swarren@wwwdotorg.org>,
	"Alexandre Courbot" <gnurou@gmail.com>,
	"Grant Likely" <grant.likely@linaro.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [patch] drm/tegra: bad irqsave/restore in tegra_dc_finish_page_flip()
Date: Wed, 7 Jan 2015 14:46:45 +0100	[thread overview]
Message-ID: <20150107134644.GD6988@ulmo> (raw)
In-Reply-To: <20150107110126.GA14864@mwanda>

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

On Wed, Jan 07, 2015 at 02:01:26PM +0300, Dan Carpenter wrote:
> We can't save two values to the IRQ flags at the same time so the IRQs
> are not enabled at the end.  This kind of bug is easy to miss in testing
> if the function is normally called with IRQs disabled so we wouldn't
> enable IRQs anyway.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Good catch, applied.

Thanks,
Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-01-07 13:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-07 11:01 [patch] drm/tegra: bad irqsave/restore in tegra_dc_finish_page_flip() Dan Carpenter
2015-01-07 11:01 ` Dan Carpenter
2015-01-07 13:46 ` Thierry Reding [this message]
2015-01-07 13:46   ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150107134644.GD6988@ulmo \
    --to=thierry.reding@gmail.com \
    --cc=airlied@linux.ie \
    --cc=dan.carpenter@oracle.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gnurou@gmail.com \
    --cc=grant.likely@linaro.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=swarren@wwwdotorg.org \
    --cc=tbergstrom@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.