From: christoffer.dall@linaro.org (Christoffer Dall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: KVM: Fix HCR setting for 32bit guests
Date: Wed, 7 Jan 2015 15:17:36 +0100 [thread overview]
Message-ID: <20150107141736.GH21092@cbox> (raw)
In-Reply-To: <1420627503-25183-1-git-send-email-marc.zyngier@arm.com>
On Wed, Jan 07, 2015 at 10:45:03AM +0000, Marc Zyngier wrote:
> Commit b856a59141b1 (arm/arm64: KVM: Reset the HCR on each vcpu
> when resetting the vcpu) moved the init of the HCR register to
> happen later in the init of a vcpu, but left out the fixup
> done in kvm_reset_vcpu when preparing for a 32bit guest.
>
> As a result, the 32bit guest is run as a 64bit guest, but the
> rest of the kernel still manages it as a 32bit. Fun follows.
>
> Moving the fixup to vcpu_reset_hcr solves the problem for good.
>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Whoops, thanks for the fix.
Acked-by: Christoffer Dall <christoffer.dall@linaro.org>
WARNING: multiple messages have this Message-ID (diff)
From: Christoffer Dall <christoffer.dall@linaro.org>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org
Subject: Re: [PATCH] arm64: KVM: Fix HCR setting for 32bit guests
Date: Wed, 7 Jan 2015 15:17:36 +0100 [thread overview]
Message-ID: <20150107141736.GH21092@cbox> (raw)
In-Reply-To: <1420627503-25183-1-git-send-email-marc.zyngier@arm.com>
On Wed, Jan 07, 2015 at 10:45:03AM +0000, Marc Zyngier wrote:
> Commit b856a59141b1 (arm/arm64: KVM: Reset the HCR on each vcpu
> when resetting the vcpu) moved the init of the HCR register to
> happen later in the init of a vcpu, but left out the fixup
> done in kvm_reset_vcpu when preparing for a 32bit guest.
>
> As a result, the 32bit guest is run as a 64bit guest, but the
> rest of the kernel still manages it as a 32bit. Fun follows.
>
> Moving the fixup to vcpu_reset_hcr solves the problem for good.
>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Whoops, thanks for the fix.
Acked-by: Christoffer Dall <christoffer.dall@linaro.org>
next prev parent reply other threads:[~2015-01-07 14:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 10:45 [PATCH] arm64: KVM: Fix HCR setting for 32bit guests Marc Zyngier
2015-01-07 10:45 ` Marc Zyngier
2015-01-07 10:54 ` Vladimir Murzin
2015-01-07 10:54 ` Vladimir Murzin
2015-01-07 14:17 ` Christoffer Dall [this message]
2015-01-07 14:17 ` Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150107141736.GH21092@cbox \
--to=christoffer.dall@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.