All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lorenzo Pieralisi <lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org>
To: Mathieu Poirier
	<mathieu.poirier-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Pawel Moll <Pawel.Moll-5wv7dgnIgG8@public.gmane.org>,
	Mark Rutland <Mark.Rutland-5wv7dgnIgG8@public.gmane.org>,
	Ian Campbell
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	khilman-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH] ARM: vexpress: bindings: Add generic PD awareness to the spc controller
Date: Wed, 7 Jan 2015 15:57:47 +0000	[thread overview]
Message-ID: <20150107155747.GA31975@red-moon> (raw)
In-Reply-To: <CANLsYkxbMT1cYquZzbcYuo+=5xNBUhS6jJePovErwkaDDef_Gg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On Wed, Jan 07, 2015 at 02:33:38PM +0000, Mathieu Poirier wrote:

[...]

> >> > I will ask the vexpress maintainers where they want to see this code
> >> > going.  Would you accept this binding as part of the existing
> >> > "arm,vexpress-sysreg" [1] or even "arm,vexpress-scc" [2]?
> >
> > We are not CC'ed :). [2] is my answer, see below.
> 
> Thanks for the review - does it also mean you'd like to see the
> creation of the generic power domains moved to tc2_pm.c ?

Not necessarily, I think the creation is ok where it is, what we have
to do is to link the power domains to idle states instead of "disabling"
the spc power down command, see other thread.

I agree you need updated DT bindings for idle states to achieve that
and all the glue code that goes with it (in order for an idle state
to link to the power domain structs you are creating).

I copied in Kevin and Daniel since I know they are interested and are
working on this.

Thanks,
Lorenzo
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Rob Herring <robherring2@gmail.com>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <Pawel.Moll@arm.com>,
	Mark Rutland <Mark.Rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	khilman@linaro.org, daniel.lezcano@linaro.org
Subject: Re: [PATCH] ARM: vexpress: bindings: Add generic PD awareness to the spc controller
Date: Wed, 7 Jan 2015 15:57:47 +0000	[thread overview]
Message-ID: <20150107155747.GA31975@red-moon> (raw)
In-Reply-To: <CANLsYkxbMT1cYquZzbcYuo+=5xNBUhS6jJePovErwkaDDef_Gg@mail.gmail.com>

On Wed, Jan 07, 2015 at 02:33:38PM +0000, Mathieu Poirier wrote:

[...]

> >> > I will ask the vexpress maintainers where they want to see this code
> >> > going.  Would you accept this binding as part of the existing
> >> > "arm,vexpress-sysreg" [1] or even "arm,vexpress-scc" [2]?
> >
> > We are not CC'ed :). [2] is my answer, see below.
> 
> Thanks for the review - does it also mean you'd like to see the
> creation of the generic power domains moved to tc2_pm.c ?

Not necessarily, I think the creation is ok where it is, what we have
to do is to link the power domains to idle states instead of "disabling"
the spc power down command, see other thread.

I agree you need updated DT bindings for idle states to achieve that
and all the glue code that goes with it (in order for an idle state
to link to the power domain structs you are creating).

I copied in Kevin and Daniel since I know they are interested and are
working on this.

Thanks,
Lorenzo

  parent reply	other threads:[~2015-01-07 15:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-06 16:45 [PATCH] ARM: vexpress: bindings: Add generic PD awareness to the spc controller mathieu.poirier
     [not found] ` <1420562732-4353-1-git-send-email-mathieu.poirier-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-01-06 17:02   ` Rob Herring
2015-01-06 17:02     ` Rob Herring
2015-01-06 18:36     ` Mathieu Poirier
2015-01-06 22:01       ` Rob Herring
     [not found]         ` <CAL_JsqLv8Q4eS_bwuLbEOBSxjU7uff4__KcSi3qwAvgmjhQKHw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-07 10:54           ` Lorenzo Pieralisi
2015-01-07 10:54             ` Lorenzo Pieralisi
     [not found]             ` <20150107105438.GA7256-7AyDDHkRsp3ZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2015-01-07 14:33               ` Mathieu Poirier
2015-01-07 14:33                 ` Mathieu Poirier
     [not found]                 ` <CANLsYkxbMT1cYquZzbcYuo+=5xNBUhS6jJePovErwkaDDef_Gg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-07 15:57                   ` Lorenzo Pieralisi [this message]
2015-01-07 15:57                     ` Lorenzo Pieralisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150107155747.GA31975@red-moon \
    --to=lorenzo.pieralisi-5wv7dgnigg8@public.gmane.org \
    --cc=Mark.Rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=Pawel.Moll-5wv7dgnIgG8@public.gmane.org \
    --cc=daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
    --cc=khilman-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mathieu.poirier-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.