All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Foster <bfoster@redhat.com>
To: Nicholas Mc Guire <der.herr@hofr.at>
Cc: linux-kernel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix implicit bool to int conversion
Date: Thu, 8 Jan 2015 09:39:13 -0500	[thread overview]
Message-ID: <20150108143913.GD33789@bfoster.bfoster> (raw)
In-Reply-To: <1420721391-22717-1-git-send-email-der.herr@hofr.at>

On Thu, Jan 08, 2015 at 01:49:51PM +0100, Nicholas Mc Guire wrote:
> try_wait_for_completion returns bool so the wrapper function
> xfs_dqflock_nowait should probably also return bool and not int. 
> 
> Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
> ---

Indeed...

Reviewed-by: Brian Foster <bfoster@redhat.com>

> 
> patch was only compile tested x86_64_defconfig + CONFIG_XFS_FS=m
> CONFIG_XFS_QUOTA=y
> 
> patch is against linux-next 3.19.0-rc3 -next-20150107
> 
>  fs/xfs/xfs_dquot.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_dquot.h b/fs/xfs/xfs_dquot.h
> index c24c67e..2f536f3 100644
> --- a/fs/xfs/xfs_dquot.h
> +++ b/fs/xfs/xfs_dquot.h
> @@ -86,7 +86,7 @@ static inline void xfs_dqflock(xfs_dquot_t *dqp)
>  	wait_for_completion(&dqp->q_flush);
>  }
>  
> -static inline int xfs_dqflock_nowait(xfs_dquot_t *dqp)
> +static inline bool xfs_dqflock_nowait(xfs_dquot_t *dqp)
>  {
>  	return try_wait_for_completion(&dqp->q_flush);
>  }
> -- 
> 1.7.10.4
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Brian Foster <bfoster@redhat.com>
To: Nicholas Mc Guire <der.herr@hofr.at>
Cc: Dave Chinner <david@fromorbit.com>,
	linux-kernel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix implicit bool to int conversion
Date: Thu, 8 Jan 2015 09:39:13 -0500	[thread overview]
Message-ID: <20150108143913.GD33789@bfoster.bfoster> (raw)
In-Reply-To: <1420721391-22717-1-git-send-email-der.herr@hofr.at>

On Thu, Jan 08, 2015 at 01:49:51PM +0100, Nicholas Mc Guire wrote:
> try_wait_for_completion returns bool so the wrapper function
> xfs_dqflock_nowait should probably also return bool and not int. 
> 
> Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
> ---

Indeed...

Reviewed-by: Brian Foster <bfoster@redhat.com>

> 
> patch was only compile tested x86_64_defconfig + CONFIG_XFS_FS=m
> CONFIG_XFS_QUOTA=y
> 
> patch is against linux-next 3.19.0-rc3 -next-20150107
> 
>  fs/xfs/xfs_dquot.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_dquot.h b/fs/xfs/xfs_dquot.h
> index c24c67e..2f536f3 100644
> --- a/fs/xfs/xfs_dquot.h
> +++ b/fs/xfs/xfs_dquot.h
> @@ -86,7 +86,7 @@ static inline void xfs_dqflock(xfs_dquot_t *dqp)
>  	wait_for_completion(&dqp->q_flush);
>  }
>  
> -static inline int xfs_dqflock_nowait(xfs_dquot_t *dqp)
> +static inline bool xfs_dqflock_nowait(xfs_dquot_t *dqp)
>  {
>  	return try_wait_for_completion(&dqp->q_flush);
>  }
> -- 
> 1.7.10.4
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2015-01-08 14:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-08 12:49 [PATCH] xfs: fix implicit bool to int conversion Nicholas Mc Guire
2015-01-08 12:49 ` Nicholas Mc Guire
2015-01-08 14:39 ` Brian Foster [this message]
2015-01-08 14:39   ` Brian Foster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150108143913.GD33789@bfoster.bfoster \
    --to=bfoster@redhat.com \
    --cc=der.herr@hofr.at \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.