From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 2/8] ARM64: Refactor kprobes-arm64
Date: Thu, 8 Jan 2015 17:36:00 +0000 [thread overview]
Message-ID: <20150108173600.GW11583@arm.com> (raw)
In-Reply-To: <54AEBF54.7000704@redhat.com>
On Thu, Jan 08, 2015 at 05:33:08PM +0000, Pratyush Anand wrote:
> On Thursday 08 January 2015 10:25 PM, Will Deacon wrote:
> > On Wed, Dec 31, 2014 at 03:21:18PM +0000, Pratyush Anand wrote:
> >> Most of the stuff of kprobes-arm64.c can also be used by uprobes.c. So
> >> move all those part to common code area. In the process rename kprobe to
> >> probe whereever possible.
> >>
> >> No functional change.
> >
> > In which case, can you merge this into the kprobes series (which we haven't
> > merged yet)?
> >
>
> Yes, thats why these are just RFCs. I will send next version of uprobe
> only after kprobe patches are accepted into maintainer's tree.
Ok, but it also makes sense to make kprobes refactoring changes *before* the
patches are merged, as that reduces churn in mainline whilst you don't have
any other dependencies.
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Pratyush Anand <panand@redhat.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"tixy@linaro.org" <tixy@linaro.org>,
"ananth@in.ibm.com" <ananth@in.ibm.com>,
"sandeepa.prabhu@linaro.org" <sandeepa.prabhu@linaro.org>,
Catalin Marinas <Catalin.Marinas@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"anil.s.keshavamurthy@intel.com" <anil.s.keshavamurthy@intel.com>,
"masami.hiramatsu.pt@hitachi.com"
<masami.hiramatsu.pt@hitachi.com>,
"wcohen@redhat.com" <wcohen@redhat.com>,
"oleg@redhat.com" <oleg@redhat.com>
Subject: Re: [RFC 2/8] ARM64: Refactor kprobes-arm64
Date: Thu, 8 Jan 2015 17:36:00 +0000 [thread overview]
Message-ID: <20150108173600.GW11583@arm.com> (raw)
In-Reply-To: <54AEBF54.7000704@redhat.com>
On Thu, Jan 08, 2015 at 05:33:08PM +0000, Pratyush Anand wrote:
> On Thursday 08 January 2015 10:25 PM, Will Deacon wrote:
> > On Wed, Dec 31, 2014 at 03:21:18PM +0000, Pratyush Anand wrote:
> >> Most of the stuff of kprobes-arm64.c can also be used by uprobes.c. So
> >> move all those part to common code area. In the process rename kprobe to
> >> probe whereever possible.
> >>
> >> No functional change.
> >
> > In which case, can you merge this into the kprobes series (which we haven't
> > merged yet)?
> >
>
> Yes, thats why these are just RFCs. I will send next version of uprobe
> only after kprobe patches are accepted into maintainer's tree.
Ok, but it also makes sense to make kprobes refactoring changes *before* the
patches are merged, as that reduces churn in mainline whilst you don't have
any other dependencies.
Will
next prev parent reply other threads:[~2015-01-08 17:36 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-31 15:21 [RFC 0/8] ARM64: Uprobe support added Pratyush Anand
2014-12-31 15:21 ` Pratyush Anand
2014-12-31 15:21 ` [RFC 1/8] ARM64: Move BRK opcodes defines from kprobes.h to insn.h Pratyush Anand
2015-01-08 16:55 ` Will Deacon
2015-01-08 16:55 ` Will Deacon
2015-01-08 17:31 ` Pratyush Anand
2015-01-08 17:31 ` Pratyush Anand
2014-12-31 15:21 ` [RFC 2/8] ARM64: Refactor kprobes-arm64 Pratyush Anand
2015-01-08 16:55 ` Will Deacon
2015-01-08 16:55 ` Will Deacon
2015-01-08 17:33 ` Pratyush Anand
2015-01-08 17:33 ` Pratyush Anand
2015-01-08 17:36 ` Will Deacon [this message]
2015-01-08 17:36 ` Will Deacon
2015-01-08 17:39 ` Pratyush Anand
2015-01-08 17:39 ` Pratyush Anand
2014-12-31 15:21 ` [RFC 3/8] Kernel/uprobe: Define arch_uprobe_exception_notify as __weak Pratyush Anand
2015-01-02 17:43 ` Oleg Nesterov
2015-01-02 17:43 ` Oleg Nesterov
2015-01-04 13:50 ` Pratyush Anand
2015-01-04 13:50 ` Pratyush Anand
2014-12-31 15:21 ` [RFC 4/8] ARM64: Add instruction_pointer_set function Pratyush Anand
2015-01-08 16:59 ` Will Deacon
2015-01-08 16:59 ` Will Deacon
2015-01-09 5:18 ` Pratyush Anand
2015-01-09 5:18 ` Pratyush Anand
2014-12-31 15:21 ` [RFC 5/8] ARM64: Re-factor flush_ptrace_access Pratyush Anand
2015-01-02 17:51 ` Oleg Nesterov
2015-01-02 17:51 ` Oleg Nesterov
2015-01-02 18:19 ` Oleg Nesterov
2015-01-02 18:19 ` Oleg Nesterov
2015-01-04 13:50 ` Pratyush Anand
2015-01-04 13:50 ` Pratyush Anand
2014-12-31 15:21 ` [RFC 6/8] ARM64: Handle TRAP_HWBRKPT for user mode as well Pratyush Anand
2015-01-02 18:05 ` Oleg Nesterov
2015-01-02 18:05 ` Oleg Nesterov
2015-01-08 17:01 ` Will Deacon
2015-01-08 17:01 ` Will Deacon
2015-01-08 17:51 ` Pratyush Anand
2015-01-08 17:51 ` Pratyush Anand
2014-12-31 15:21 ` [RFC 7/8] ARM64: Handle TRAP_BRKPT " Pratyush Anand
2014-12-31 15:21 ` [RFC 8/8] ARM64: Add uprobe support Pratyush Anand
2015-01-02 17:23 ` Oleg Nesterov
2015-01-02 17:23 ` Oleg Nesterov
2015-01-04 13:49 ` Pratyush Anand
2015-01-04 13:49 ` Pratyush Anand
2015-01-04 18:40 ` Oleg Nesterov
2015-01-04 18:40 ` Oleg Nesterov
2015-01-05 4:17 ` Pratyush Anand
2015-01-05 4:17 ` Pratyush Anand
2015-01-08 17:03 ` Will Deacon
2015-01-08 17:03 ` Will Deacon
2015-01-08 17:54 ` Pratyush Anand
2015-01-08 17:54 ` Pratyush Anand
2015-01-09 17:45 ` Oleg Nesterov
2015-01-09 17:45 ` Oleg Nesterov
2015-01-12 4:50 ` Pratyush Anand
2015-01-12 4:50 ` Pratyush Anand
2015-01-09 17:59 ` Oleg Nesterov
2015-01-09 17:59 ` Oleg Nesterov
2015-01-12 5:04 ` Pratyush Anand
2015-01-12 5:04 ` Pratyush Anand
2015-01-12 6:45 ` Pratyush Anand
2015-01-12 6:45 ` Pratyush Anand
2015-01-12 14:38 ` Oleg Nesterov
2015-01-12 14:38 ` Oleg Nesterov
2015-01-12 14:28 ` Oleg Nesterov
2015-01-12 14:28 ` Oleg Nesterov
2015-01-01 1:59 ` [RFC 0/8] ARM64: Uprobe support added Pratyush Anand
2015-01-01 1:59 ` Pratyush Anand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150108173600.GW11583@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.