All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH f2fs] f2fs: pids_lock can be static
  2015-01-08 19:38 [f2fs:linux-3.4 31/33] fs/f2fs/trace.c:19:12: sparse: symbol 'pids_lock' was not declared. Should it be static? kbuild test robot
@ 2015-01-08 19:38 ` kbuild test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2015-01-08 19:38 UTC (permalink / raw)
  To: Jaegeuk Kim; +Cc: kbuild-all, Changman Lee, linux-f2fs-devel, linux-kernel

fs/f2fs/trace.c:19:12: sparse: symbol 'pids_lock' was not declared. Should it be static?

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 trace.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/trace.c b/fs/f2fs/trace.c
index 92fa38a..517dfe5 100644
--- a/fs/f2fs/trace.c
+++ b/fs/f2fs/trace.c
@@ -16,7 +16,7 @@
 #include "trace.h"
 
 RADIX_TREE(pids, GFP_ATOMIC);
-spinlock_t pids_lock;
+static spinlock_t pids_lock;
 struct last_io_info last_io;
 
 static inline void __print_last_io(void)

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [f2fs:linux-3.4 31/33] fs/f2fs/trace.c:19:12: sparse: symbol 'pids_lock' was not declared. Should it be static?
@ 2015-01-08 19:38 kbuild test robot
  2015-01-08 19:38 ` [PATCH f2fs] f2fs: pids_lock can be static kbuild test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2015-01-08 19:38 UTC (permalink / raw)
  To: Jaegeuk Kim; +Cc: kbuild-all, Changman Lee, linux-f2fs-devel, linux-kernel

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs linux-3.4
head:   a725baf7b8472a0b97dc12ed4d1c147cad2f3e8c
commit: 37a78eb5019798c94d4543c48e1d6490a552e1c7 [31/33] f2fs: add spin_lock to cover radix operations in IO tracer
reproduce:
  # apt-get install sparse
  git checkout 37a78eb5019798c94d4543c48e1d6490a552e1c7
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> fs/f2fs/trace.c:19:12: sparse: symbol 'pids_lock' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-01-08 19:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-08 19:38 [f2fs:linux-3.4 31/33] fs/f2fs/trace.c:19:12: sparse: symbol 'pids_lock' was not declared. Should it be static? kbuild test robot
2015-01-08 19:38 ` [PATCH f2fs] f2fs: pids_lock can be static kbuild test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.