From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Paul Walmsley <paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Alexandre Courbot
<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] soc/tegra: pmc: Add Tegra132 support
Date: Fri, 9 Jan 2015 11:12:53 +0100 [thread overview]
Message-ID: <20150109101252.GG27845@ulmo> (raw)
In-Reply-To: <alpine.DEB.2.02.1501082232280.28771-rwI8Ez+7Ko+d5PgPZx9QOdBPR1lH4CV8@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 999 bytes --]
On Thu, Jan 08, 2015 at 10:34:35PM +0000, Paul Walmsley wrote:
> On Thu, 8 Jan 2015, Thierry Reding wrote:
>
> > From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> >
> > Tegra132 uses the same GPU as Tegra124 and the same special-case is
> > needed to remove clamps. However Tegra132 has a separate chip ID, so in
> > order to avoid having to extend the list of chip IDs for the special
> > case, add a feature flag to the SoC data.
> >
> > Signed-off-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> Reviewed-by: Paul Walmsley <pwalmsley-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> Nit: not sure I would call it a special-case; to me it's more of an
> evolutionary change due to the radically different GPU in T124 & T132.
I reworded the commit message slightly, so it says:
Tegra132 uses the same GPU as Tegra124 and therefore requires the same
method to remove clamps. ...
I hope that's less misleading.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] soc/tegra: pmc: Add Tegra132 support
Date: Fri, 9 Jan 2015 11:12:53 +0100 [thread overview]
Message-ID: <20150109101252.GG27845@ulmo> (raw)
In-Reply-To: <alpine.DEB.2.02.1501082232280.28771@utopia.booyaka.com>
On Thu, Jan 08, 2015 at 10:34:35PM +0000, Paul Walmsley wrote:
> On Thu, 8 Jan 2015, Thierry Reding wrote:
>
> > From: Thierry Reding <treding@nvidia.com>
> >
> > Tegra132 uses the same GPU as Tegra124 and the same special-case is
> > needed to remove clamps. However Tegra132 has a separate chip ID, so in
> > order to avoid having to extend the list of chip IDs for the special
> > case, add a feature flag to the SoC data.
> >
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
>
> Reviewed-by: Paul Walmsley <pwalmsley@nvidia.com>
>
> Nit: not sure I would call it a special-case; to me it's more of an
> evolutionary change due to the radically different GPU in T124 & T132.
I reworded the commit message slightly, so it says:
Tegra132 uses the same GPU as Tegra124 and therefore requires the same
method to remove clamps. ...
I hope that's less misleading.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150109/493b4c66/attachment.sig>
next prev parent reply other threads:[~2015-01-09 10:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 7:20 [PATCH] soc/tegra: pmc: Add Tegra132 support Thierry Reding
2015-01-08 7:20 ` Thierry Reding
2015-01-08 22:34 ` Paul Walmsley
2015-01-08 22:34 ` Paul Walmsley
[not found] ` <alpine.DEB.2.02.1501082232280.28771-rwI8Ez+7Ko+d5PgPZx9QOdBPR1lH4CV8@public.gmane.org>
2015-01-09 10:12 ` Thierry Reding [this message]
2015-01-09 10:12 ` Thierry Reding
2015-01-09 20:02 ` Paul Walmsley
2015-01-09 20:02 ` Paul Walmsley
[not found] ` <1420701657-32543-1-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-01-09 10:15 ` [PATCH v2] " Thierry Reding
2015-01-09 10:15 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150109101252.GG27845@ulmo \
--to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.