All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian De Wolf <bldewolf@cpp.edu>
To: "dm-devel@redhat.com" <dm-devel@redhat.com>
Subject: multipath-tools-0.5.0 segfault with blacklist/blacklist_exceptions
Date: Mon, 12 Jan 2015 16:55:57 -0800	[thread overview]
Message-ID: <20150112165557.484d9e3e@cpp.edu> (raw)

Hello,

I was upgrading multipath-tools and noticed our old config causes the
various programs to segfault in libmultipath.  The culprit appeared to
be our blacklist entries with a vendor listed but no product (for
filtering the local disk controllers), e.g:

	blacklist {
		device {
			vendor "LSILOGIC"
		}
	}

Adding a product of .* makes things work as expected, but this
shouldn't be necessary.  It looks like this is because compiling the
product regex is optional:

http://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=blob;f=libmultipath/blacklist.c;h=3f9e80b6bf92502ce01a4a287d17039a1ad9c2ce;hb=HEAD#l89

But the regexec is not:

http://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=blob;f=libmultipath/blacklist.c;h=3f9e80b6bf92502ce01a4a287d17039a1ad9c2ce;hb=HEAD#l151

I couldn't find any posts about this and it didn't look fixed yet,
so I figured I should report the issue.

             reply	other threads:[~2015-01-13  0:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-13  0:55 Brian De Wolf [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-01-12 20:05 multipath-tools-0.5.0 segfault with blacklist/blacklist_exceptions Brian De Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150112165557.484d9e3e@cpp.edu \
    --to=bldewolf@cpp.edu \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.