All of lore.kernel.org
 help / color / mirror / Atom feed
* multipath-tools-0.5.0 segfault with blacklist/blacklist_exceptions
@ 2015-01-13  0:55 Brian De Wolf
  0 siblings, 0 replies; 2+ messages in thread
From: Brian De Wolf @ 2015-01-13  0:55 UTC (permalink / raw)
  To: dm-devel@redhat.com

Hello,

I was upgrading multipath-tools and noticed our old config causes the
various programs to segfault in libmultipath.  The culprit appeared to
be our blacklist entries with a vendor listed but no product (for
filtering the local disk controllers), e.g:

	blacklist {
		device {
			vendor "LSILOGIC"
		}
	}

Adding a product of .* makes things work as expected, but this
shouldn't be necessary.  It looks like this is because compiling the
product regex is optional:

http://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=blob;f=libmultipath/blacklist.c;h=3f9e80b6bf92502ce01a4a287d17039a1ad9c2ce;hb=HEAD#l89

But the regexec is not:

http://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=blob;f=libmultipath/blacklist.c;h=3f9e80b6bf92502ce01a4a287d17039a1ad9c2ce;hb=HEAD#l151

I couldn't find any posts about this and it didn't look fixed yet,
so I figured I should report the issue.

^ permalink raw reply	[flat|nested] 2+ messages in thread
* multipath-tools-0.5.0 segfault with blacklist/blacklist_exceptions
@ 2015-01-12 20:05 Brian De Wolf
  0 siblings, 0 replies; 2+ messages in thread
From: Brian De Wolf @ 2015-01-12 20:05 UTC (permalink / raw)
  To: dm-devel

Hello,

I was upgrading multipath-tools and noticed our old config causes the
various programs to segfault in libmultipath.  The culprit appeared to
be our blacklist entries with a vendor listed but no product (for
filtering the local disk controllers), e.g:

	blacklist {
		device {
			vendor "LSILOGIC"
		}
	}

Adding a product of .* makes things work as expected, but this
shouldn't be necessary.  It looks like this is because compiling the
product regex is optional:

http://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=blob;f=libmultipath/blacklist.c;h=3f9e80b6bf92502ce01a4a287d17039a1ad9c2ce;hb=HEAD#l89

But the regexec is not:

http://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=blob;f=libmultipath/blacklist.c;h=3f9e80b6bf92502ce01a4a287d17039a1ad9c2ce;hb=HEAD#l151

I couldn't find any posts about this and it didn't look fixed yet,
so I figured I should report the issue.

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-13  0:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-13  0:55 multipath-tools-0.5.0 segfault with blacklist/blacklist_exceptions Brian De Wolf
  -- strict thread matches above, loose matches on Subject: below --
2015-01-12 20:05 Brian De Wolf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.