All of lore.kernel.org
 help / color / mirror / Atom feed
From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/6] ARM: at91/dt: add SRAM nodes
Date: Tue, 13 Jan 2015 23:50:21 +0100	[thread overview]
Message-ID: <20150113225021.GG3843@piout.net> (raw)
In-Reply-To: <1421172746-18727-5-git-send-email-alexandre.belloni@free-electrons.com>

Hi,

On 13/01/2015 at 19:12:24 +0100, Alexandre Belloni wrote :
> diff --git a/arch/arm/boot/dts/at91sam9rl.dtsi b/arch/arm/boot/dts/at91sam9rl.dtsi
> index 72424371413e..c055da2f151f 100644
> --- a/arch/arm/boot/dts/at91sam9rl.dtsi
> +++ b/arch/arm/boot/dts/at91sam9rl.dtsi
> @@ -70,6 +70,11 @@
>  		};
>  	};
>  
> +	sram: sram at 00300000 {
> +		compatible = "mmio-sram";
> +		reg = <0x00300000 0x4000>;
> +	};
> +

Actually, I'm not sure about the sam9rl. The previous code was doing:
        switch (at91_soc_initdata.cidr & AT91_CIDR_SRAMSIZ) {
                case AT91_CIDR_SRAMSIZ_32K:
                        sram_size = 2 * SZ_16K;
                        break;
                case AT91_CIDR_SRAMSIZ_16K:
                default:
                        sram_size = SZ_16K;
        }

So the SRAM size should be 16k or 32k but what I get from the only cidr
registered for sam9rl (0x019b03a0, also from the datasheet) is SRAMSIZ=
0xb which give 64k. Could you confirm?

Thanks,

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Bo Shen <voice.shen@atmel.com>,
	Boris Brezillon <boris.brezillon@free-electrons.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/6] ARM: at91/dt: add SRAM nodes
Date: Tue, 13 Jan 2015 23:50:21 +0100	[thread overview]
Message-ID: <20150113225021.GG3843@piout.net> (raw)
In-Reply-To: <1421172746-18727-5-git-send-email-alexandre.belloni@free-electrons.com>

Hi,

On 13/01/2015 at 19:12:24 +0100, Alexandre Belloni wrote :
> diff --git a/arch/arm/boot/dts/at91sam9rl.dtsi b/arch/arm/boot/dts/at91sam9rl.dtsi
> index 72424371413e..c055da2f151f 100644
> --- a/arch/arm/boot/dts/at91sam9rl.dtsi
> +++ b/arch/arm/boot/dts/at91sam9rl.dtsi
> @@ -70,6 +70,11 @@
>  		};
>  	};
>  
> +	sram: sram@00300000 {
> +		compatible = "mmio-sram";
> +		reg = <0x00300000 0x4000>;
> +	};
> +

Actually, I'm not sure about the sam9rl. The previous code was doing:
        switch (at91_soc_initdata.cidr & AT91_CIDR_SRAMSIZ) {
                case AT91_CIDR_SRAMSIZ_32K:
                        sram_size = 2 * SZ_16K;
                        break;
                case AT91_CIDR_SRAMSIZ_16K:
                default:
                        sram_size = SZ_16K;
        }

So the SRAM size should be 16k or 32k but what I get from the only cidr
registered for sam9rl (0x019b03a0, also from the datasheet) is SRAMSIZ=
0xb which give 64k. Could you confirm?

Thanks,

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-01-13 22:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-13 18:12 [PATCH v3 0/6] AT91 DT for 3.20 #1 Alexandre Belloni
2015-01-13 18:12 ` Alexandre Belloni
2015-01-13 18:12 ` [PATCH v3 1/6] ARM: at91/dt: at91sam9n12: Add RTC node Alexandre Belloni
2015-01-13 18:12   ` Alexandre Belloni
2015-01-13 18:12 ` [PATCH v3 2/6] ARM: at91/dt: rm9200: add " Alexandre Belloni
2015-01-13 18:12   ` Alexandre Belloni
2015-01-13 18:12 ` [PATCH v3 3/6] ARM: at91/dt: at91rm9200ek: enable RTC Alexandre Belloni
2015-01-13 18:12   ` Alexandre Belloni
2015-01-13 18:12 ` [PATCH v3 4/6] ARM: at91/dt: add SRAM nodes Alexandre Belloni
2015-01-13 18:12   ` Alexandre Belloni
2015-01-13 22:50   ` Alexandre Belloni [this message]
2015-01-13 22:50     ` Alexandre Belloni
2015-01-13 18:12 ` [PATCH v3 5/6] ARM: at91/dt: Add a dtsi for at91sam9xe Alexandre Belloni
2015-01-13 18:12   ` Alexandre Belloni
2015-01-13 18:12 ` [PATCH v3 6/6] ARM: at91/dt: ethernut5: use at91sam9xe.dtsi Alexandre Belloni
2015-01-13 18:12   ` Alexandre Belloni
2015-01-15 14:34 ` [PATCH v3 0/6] AT91 DT for 3.20 #1 Nicolas Ferre
2015-01-15 14:34   ` Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150113225021.GG3843@piout.net \
    --to=alexandre.belloni@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.