From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Sixt <j6t@kdbg.org>, Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] t1050-large: replace dd by test-genrandom
Date: Wed, 14 Jan 2015 06:27:00 -0500 [thread overview]
Message-ID: <20150114112659.GA23474@peff.net> (raw)
In-Reply-To: <xmqq4mruckrp.fsf@gitster.dls.corp.google.com>
On Tue, Jan 13, 2015 at 03:40:10PM -0800, Junio C Hamano wrote:
> >> - test-genrandom seed2 2500000 >huge &&
> >> + printf "\0%2500000s" Y >huge &&
> [...]
> Are we depending on the binary-ness of these test files by the way?
> The leading NUL \0 looked a bit strange to me.
I don't think so. We do not want to do a text diff, because that would
overflow our GIT_ALLOC_LIMIT. But the core.bigfilethreshold check is
what will make them binary, not the actual content. So a gigantic text
file is arguably a better test of the feature in question.
-Peff
next prev parent reply other threads:[~2015-01-14 11:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 17:36 [PATCH] t1050-large: replace dd by test-genrandom Johannes Sixt
2015-01-13 18:56 ` Junio C Hamano
2015-01-13 19:55 ` Johannes Sixt
2015-01-13 21:47 ` Jeff King
2015-01-13 22:33 ` Johannes Sixt
2015-01-13 22:38 ` Jeff King
2015-01-13 23:40 ` Junio C Hamano
2015-01-14 11:27 ` Jeff King [this message]
2015-01-14 17:31 ` Junio C Hamano
2015-01-14 20:28 ` [PATCH v2] t1050-large: generate large files without dd Johannes Sixt
2015-01-14 21:00 ` Jeff King
2015-01-14 21:17 ` Johannes Sixt
2015-01-14 21:59 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150114112659.GA23474@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.