All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Sixt <j6t@kdbg.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] t1050-large: replace dd by test-genrandom
Date: Tue, 13 Jan 2015 20:55:22 +0100	[thread overview]
Message-ID: <54B5782A.2010003@kdbg.org> (raw)
In-Reply-To: <xmqqtwzucxwf.fsf@gitster.dls.corp.google.com>

Am 13.01.2015 um 19:56 schrieb Junio C Hamano:
> Johannes Sixt <j6t@kdbg.org> writes:
>> The new code does change some properties of the generated files:
>>
>>  - They are a bit smaller.
>>  - They are not sparse anymore.
>>  - They do not compress well anymore.
>>  - The smaller of the four files is now a prefix of the larger.

Would you kindly strike the last bullet point when you apply the patch,
because it is not true, as I just noticed:

>> +	test-genrandom seed1 2000000 >large1 &&
...
>> +	test-genrandom seed2 2500000 >huge &&

The seeds are different so that the files are completely dissimilar.
This does not affect the rest of the analysis I gave in the commit message.

Thanks,
-- Hannes

  reply	other threads:[~2015-01-13 19:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-13 17:36 [PATCH] t1050-large: replace dd by test-genrandom Johannes Sixt
2015-01-13 18:56 ` Junio C Hamano
2015-01-13 19:55   ` Johannes Sixt [this message]
2015-01-13 21:47 ` Jeff King
2015-01-13 22:33   ` Johannes Sixt
2015-01-13 22:38     ` Jeff King
2015-01-13 23:40       ` Junio C Hamano
2015-01-14 11:27         ` Jeff King
2015-01-14 17:31           ` Junio C Hamano
2015-01-14 20:28           ` [PATCH v2] t1050-large: generate large files without dd Johannes Sixt
2015-01-14 21:00             ` Jeff King
2015-01-14 21:17               ` Johannes Sixt
2015-01-14 21:59               ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B5782A.2010003@kdbg.org \
    --to=j6t@kdbg.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.