From: Cyrill Gorcunov <gorcunov@gmail.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
linux-mm@kvack.org, Pavel Emelyanov <xemul@openvz.org>,
linux-kernel@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH 1/2] mm: rename mm->nr_ptes to mm->nr_pgtables
Date: Wed, 14 Jan 2015 17:48:43 +0300 [thread overview]
Message-ID: <20150114144843.GE2253@moon> (raw)
In-Reply-To: <20150114143358.GA9820@node.dhcp.inet.fi>
On Wed, Jan 14, 2015 at 04:33:58PM +0200, Kirill A. Shutemov wrote:
> >
> > It looks like this doesn't matter. The statistics here prints the size
> > of summary memory occupied for pte_t entries, here PTRS_PER_PTE * sizeof(pte_t)
> > is only valid for, once we start accounting pmd into same counter it implies
> > that PTRS_PER_PTE == PTRS_PER_PMD, which is not true for all archs
> > (if I understand the idea of accounting here right).
>
> Yeah. good catch. Thank you.
>
> I'll respin with separate counter for pmd tables. It seems the best
> option.
Sounds good to me, thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
linux-mm@kvack.org, Pavel Emelyanov <xemul@openvz.org>,
linux-kernel@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH 1/2] mm: rename mm->nr_ptes to mm->nr_pgtables
Date: Wed, 14 Jan 2015 17:48:43 +0300 [thread overview]
Message-ID: <20150114144843.GE2253@moon> (raw)
In-Reply-To: <20150114143358.GA9820@node.dhcp.inet.fi>
On Wed, Jan 14, 2015 at 04:33:58PM +0200, Kirill A. Shutemov wrote:
> >
> > It looks like this doesn't matter. The statistics here prints the size
> > of summary memory occupied for pte_t entries, here PTRS_PER_PTE * sizeof(pte_t)
> > is only valid for, once we start accounting pmd into same counter it implies
> > that PTRS_PER_PTE == PTRS_PER_PMD, which is not true for all archs
> > (if I understand the idea of accounting here right).
>
> Yeah. good catch. Thank you.
>
> I'll respin with separate counter for pmd tables. It seems the best
> option.
Sounds good to me, thanks.
next prev parent reply other threads:[~2015-01-14 14:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 19:14 [PATCH 0/2] Account PMD page tables to the process Kirill A. Shutemov
2015-01-13 19:14 ` Kirill A. Shutemov
2015-01-13 19:14 ` [PATCH 1/2] mm: rename mm->nr_ptes to mm->nr_pgtables Kirill A. Shutemov
2015-01-13 19:14 ` Kirill A. Shutemov
2015-01-13 20:36 ` Dave Hansen
2015-01-13 20:36 ` Dave Hansen
2015-01-13 20:41 ` Kirill A. Shutemov
2015-01-13 20:41 ` Kirill A. Shutemov
2015-01-13 21:35 ` Dave Hansen
2015-01-13 21:35 ` Dave Hansen
2015-01-13 21:43 ` Cyrill Gorcunov
2015-01-13 21:43 ` Cyrill Gorcunov
2015-01-13 21:49 ` Dave Hansen
2015-01-13 21:49 ` Dave Hansen
2015-01-14 9:45 ` Cyrill Gorcunov
2015-01-14 9:45 ` Cyrill Gorcunov
2015-01-14 14:33 ` Kirill A. Shutemov
2015-01-14 14:33 ` Kirill A. Shutemov
2015-01-14 14:48 ` Cyrill Gorcunov [this message]
2015-01-14 14:48 ` Cyrill Gorcunov
2015-01-13 19:14 ` [PATCH 2/2] mm: account pmd page tables to the process Kirill A. Shutemov
2015-01-13 19:14 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150114144843.GE2253@moon \
--to=gorcunov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=dave.hansen@linux.intel.com \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.