All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
	Gleb Natapov <gleb@kernel.org>, Feng Wu <feng.wu@intel.com>
Subject: Re: [PATCH] KVM: x86: amend APIC lowest priority arbitration
Date: Wed, 14 Jan 2015 18:04:08 +0100	[thread overview]
Message-ID: <20150114170407.GA1298@potion.brq.redhat.com> (raw)
In-Reply-To: <1420814246-19033-1-git-send-email-rkrcmar@redhat.com>

2015-01-09 15:37+0100, Radim Krčmář:
> Lowest priority should take the task priority into account.
> 
> SDM 10.6.2.4 Lowest Priority Delivery Mode.
> (Too long to quote; second and last paragraphs are relevant.)
> 
> Before this patch, we strived to have the same amount of handled
> lowest-priority interrupts on all VCPUs.
> This is only a complication, but kept for compatibility.

> Real modern Intels can't send lowest priority IPIs and the chipset
> directs external ones using processors' TPR.

False, new Intels most likely don't consider TPR.
Please don't include this patch.

> AMD still has rough edges.

AMD behaves like its documentation states,

> +	/* XXX: AMD (2:16.6.2 Lowest Priority Messages and Arbitration)
> +	 *      - uses the APR register (which also considers ISR and IRR),
> +	 *      - chooses the highest APIC ID when APRs are identical,
> +	 *      - and allows a focus processor.

but we don't differentiate.  (It shouldn't create AMD-specific bugs.)

      reply	other threads:[~2015-01-14 17:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-09 14:37 [PATCH] KVM: x86: amend APIC lowest priority arbitration Radim Krčmář
2015-01-14 17:04 ` Radim Krčmář [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150114170407.GA1298@potion.brq.redhat.com \
    --to=rkrcmar@redhat.com \
    --cc=feng.wu@intel.com \
    --cc=gleb@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.