From: Felipe Balbi <balbi@ti.com>
To: Mugunthan V N <mugunthanvnm@ti.com>
Cc: Felipe Balbi <balbi@ti.com>,
davem@davemloft.net, Tony Lindgren <tony@atomide.com>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
netdev@vger.kernel.org
Subject: Re: [patch-net-next v2 3/3] net: ethernet: cpsw: don't requests IRQs we don't use
Date: Thu, 15 Jan 2015 09:20:53 -0600 [thread overview]
Message-ID: <20150115152053.GA16409@saruman> (raw)
In-Reply-To: <54B770FC.6060003@ti.com>
[-- Attachment #1: Type: text/plain, Size: 754 bytes --]
On Thu, Jan 15, 2015 at 01:19:16PM +0530, Mugunthan V N wrote:
> On Wednesday 14 January 2015 10:28 PM, Felipe Balbi wrote:
> > CPSW never uses RX_THRESHOLD or MISC interrupts. In
> > fact, they are always kept masked in their appropriate
> > IRQ Enable register.
> >
> > Instead of allocating an IRQ that never fires, it's best
> > to remove that code altogether and let future patches
> > implement it if anybody needs those.
> >
> > Signed-off-by: Felipe Balbi <balbi@ti.com>
>
> Instead of introducing dummy ISR in previous patch and then removing in
> this patch, both can be squashed into a single patch.
sure they can. I decided to split to ease review and to make sure only
one thing happens in a single patch.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@ti.com>
To: Mugunthan V N <mugunthanvnm@ti.com>
Cc: Felipe Balbi <balbi@ti.com>, <davem@davemloft.net>,
Tony Lindgren <tony@atomide.com>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
<netdev@vger.kernel.org>
Subject: Re: [patch-net-next v2 3/3] net: ethernet: cpsw: don't requests IRQs we don't use
Date: Thu, 15 Jan 2015 09:20:53 -0600 [thread overview]
Message-ID: <20150115152053.GA16409@saruman> (raw)
In-Reply-To: <54B770FC.6060003@ti.com>
[-- Attachment #1: Type: text/plain, Size: 754 bytes --]
On Thu, Jan 15, 2015 at 01:19:16PM +0530, Mugunthan V N wrote:
> On Wednesday 14 January 2015 10:28 PM, Felipe Balbi wrote:
> > CPSW never uses RX_THRESHOLD or MISC interrupts. In
> > fact, they are always kept masked in their appropriate
> > IRQ Enable register.
> >
> > Instead of allocating an IRQ that never fires, it's best
> > to remove that code altogether and let future patches
> > implement it if anybody needs those.
> >
> > Signed-off-by: Felipe Balbi <balbi@ti.com>
>
> Instead of introducing dummy ISR in previous patch and then removing in
> this patch, both can be squashed into a single patch.
sure they can. I decided to split to ease review and to make sure only
one thing happens in a single patch.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-01-15 15:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 16:58 [patch-net-next v2 1/3] net: ethernet: cpsw: unroll IRQ request loop Felipe Balbi
2015-01-14 16:58 ` Felipe Balbi
2015-01-14 16:58 ` [patch-net-next v2 2/3] net: ethernet: cpsw: split out IRQ handler Felipe Balbi
2015-01-14 16:58 ` Felipe Balbi
2015-01-14 16:58 ` [patch-net-next v2 3/3] net: ethernet: cpsw: don't requests IRQs we don't use Felipe Balbi
2015-01-14 16:58 ` Felipe Balbi
2015-01-15 7:49 ` Mugunthan V N
2015-01-15 7:49 ` Mugunthan V N
2015-01-15 15:20 ` Felipe Balbi [this message]
2015-01-15 15:20 ` Felipe Balbi
2015-01-15 23:16 ` David Miller
2015-01-16 1:28 ` Felipe Balbi
2015-01-16 1:28 ` Felipe Balbi
2015-01-16 4:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150115152053.GA16409@saruman \
--to=balbi@ti.com \
--cc=davem@davemloft.net \
--cc=linux-omap@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.