From: Wolfram Sang <wsa@the-dreams.de>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: linux-input@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-sh@vger.kernel.org, Geert Uytterhoeven <geert@glider.be>
Subject: Re: [PATCH v2 2/2] input: adxl34x: Add OF match support
Date: Thu, 15 Jan 2015 17:55:56 +0100 [thread overview]
Message-ID: <20150115165556.GA6272@katana> (raw)
In-Reply-To: <1421333655-31029-3-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
[-- Attachment #1: Type: text/plain, Size: 887 bytes --]
On Thu, Jan 15, 2015 at 04:54:15PM +0200, Laurent Pinchart wrote:
> The I2C subsystem can match devices without explicit OF support based on
> the part of their compatible property after the comma. However, this
> mechanism uses the first compatible value only. For adxl34x OF device
> nodes the compatible property will contain the more specific
> "adi,adxl345" or "adi,adxl346" value first. This prevents the device
> node from being matched with the adxl34x driver.
>
> Fix this by adding an OF match table with an "adi,adxl345" compatible
> entry. There's no need to add the "adi,adxl346" entry as the ADXL346 is
> backward-compatible with the ADXL345 with differences handled by runtime
> detection of the device model.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: linux-input@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-sh@vger.kernel.org, Geert Uytterhoeven <geert@glider.be>
Subject: Re: [PATCH v2 2/2] input: adxl34x: Add OF match support
Date: Thu, 15 Jan 2015 16:55:56 +0000 [thread overview]
Message-ID: <20150115165556.GA6272@katana> (raw)
In-Reply-To: <1421333655-31029-3-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
[-- Attachment #1: Type: text/plain, Size: 887 bytes --]
On Thu, Jan 15, 2015 at 04:54:15PM +0200, Laurent Pinchart wrote:
> The I2C subsystem can match devices without explicit OF support based on
> the part of their compatible property after the comma. However, this
> mechanism uses the first compatible value only. For adxl34x OF device
> nodes the compatible property will contain the more specific
> "adi,adxl345" or "adi,adxl346" value first. This prevents the device
> node from being matched with the adxl34x driver.
>
> Fix this by adding an OF match table with an "adi,adxl345" compatible
> entry. There's no need to add the "adi,adxl346" entry as the ADXL346 is
> backward-compatible with the ADXL345 with differences handled by runtime
> detection of the device model.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-01-15 16:55 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-15 14:54 [PATCH v2 0/2] Fix OF match for adxl34x driver Laurent Pinchart
2015-01-15 14:54 ` Laurent Pinchart
2015-01-15 14:54 ` [PATCH v2 1/2] DT: i2c: Deprecate adi,adxl34x compatible string Laurent Pinchart
2015-01-15 14:54 ` Laurent Pinchart
[not found] ` <1421333655-31029-2-git-send-email-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
2015-01-15 17:02 ` Wolfram Sang
2015-01-15 17:02 ` Wolfram Sang
2015-01-15 17:27 ` Dmitry Torokhov
2015-01-15 17:27 ` Dmitry Torokhov
2015-01-15 17:32 ` Geert Uytterhoeven
2015-01-15 17:32 ` Geert Uytterhoeven
[not found] ` <CAMuHMdW7ETcFGSPiE9BWA2dAE93477fzoyF-+_EaiPSDT9WMWA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-15 17:43 ` Wolfram Sang
2015-01-15 17:43 ` Wolfram Sang
2015-01-15 17:51 ` Geert Uytterhoeven
2015-01-15 17:51 ` Geert Uytterhoeven
2015-01-26 12:09 ` Wolfram Sang
2015-01-26 12:09 ` Wolfram Sang
2015-02-26 14:27 ` Laurent Pinchart
2015-02-26 14:27 ` Laurent Pinchart
2015-03-02 6:40 ` Wolfram Sang
2015-03-02 6:40 ` Wolfram Sang
2015-03-02 22:52 ` Laurent Pinchart
2015-03-02 22:52 ` Laurent Pinchart
2015-01-15 20:51 ` Laurent Pinchart
2015-01-15 20:51 ` Laurent Pinchart
2015-01-26 12:12 ` Wolfram Sang
2015-01-26 12:12 ` Wolfram Sang
2015-01-15 17:49 ` Geert Uytterhoeven
2015-01-15 17:49 ` Geert Uytterhoeven
2015-01-15 14:54 ` [PATCH v2 2/2] input: adxl34x: Add OF match support Laurent Pinchart
2015-01-15 14:54 ` Laurent Pinchart
2015-01-15 16:55 ` Wolfram Sang [this message]
2015-01-15 16:55 ` Wolfram Sang
[not found] ` <1421333655-31029-3-git-send-email-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
2015-01-15 17:45 ` Geert Uytterhoeven
2015-01-15 17:45 ` Geert Uytterhoeven
[not found] ` <CAMuHMdWmGi6qKKt5YJm1i7FqDceqKosxsSRJRd8zqXO9jMzyoQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-15 18:54 ` Dmitry Torokhov
2015-01-15 18:54 ` Dmitry Torokhov
2015-01-15 20:00 ` Geert Uytterhoeven
2015-01-15 20:00 ` Geert Uytterhoeven
[not found] ` <CAMuHMdXrRtgAahaEUh8x61E-koE25VL-6LOJrkjx4_fohKQtwQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-15 20:34 ` Laurent Pinchart
2015-01-15 20:34 ` Laurent Pinchart
2015-01-15 21:06 ` Dmitry Torokhov
2015-01-15 21:06 ` Dmitry Torokhov
2015-01-15 21:34 ` Laurent Pinchart
2015-01-15 21:34 ` Laurent Pinchart
2015-01-15 21:50 ` Dmitry Torokhov
2015-01-15 21:50 ` Dmitry Torokhov
2015-01-15 22:09 ` Laurent Pinchart
2015-01-15 22:09 ` Laurent Pinchart
2015-01-15 22:05 ` Sergei Shtylyov
2015-01-15 22:05 ` Sergei Shtylyov
-- strict thread matches above, loose matches on Subject: below --
2015-05-21 11:42 [PATCH v2 0/2] Fix OF match for adxl34x driver Geert Uytterhoeven
[not found] ` <1432208546-18615-1-git-send-email-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
2015-05-21 11:42 ` [PATCH v2 2/2] input: adxl34x: Add OF match support Geert Uytterhoeven
2015-05-21 11:42 ` Geert Uytterhoeven
[not found] ` <1432208546-18615-3-git-send-email-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
2015-05-22 1:32 ` Simon Horman
2015-05-22 1:32 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150115165556.GA6272@katana \
--to=wsa@the-dreams.de \
--cc=geert@glider.be \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.