From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Thomas Gleixner <tglx@linutronix.de>,
Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
Wim Van Sebroeck <wim@iguana.be>,
Guenter Roeck <linux@roeck-us.net>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v3 7/8] clocksource: atmel-st: use syscon/regmap
Date: Thu, 15 Jan 2015 18:02:37 +0100 [thread overview]
Message-ID: <20150115170237.GV3843@piout.net> (raw)
In-Reply-To: <54B7ED85.2090700@linaro.org>
On 15/01/2015 at 17:40:37 +0100, Daniel Lezcano wrote :
> > /*
> >@@ -234,13 +201,21 @@ err:
> > */
> > static void __init atmel_st_timer_init(struct device_node *node)
> > {
> >- /* For device tree enabled device: initialize here */
> >- of_at91rm9200_st_init();
> >+ unsigned int val;
> >+
> >+ regmap_st = syscon_node_to_regmap(node);
> >+ if (IS_ERR(regmap_st))
> >+ panic(pr_fmt("Unable to get regmap\n"));
>
> Is it possible to get ride of those panics ? IIRC, we discussed to not panic
> when a timer was not initialized in case there is a definition for another
> one.
>
Ok, I'll remove those.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 7/8] clocksource: atmel-st: use syscon/regmap
Date: Thu, 15 Jan 2015 18:02:37 +0100 [thread overview]
Message-ID: <20150115170237.GV3843@piout.net> (raw)
In-Reply-To: <54B7ED85.2090700@linaro.org>
On 15/01/2015 at 17:40:37 +0100, Daniel Lezcano wrote :
> > /*
> >@@ -234,13 +201,21 @@ err:
> > */
> > static void __init atmel_st_timer_init(struct device_node *node)
> > {
> >- /* For device tree enabled device: initialize here */
> >- of_at91rm9200_st_init();
> >+ unsigned int val;
> >+
> >+ regmap_st = syscon_node_to_regmap(node);
> >+ if (IS_ERR(regmap_st))
> >+ panic(pr_fmt("Unable to get regmap\n"));
>
> Is it possible to get ride of those panics ? IIRC, we discussed to not panic
> when a timer was not initialized in case there is a definition for another
> one.
>
Ok, I'll remove those.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-01-15 17:02 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-12 15:36 [PATCH v3 0/8] Atmel System Timer cleanups Alexandre Belloni
2015-01-12 15:36 ` Alexandre Belloni
2015-01-12 15:36 ` [PATCH v3 1/8] ARM: at91/dt: declare atmel,at91rm9200-st as a syscon Alexandre Belloni
2015-01-12 15:36 ` Alexandre Belloni
2015-01-12 15:36 ` [PATCH v3 2/8] mfd: Add atmel-st driver Alexandre Belloni
2015-01-12 15:36 ` Alexandre Belloni
2015-01-19 9:42 ` Lee Jones
2015-01-19 9:42 ` Lee Jones
2015-01-19 9:42 ` Lee Jones
2015-01-19 22:59 ` Alexandre Belloni
2015-01-19 22:59 ` Alexandre Belloni
2015-01-19 22:59 ` Alexandre Belloni
2015-01-20 9:47 ` Lee Jones
2015-01-20 9:47 ` Lee Jones
2015-01-20 9:47 ` Lee Jones
2015-01-20 15:05 ` Alexandre Belloni
2015-01-20 15:05 ` Alexandre Belloni
2015-01-20 15:36 ` Lee Jones
2015-01-20 15:36 ` Lee Jones
2015-01-20 15:36 ` Lee Jones
2015-01-20 15:49 ` Nicolas Ferre
2015-01-20 15:49 ` Nicolas Ferre
2015-01-20 15:49 ` Nicolas Ferre
2015-01-20 16:45 ` Lee Jones
2015-01-20 16:45 ` Lee Jones
2015-01-20 16:45 ` Lee Jones
2015-01-12 15:36 ` [PATCH v3 3/8] watchdog: at91rm9200: use the regmap from mfd Alexandre Belloni
2015-01-12 15:36 ` Alexandre Belloni
2015-01-12 17:28 ` Guenter Roeck
2015-01-12 17:28 ` Guenter Roeck
2015-01-12 15:36 ` [PATCH v3 4/8] ARM: at91: time: move the system timer driver to drivers/clocksource Alexandre Belloni
2015-01-12 15:36 ` Alexandre Belloni
2015-01-15 16:17 ` Daniel Lezcano
2015-01-15 16:17 ` Daniel Lezcano
2015-01-15 16:17 ` Daniel Lezcano
2015-01-12 15:37 ` [PATCH v3 5/8] ARM: at91: move the restart function to the system timer driver Alexandre Belloni
2015-01-12 15:37 ` Alexandre Belloni
2015-01-15 16:39 ` Daniel Lezcano
2015-01-15 16:39 ` Daniel Lezcano
2015-01-15 16:39 ` Daniel Lezcano
2015-01-15 17:01 ` Alexandre Belloni
2015-01-15 17:01 ` Alexandre Belloni
2015-01-15 17:13 ` Alexandre Belloni
2015-01-15 17:13 ` Alexandre Belloni
2015-01-12 15:37 ` [PATCH v3 6/8] clocksource: atmel-st: properly initialize driver Alexandre Belloni
2015-01-12 15:37 ` Alexandre Belloni
2015-01-15 16:05 ` Daniel Lezcano
2015-01-15 16:05 ` Daniel Lezcano
2015-01-15 16:05 ` Daniel Lezcano
2015-01-12 15:37 ` [PATCH v3 7/8] clocksource: atmel-st: use syscon/regmap Alexandre Belloni
2015-01-12 15:37 ` Alexandre Belloni
2015-01-15 16:40 ` Daniel Lezcano
2015-01-15 16:40 ` Daniel Lezcano
2015-01-15 16:40 ` Daniel Lezcano
2015-01-15 17:02 ` Alexandre Belloni [this message]
2015-01-15 17:02 ` Alexandre Belloni
2015-01-12 15:37 ` [PATCH v3 8/8] ARM: at91: remove useless include Alexandre Belloni
2015-01-12 15:37 ` Alexandre Belloni
2015-01-15 16:29 ` Daniel Lezcano
2015-01-15 16:29 ` Daniel Lezcano
2015-01-15 16:29 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150115170237.GV3843@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=daniel.lezcano@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=sameo@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.