* [PATCH] x86/minios: Remove more vestigial remnants of SUPERVISOR_MODE_KERNEL
@ 2015-01-15 19:07 Andrew Cooper
2015-01-15 19:31 ` Samuel Thibault
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Cooper @ 2015-01-15 19:07 UTC (permalink / raw)
To: Xen-devel
Cc: Keir Fraser, Stefano Stabellini, Andrew Cooper, Tim Deegan,
Jan Beulich, Samuel Thibault
MiniOS has never advertised support for supervisor_mode_kernel, and the
feature was only ever implemented for 32bit Xen.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Keir Fraser <keir@xen.org>
CC: Jan Beulich <JBeulich@suse.com>
CC: Tim Deegan <tim@xen.org>
CC: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
CC: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
extras/mini-os/arch/x86/x86_64.S | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/extras/mini-os/arch/x86/x86_64.S b/extras/mini-os/arch/x86/x86_64.S
index df3469e..72921b1 100644
--- a/extras/mini-os/arch/x86/x86_64.S
+++ b/extras/mini-os/arch/x86/x86_64.S
@@ -125,13 +125,10 @@ KERNEL_CS_MASK = 0xfc
testl $NMI_MASK,2*8(%rsp)
jnz 2f
- testb $1,(xen_features+XENFEAT_supervisor_mode_kernel)
- jnz 1f
-
/* Direct iret to kernel space. Correct CS and SS. */
orb $3,1*8(%rsp)
orb $3,4*8(%rsp)
-1: iretq
+ iretq
2: /* Slow iret via hypervisor. */
andl $~NMI_MASK, 16(%rsp)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] x86/minios: Remove more vestigial remnants of SUPERVISOR_MODE_KERNEL
2015-01-15 19:07 [PATCH] x86/minios: Remove more vestigial remnants of SUPERVISOR_MODE_KERNEL Andrew Cooper
@ 2015-01-15 19:31 ` Samuel Thibault
0 siblings, 0 replies; 2+ messages in thread
From: Samuel Thibault @ 2015-01-15 19:31 UTC (permalink / raw)
To: Andrew Cooper
Cc: Tim Deegan, Stefano Stabellini, Keir Fraser, Jan Beulich,
Xen-devel
Andrew Cooper, le Thu 15 Jan 2015 19:07:47 +0000, a écrit :
> MiniOS has never advertised support for supervisor_mode_kernel, and the
> feature was only ever implemented for 32bit Xen.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Keir Fraser <keir@xen.org>
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Tim Deegan <tim@xen.org>
> CC: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> CC: Samuel Thibault <samuel.thibault@ens-lyon.org>
Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> extras/mini-os/arch/x86/x86_64.S | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/extras/mini-os/arch/x86/x86_64.S b/extras/mini-os/arch/x86/x86_64.S
> index df3469e..72921b1 100644
> --- a/extras/mini-os/arch/x86/x86_64.S
> +++ b/extras/mini-os/arch/x86/x86_64.S
> @@ -125,13 +125,10 @@ KERNEL_CS_MASK = 0xfc
> testl $NMI_MASK,2*8(%rsp)
> jnz 2f
>
> - testb $1,(xen_features+XENFEAT_supervisor_mode_kernel)
> - jnz 1f
> -
> /* Direct iret to kernel space. Correct CS and SS. */
> orb $3,1*8(%rsp)
> orb $3,4*8(%rsp)
> -1: iretq
> + iretq
>
> 2: /* Slow iret via hypervisor. */
> andl $~NMI_MASK, 16(%rsp)
> --
> 1.7.10.4
>
--
Samuel
> dvips -o $@ $<
Faut faire gffe de pas te couper avec ton truc, t'as mis des ciseaux ($<)
partout :))
-+- Dom in Guide du linuxien pervers - "J'aime pas les Makefile !" -+-
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-15 19:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-15 19:07 [PATCH] x86/minios: Remove more vestigial remnants of SUPERVISOR_MODE_KERNEL Andrew Cooper
2015-01-15 19:31 ` Samuel Thibault
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.