From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Michael J Gruber <git@drmicha.warpmail.net>,
git@vger.kernel.org,
Gunnar Wagner <gunnar.wagner@irisgermanica.com>
Subject: Re: [PATCH] commit: reword --author error message
Date: Fri, 16 Jan 2015 04:32:21 -0500 [thread overview]
Message-ID: <20150116093220.GA3006@peff.net> (raw)
In-Reply-To: <xmqq4mrs7x5h.fsf@gitster.dls.corp.google.com>
On Thu, Jan 15, 2015 at 09:48:26AM -0800, Junio C Hamano wrote:
> > Rename the error message to make it clearer that the failure has two
> > reasons in this case:
> > "Bad --author parameter '%s': neither completely wellformed nor part of
> > an existing one"
>
> You are trying to help a user who thought "Who www.where.com" was a
> valid thing to pass to --author; "it is not completely wellformed"
> is not very helpful without making her realize what in that bogus
> string is not "completely well-formed".
>
> Perhaps
>
> "--author '%s' is not 'Name <email>' and no existing author matches that string"
>
> or somesuch?
Yeah, I think that is OK. It is kind of clunky to read, but it contains
all of the necessary information to lead the user in the right
direction.
-Peff
next prev parent reply other threads:[~2015-01-16 9:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 8:15 commit --amend --author error Gunnar Wagner
2015-01-13 11:24 ` Michael J Gruber
2015-01-14 12:09 ` Jeff King
2015-01-15 14:21 ` Michael J Gruber
2015-01-15 14:23 ` [PATCH] commit: reword --author error message Michael J Gruber
2015-01-15 14:25 ` Michael J Gruber
2015-01-15 14:31 ` Jeff King
2015-01-15 14:40 ` Michael J Gruber
2015-01-15 17:48 ` Junio C Hamano
2015-01-16 9:32 ` Jeff King [this message]
2015-01-16 17:29 ` Junio C Hamano
2015-01-16 18:33 ` Philip Oakley
2015-01-16 18:35 ` Junio C Hamano
2015-01-16 19:37 ` Eric Sunshine
2015-01-16 19:53 ` Junio C Hamano
2015-01-26 15:48 ` [PATCHv2] " Michael J Gruber
2015-01-26 19:07 ` Jeff King
2015-01-27 2:43 ` Junio C Hamano
2015-01-27 2:45 ` Jeff King
2015-01-27 8:37 ` Philip Oakley
2015-01-27 12:22 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150116093220.GA3006@peff.net \
--to=peff@peff.net \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=gunnar.wagner@irisgermanica.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.