All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael J Gruber <git@drmicha.warpmail.net>
To: Jeff King <peff@peff.net>
Cc: Gunnar Wagner <gunnar.wagner@irisgermanica.com>, git@vger.kernel.org
Subject: Re: commit --amend --author   error
Date: Thu, 15 Jan 2015 15:21:01 +0100	[thread overview]
Message-ID: <54B7CCCD.1070708@drmicha.warpmail.net> (raw)
In-Reply-To: <20150114120943.GA30383@peff.net>

Jeff King schrieb am 14.01.2015 um 13:09:
> On Tue, Jan 13, 2015 at 12:24:18PM +0100, Michael J Gruber wrote:
> 
>> Gunnar Wagner schrieb am 13.01.2015 um 09:15:
>>> I got APGL licensed code from someone else and want to post it on my 
>>> github (without taking credit for the work)
>>>
>>> tried   git commit --amend --author="Author name, www.website.com" but 
>>> got an error message which said something like "original author not found"
>>> Can it be that the --amen --author only work if the author is on github 
>>> himself?
>>>
>>
>> This has nothing to do with github.
>>
>> The author has be in the form "authorname <authoremail>". The important
>> parts for the format are the <>.
> 
> Yes, but the error message is a hint that there is something else going
> on. When there are no angle brackets, some DWIM magic kicks in: git
> tries to find a matching author by walking the project history from
> HEAD. So you can do (in git.git):
> 
>   $ git commit --allow-empty -m foo --author=gruber
>   [detached HEAD 73ef08b] foo
>    Author: Michael J Gruber <git@drmicha.warpmail.net>

(git commit --allow-almost-empty in the case of that author, hum)

> Of course that does not work if you do not already have commits from the
> person in your repository:
> 
>   $ git commit --allow-empty -m foo --author=foobar
>   fatal: No existing author found with 'foobar'
> 
> -Peff

That is the full explanation, yes:

Neither can "Author name, www.website.com" be parsed as a complete valid
"name <email>"
nor can it be matched as part of an existing "name <email>" in the repo.

The OP clearly tried to do the first and got an error message about the
second. Maybe we can do better here?

Michael

  reply	other threads:[~2015-01-15 14:21 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-13  8:15 commit --amend --author error Gunnar Wagner
2015-01-13 11:24 ` Michael J Gruber
2015-01-14 12:09   ` Jeff King
2015-01-15 14:21     ` Michael J Gruber [this message]
2015-01-15 14:23       ` [PATCH] commit: reword --author error message Michael J Gruber
2015-01-15 14:25         ` Michael J Gruber
2015-01-15 14:31         ` Jeff King
2015-01-15 14:40           ` Michael J Gruber
2015-01-15 17:48         ` Junio C Hamano
2015-01-16  9:32           ` Jeff King
2015-01-16 17:29             ` Junio C Hamano
2015-01-16 18:33               ` Philip Oakley
2015-01-16 18:35                 ` Junio C Hamano
2015-01-16 19:37                   ` Eric Sunshine
2015-01-16 19:53                     ` Junio C Hamano
2015-01-26 15:48                       ` [PATCHv2] " Michael J Gruber
2015-01-26 19:07                         ` Jeff King
2015-01-27  2:43                           ` Junio C Hamano
2015-01-27  2:45                             ` Jeff King
2015-01-27  8:37                               ` Philip Oakley
2015-01-27 12:22                           ` Ramsay Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B7CCCD.1070708@drmicha.warpmail.net \
    --to=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=gunnar.wagner@irisgermanica.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.