Re: [PATCH v18 01/12] input: cyapa: re-design driver to support multi-trackpad in one driver

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

Hi Dudley,

On Fri, Jan 16, 2015 at 02:34:04PM +0800, Dudley Du wrote:
> In order to support multiple different chipsets and communication protocols
> trackpad devices in one cyapa driver, the new cyapa driver is re-designed
> with one cyapa driver core and multiple device specific functions component.
> The cyapa driver core is contained in this patch, it supplies basic functions
> that working with kernel and input subsystem, and also supplies the interfaces
> that the specific devices' component can connect and work together with as
> one driver.
> TEST=test on Chromebooks.
> 
> Signed-off-by: Dudley Du <dudl@cypress.com>
> ---
>  drivers/input/mouse/Kconfig      |   10 -
>  drivers/input/mouse/Makefile     |    3 +-
>  drivers/input/mouse/cyapa.c      | 1076 +++++++++++++++-----------------------
>  drivers/input/mouse/cyapa.h      |  296 +++++++++++
>  drivers/input/mouse/cyapa_gen3.c |  807 ++++++++++++++++++++++++++++
>  5 files changed, 1516 insertions(+), 676 deletions(-)
>  create mode 100644 drivers/input/mouse/cyapa.h
>  create mode 100644 drivers/input/mouse/cyapa_gen3.c
> 
> diff --git a/drivers/input/mouse/Kconfig b/drivers/input/mouse/Kconfig
> index 2541bfa..d8b46b0 100644
> --- a/drivers/input/mouse/Kconfig
> +++ b/drivers/input/mouse/Kconfig
> @@ -146,16 +146,6 @@ config MOUSE_PS2_OLPC
>  
>  	  If unsure, say N.
>  
> -config MOUSE_PS2_FOCALTECH
> -	bool "FocalTech PS/2 mouse protocol extension" if EXPERT
> -	default y
> -	depends on MOUSE_PS2
> -	help
> -	  Say Y here if you have a FocalTech PS/2 TouchPad connected to
> -	  your system.
> -
> -	  If unsure, say Y.
> -

Hmm, I wonder why you do not like Focaltech ;) I fixed it up locally, no
need to resubmit.

Thanks.

-- 
Dmitry