From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Dudley Du <dudl@cypress.com>
Cc: jmmahler@gmail.com, rydberg@euromail.se, bleung@google.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v18 09/12] input: cyapa: add gen5 trackpad device firmware update function support
Date: Sun, 18 Jan 2015 16:26:34 -0800 [thread overview]
Message-ID: <20150119002634.GA23278@dtor-glaptop> (raw)
In-Reply-To: <1421390055-32760-10-git-send-email-dudl@cypress.com>
On Fri, Jan 16, 2015 at 02:34:12PM +0800, Dudley Du wrote:
> + /* APP_INTEGRITY row is always the last row block,
> + * and the row id must be 0x01ff */
> + row_num = get_unaligned_be16(
> + &image->records[flash_records_count - 1].row_number);
> + if (image->records[flash_records_count - 1].flash_array_id != 0x00 &&
> + row_num != 0x01ff) {
By the way, shouldn't this be "or" and not "and"?
> + dev_err(dev, "%s: invalid app_integrity data.\n", __func__);
> + return -EINVAL;
> + }
Thanks.
--
Dmitry
next prev parent reply other threads:[~2015-01-19 0:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 6:34 [PATCH v18 00/12] input: cyapa: instruction of cyapa patches Dudley Du
2015-01-16 6:34 ` [PATCH v18 01/12] input: cyapa: re-design driver to support multi-trackpad in one driver Dudley Du
2015-01-18 8:27 ` Dmitry Torokhov
2015-01-19 1:45 ` Dudley Du
2015-01-16 6:34 ` [PATCH v18 02/12] input: cyapa: add gen5 trackpad device basic functions support Dudley Du
2015-01-16 6:34 ` [PATCH v18 03/12] input: cyapa: add power management interfaces support for the device Dudley Du
2015-01-16 6:34 ` [PATCH v18 04/12] input: cyapa: add runtime " Dudley Du
2015-01-18 8:31 ` Dmitry Torokhov
2015-01-19 1:52 ` Dudley Du
2015-01-16 6:34 ` [PATCH v18 05/12] input: cyapa: add sysfs interfaces support in the cyapa driver Dudley Du
2015-01-16 6:34 ` [PATCH v18 06/12] input: cyapa: add gen3 trackpad device firmware update function support Dudley Du
2015-01-16 6:34 ` [PATCH v18 07/12] input: cyapa: add gen3 trackpad device read baseline " Dudley Du
2015-01-16 6:34 ` [PATCH v18 08/12] input: cyapa: add gen3 trackpad device force re-calibrate " Dudley Du
2015-01-16 6:34 ` [PATCH v18 09/12] input: cyapa: add gen5 trackpad device firmware update " Dudley Du
2015-01-19 0:26 ` Dmitry Torokhov [this message]
2015-01-19 1:35 ` Dudley Du
2015-01-16 6:34 ` [PATCH v18 10/12] input: cyapa: add gen5 trackpad device read baseline " Dudley Du
2015-01-16 6:34 ` [PATCH v18 11/12] input: cyapa: add gen5 trackpad device force re-calibrate " Dudley Du
2015-01-16 6:34 ` [PATCH v18 12/12] input: cyapa: add acpi device id support Dudley Du
2015-01-18 8:28 ` Dmitry Torokhov
2015-01-19 1:52 ` Dudley Du
2015-01-17 10:44 ` [PATCH v18 00/12] input: cyapa: instruction of cyapa patches Jeremiah Mahler
2015-01-17 11:39 ` Jeremiah Mahler
2015-01-18 8:35 ` Dmitry Torokhov
2015-01-19 1:54 ` Dudley Du
2015-01-17 18:00 ` David Solda
2015-01-17 22:46 ` Jeremiah Mahler
2015-01-19 1:50 ` Dudley Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150119002634.GA23278@dtor-glaptop \
--to=dmitry.torokhov@gmail.com \
--cc=bleung@google.com \
--cc=dudl@cypress.com \
--cc=jmmahler@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.