From: Wolfram Sang <wsa@the-dreams.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, linux-mips@linux-mips.org,
Jean Delvare <jdelvare@suse.de>,
Julia Lawall <julia.lawall@lip6.fr>,
Pantelis Antoniou <pantelis.antoniou@konsulko.com>
Subject: Re: [PATCH] i2c: drop ancient protection against sysfs refcounting issues
Date: Mon, 19 Jan 2015 22:30:50 +0100 [thread overview]
Message-ID: <20150119213050.GA32176@katana> (raw)
In-Reply-To: <20150119190142.GA9451@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 702 bytes --]
> > @@ -1184,8 +1183,7 @@ EXPORT_SYMBOL_GPL(i2c_new_dummy);
> >
> > static void i2c_adapter_dev_release(struct device *dev)
> > {
> > - struct i2c_adapter *adap = to_i2c_adapter(dev);
> > - complete(&adap->dev_released);
> > + /* empty, but the driver core insists we need a release function */
>
> Yeah, it does, but I hate to see this in "real" code as something is
> probably wrong with it if it happens.
>
> Please move the rest of 'i2c_del_adapter' into the release function
> (what was after the wait_for_completion() call), and then all should be
> fine.
I was about to do this as a follow-up patch. But Russell's and
Lars-Peter's responses made this obsolete already.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-mips@linux-mips.org,
Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
linux-kernel@vger.kernel.org, Julia Lawall <julia.lawall@lip6.fr>,
linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, Jean Delvare <jdelvare@suse.de>
Subject: Re: [PATCH] i2c: drop ancient protection against sysfs refcounting issues
Date: Mon, 19 Jan 2015 22:30:50 +0100 [thread overview]
Message-ID: <20150119213050.GA32176@katana> (raw)
In-Reply-To: <20150119190142.GA9451@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 702 bytes --]
> > @@ -1184,8 +1183,7 @@ EXPORT_SYMBOL_GPL(i2c_new_dummy);
> >
> > static void i2c_adapter_dev_release(struct device *dev)
> > {
> > - struct i2c_adapter *adap = to_i2c_adapter(dev);
> > - complete(&adap->dev_released);
> > + /* empty, but the driver core insists we need a release function */
>
> Yeah, it does, but I hate to see this in "real" code as something is
> probably wrong with it if it happens.
>
> Please move the rest of 'i2c_del_adapter' into the release function
> (what was after the wait_for_completion() call), and then all should be
> fine.
I was about to do this as a follow-up patch. But Russell's and
Lars-Peter's responses made this obsolete already.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i2c: drop ancient protection against sysfs refcounting issues
Date: Mon, 19 Jan 2015 22:30:50 +0100 [thread overview]
Message-ID: <20150119213050.GA32176@katana> (raw)
In-Reply-To: <20150119190142.GA9451@kroah.com>
> > @@ -1184,8 +1183,7 @@ EXPORT_SYMBOL_GPL(i2c_new_dummy);
> >
> > static void i2c_adapter_dev_release(struct device *dev)
> > {
> > - struct i2c_adapter *adap = to_i2c_adapter(dev);
> > - complete(&adap->dev_released);
> > + /* empty, but the driver core insists we need a release function */
>
> Yeah, it does, but I hate to see this in "real" code as something is
> probably wrong with it if it happens.
>
> Please move the rest of 'i2c_del_adapter' into the release function
> (what was after the wait_for_completion() call), and then all should be
> fine.
I was about to do this as a follow-up patch. But Russell's and
Lars-Peter's responses made this obsolete already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150119/d45fc4fc/attachment-0001.sig>
next prev parent reply other threads:[~2015-01-19 21:31 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 18:55 [PATCH] i2c: drop ancient protection against sysfs refcounting issues Wolfram Sang
2015-01-19 18:55 ` Wolfram Sang
2015-01-19 18:55 ` Wolfram Sang
2015-01-19 18:59 ` Pantelis Antoniou
2015-01-19 18:59 ` Pantelis Antoniou
2015-01-19 18:59 ` Pantelis Antoniou
2015-01-19 18:59 ` Pantelis Antoniou
2015-01-19 19:01 ` Greg Kroah-Hartman
2015-01-19 19:01 ` Greg Kroah-Hartman
2015-01-19 19:01 ` Greg Kroah-Hartman
2015-01-19 21:30 ` Wolfram Sang [this message]
2015-01-19 21:30 ` Wolfram Sang
2015-01-19 21:30 ` Wolfram Sang
2015-01-19 23:04 ` Russell King - ARM Linux
2015-01-19 23:04 ` Russell King - ARM Linux
2015-01-19 23:04 ` Russell King - ARM Linux
2015-01-20 1:41 ` Greg Kroah-Hartman
2015-01-20 1:41 ` Greg Kroah-Hartman
2015-01-20 1:41 ` Greg Kroah-Hartman
2015-01-20 7:05 ` Lars-Peter Clausen
2015-01-20 7:05 ` Lars-Peter Clausen
2015-01-20 7:05 ` Lars-Peter Clausen
2015-01-20 7:12 ` Greg Kroah-Hartman
2015-01-20 7:12 ` Greg Kroah-Hartman
2015-01-20 7:12 ` Greg Kroah-Hartman
2015-01-20 7:27 ` Lars-Peter Clausen
2015-01-20 7:27 ` Lars-Peter Clausen
2015-01-20 7:27 ` Lars-Peter Clausen
2015-01-20 10:17 ` Russell King - ARM Linux
2015-01-20 10:17 ` Russell King - ARM Linux
2015-01-20 10:17 ` Russell King - ARM Linux
2015-01-20 11:35 ` Wolfram Sang
2015-01-20 11:35 ` Wolfram Sang
2015-01-20 11:35 ` Wolfram Sang
2015-01-19 19:12 ` Russell King - ARM Linux
2015-01-19 19:12 ` Russell King - ARM Linux
2015-01-19 19:12 ` Russell King - ARM Linux
2015-01-19 19:39 ` Wolfram Sang
2015-01-19 19:39 ` Wolfram Sang
2015-01-19 19:39 ` Wolfram Sang
2015-01-19 20:01 ` Lars-Peter Clausen
2015-01-19 20:01 ` Lars-Peter Clausen
2015-01-19 20:01 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150119213050.GA32176@katana \
--to=wsa@the-dreams.de \
--cc=gregkh@linuxfoundation.org \
--cc=jdelvare@suse.de \
--cc=julia.lawall@lip6.fr \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=pantelis.antoniou@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.