Re: [PATCH 07/14] mfd: mc13xxx: i2c/spi: Constify struct regmap_config

[Lee Jones <lee.jones@linaro.org>]

On Mon, 05 Jan 2015, Krzysztof Kozlowski wrote:

> The regmap_config struct may be const because it is not modified by the
> driver and regmap_init() accepts pointer to const.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>  drivers/mfd/mc13xxx-i2c.c | 2 +-
>  drivers/mfd/mc13xxx-spi.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/mc13xxx-i2c.c b/drivers/mfd/mc13xxx-i2c.c
> index ae3addb153a2..68b844811566 100644
> --- a/drivers/mfd/mc13xxx-i2c.c
> +++ b/drivers/mfd/mc13xxx-i2c.c
> @@ -46,7 +46,7 @@ static const struct of_device_id mc13xxx_dt_ids[] = {
>  };
>  MODULE_DEVICE_TABLE(of, mc13xxx_dt_ids);
>  
> -static struct regmap_config mc13xxx_regmap_i2c_config = {
> +static const struct regmap_config mc13xxx_regmap_i2c_config = {
>  	.reg_bits = 8,
>  	.val_bits = 24,
>  
> diff --git a/drivers/mfd/mc13xxx-spi.c b/drivers/mfd/mc13xxx-spi.c
> index 702925e242c9..58a170e45d88 100644
> --- a/drivers/mfd/mc13xxx-spi.c
> +++ b/drivers/mfd/mc13xxx-spi.c
> @@ -48,7 +48,7 @@ static const struct of_device_id mc13xxx_dt_ids[] = {
>  };
>  MODULE_DEVICE_TABLE(of, mc13xxx_dt_ids);
>  
> -static struct regmap_config mc13xxx_regmap_spi_config = {
> +static const struct regmap_config mc13xxx_regmap_spi_config = {
>  	.reg_bits = 7,
>  	.pad_bits = 1,
>  	.val_bits = 24,

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog