All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
	linux-kernel@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
	linux-omap@vger.kernel.org
Subject: Re: [PATCH 12/14] mfd: tps65218: Constify struct regmap_config
Date: Tue, 20 Jan 2015 11:59:37 +0000	[thread overview]
Message-ID: <20150120115937.GX13701@x1> (raw)
In-Reply-To: <1420448493-9355-12-git-send-email-k.kozlowski@samsung.com>

On Mon, 05 Jan 2015, Krzysztof Kozlowski wrote:

> The regmap_config struct may be const because it is not modified by the
> driver and regmap_init() accepts pointer to const.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: linux-omap@vger.kernel.org
> ---
>  drivers/mfd/tps65218.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied with Tony's Ack, thanks.

> diff --git a/drivers/mfd/tps65218.c b/drivers/mfd/tps65218.c
> index 0d256cb002eb..b019b3198afe 100644
> --- a/drivers/mfd/tps65218.c
> +++ b/drivers/mfd/tps65218.c
> @@ -125,7 +125,7 @@ int tps65218_clear_bits(struct tps65218 *tps, unsigned int reg,
>  }
>  EXPORT_SYMBOL_GPL(tps65218_clear_bits);
>  
> -static struct regmap_config tps65218_regmap_config = {
> +static const struct regmap_config tps65218_regmap_config = {
>  	.reg_bits = 8,
>  	.val_bits = 8,
>  	.cache_type = REGCACHE_RBTREE,

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2015-01-20 11:59 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-05  9:01 [PATCH 01/14] mfd: 88pm860x-core: Constify struct regmap_config Krzysztof Kozlowski
2015-01-05  9:01 ` [PATCH 02/14] mfd: hi6421-pmic: " Krzysztof Kozlowski
2015-01-20 11:56   ` Lee Jones
2015-01-05  9:01 ` [PATCH 03/14] mfd: intel_soc_pmic: " Krzysztof Kozlowski
2015-01-20 11:56   ` Lee Jones
2015-01-05  9:01 ` [PATCH 04/14] mfd: davinci_voicecodec: " Krzysztof Kozlowski
2015-01-20 11:56   ` Lee Jones
2015-01-05  9:01 ` [PATCH 05/14] mfd: lm3533: " Krzysztof Kozlowski
2015-01-20 11:57   ` Lee Jones
2015-01-05  9:01 ` [PATCH 06/14] mfd: max77686: " Krzysztof Kozlowski
2015-01-20 11:57   ` Lee Jones
2015-01-05  9:01 ` [PATCH 07/14] mfd: mc13xxx: i2c/spi: " Krzysztof Kozlowski
2015-01-20 11:58   ` Lee Jones
2015-01-05  9:01 ` [PATCH 08/14] mfd: pcf50633: " Krzysztof Kozlowski
2015-01-20 11:58   ` Lee Jones
2015-01-05  9:01 ` [PATCH 09/14] mfd: retu: " Krzysztof Kozlowski
2015-01-20 11:58   ` Lee Jones
2015-01-05  9:01 ` [PATCH 10/14] mfd: smsc-ece1099: " Krzysztof Kozlowski
2015-01-20 11:58   ` Lee Jones
2015-01-05  9:01 ` [PATCH 11/14] mfd: tps65217: " Krzysztof Kozlowski
2015-01-06 17:11   ` Tony Lindgren
2015-01-20 11:59   ` Lee Jones
2015-01-05  9:01 ` [PATCH 12/14] mfd: tps65218: " Krzysztof Kozlowski
2015-01-20 11:59   ` Lee Jones [this message]
2015-01-05  9:01 ` [PATCH 13/14] mfd: twl-core: Constify struct regmap_config and reg_default array Krzysztof Kozlowski
2015-01-06 17:12   ` Tony Lindgren
2015-01-20 11:59   ` Lee Jones
2015-01-05  9:01 ` [PATCH 14/14] mfd: twl6040: " Krzysztof Kozlowski
2015-01-06 17:12   ` Tony Lindgren
2015-01-20 12:00   ` Lee Jones
2015-01-20 11:54 ` [PATCH 01/14] mfd: 88pm860x-core: Constify struct regmap_config Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150120115937.GX13701@x1 \
    --to=lee.jones@linaro.org \
    --cc=k.kozlowski@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.