From: Lee Jones <lee.jones@linaro.org>
To: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Cc: Rob Herring <robh+dt@kernel.org>, Mark Brown <broonie@kernel.org>,
Josh Cartwright <joshc@codeaurora.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v8 3/3] regulator: qcom-rpm: Add missing state flag in call to RPM
Date: Tue, 20 Jan 2015 14:19:54 +0000 [thread overview]
Message-ID: <20150120141954.GS13701@x1> (raw)
In-Reply-To: <1417038661-30209-4-git-send-email-bjorn.andersson@sonymobile.com>
Mark,
Do you want a pull-request for this, or can I absorb it right into my
tree?
> This adds the missing state parameter to the call down to the RPM. This
> is currently hard coded to the active state, as that's all we're
> supporting at this moment.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> ---
> drivers/regulator/qcom_rpm-regulator.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/regulator/qcom_rpm-regulator.c b/drivers/regulator/qcom_rpm-regulator.c
> index b55cd5b..8f66040 100644
> --- a/drivers/regulator/qcom_rpm-regulator.c
> +++ b/drivers/regulator/qcom_rpm-regulator.c
> @@ -198,6 +198,7 @@ static int rpm_reg_write(struct qcom_rpm_reg *vreg,
> vreg->val[req->word] |= value << req->shift;
>
> return qcom_rpm_write(vreg->rpm,
> + QCOM_RPM_ACTIVE_STATE,
> vreg->resource,
> vreg->val,
> vreg->parts->request_len);
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 3/3] regulator: qcom-rpm: Add missing state flag in call to RPM
Date: Tue, 20 Jan 2015 14:19:54 +0000 [thread overview]
Message-ID: <20150120141954.GS13701@x1> (raw)
In-Reply-To: <1417038661-30209-4-git-send-email-bjorn.andersson@sonymobile.com>
Mark,
Do you want a pull-request for this, or can I absorb it right into my
tree?
> This adds the missing state parameter to the call down to the RPM. This
> is currently hard coded to the active state, as that's all we're
> supporting at this moment.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> ---
> drivers/regulator/qcom_rpm-regulator.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/regulator/qcom_rpm-regulator.c b/drivers/regulator/qcom_rpm-regulator.c
> index b55cd5b..8f66040 100644
> --- a/drivers/regulator/qcom_rpm-regulator.c
> +++ b/drivers/regulator/qcom_rpm-regulator.c
> @@ -198,6 +198,7 @@ static int rpm_reg_write(struct qcom_rpm_reg *vreg,
> vreg->val[req->word] |= value << req->shift;
>
> return qcom_rpm_write(vreg->rpm,
> + QCOM_RPM_ACTIVE_STATE,
> vreg->resource,
> vreg->val,
> vreg->parts->request_len);
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-01-20 14:20 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 21:50 [PATCH v8 0/3] Qualcomm Resource Power Manager Bjorn Andersson
2014-11-26 21:50 ` Bjorn Andersson
2014-11-26 21:50 ` Bjorn Andersson
2014-11-26 21:50 ` [PATCH v8 1/3] mfd: devicetree: bindings: Add Qualcomm RPM DT binding Bjorn Andersson
2014-11-26 21:50 ` Bjorn Andersson
2014-11-26 21:50 ` Bjorn Andersson
2015-01-20 17:01 ` Lee Jones
2015-01-20 17:01 ` Lee Jones
2014-11-26 21:51 ` [PATCH v8 2/3] mfd: qcom-rpm: Driver for the Qualcomm RPM Bjorn Andersson
2014-11-26 21:51 ` Bjorn Andersson
2014-11-26 21:51 ` Bjorn Andersson
2014-12-22 10:50 ` Paul Bolle
2014-12-22 10:50 ` Paul Bolle
2014-12-26 20:11 ` Bjorn Andersson
2014-12-26 20:11 ` Bjorn Andersson
2015-01-20 17:02 ` Lee Jones
2015-01-20 17:02 ` Lee Jones
2014-11-26 21:51 ` [PATCH v8 3/3] regulator: qcom-rpm: Add missing state flag in call to RPM Bjorn Andersson
2014-11-26 21:51 ` Bjorn Andersson
2014-11-26 21:51 ` Bjorn Andersson
2014-11-27 11:07 ` Mark Brown
2014-11-27 11:07 ` Mark Brown
2015-01-20 14:19 ` Lee Jones [this message]
2015-01-20 14:19 ` Lee Jones
2015-01-20 16:14 ` Mark Brown
2015-01-20 16:14 ` Mark Brown
2015-01-20 16:14 ` Mark Brown
2015-01-20 17:02 ` Lee Jones
2015-01-20 17:02 ` Lee Jones
2014-12-02 14:25 ` [PATCH v8 0/3] Qualcomm Resource Power Manager Srinivas Kandagatla
2014-12-02 14:25 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150120141954.GS13701@x1 \
--to=lee.jones@linaro.org \
--cc=bjorn.andersson@sonymobile.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joshc@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.