All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Lee Jones <lee.jones@linaro.org>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Len Brown <lenb@kernel.org>, Sebastian Reichel <sre@kernel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: Re: [RFC PATCHv2 07/19] mfd: ab8500: Use power_supply_*() API for accessing function attrs
Date: Tue, 20 Jan 2015 17:06:03 +0100	[thread overview]
Message-ID: <20150120160602.GB32144@amd> (raw)
In-Reply-To: <20150120155149.GG13701@x1>

On Tue 2015-01-20 15:51:49, Lee Jones wrote:
> On Tue, 20 Jan 2015, Krzysztof Kozlowski wrote:
> 
> > On wto, 2015-01-20 at 13:36 +0000, Lee Jones wrote:
> > > On Mon, 05 Jan 2015, Krzysztof Kozlowski wrote:
> > > 
> > > > Replace direct calls to power supply function attributes with wrappers.
> > > > Wrappers provide safe access in case of unregistering the power
> > > > supply (e.g. by removing the driver). Replace:
> > > >  - get_property -> power_supply_get_property
> > > > 
> > > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > > > Acked-by: Jonghwa Lee <jonghwa3.lee@samusng.com>
> > > > Acked-by: Pavel Machek <pavel@ucw.cz>
> > > > Acked-by: Lee Jones <lee.jones@linaro.org>
> > > 
> > > You've sent this to me already Acked.  I don't see 00/00, so I have no
> > > idea what's going on.  Do you want me to take this patch?  Can it be
> > > taking on its own?
> > 
> > git send-email automatically CC-you because you acked this. The depends
> > on previous patches adding this API so please do not pick it up. 
> 
> You should always send MFD related patches to me (either
> automatically, or manually).
> 
> > Everything (with respective acks) should go through one power supply
> > tree.
> 
> That's not how it works.  We need to decide that amongst ourselves
> and it needs to culminate in pull-requests being sent out to all of
> the effected Maintainers.

So go ahead and decide. If the patches are ok, I see no problem in it
going through power supply tree, and neither should you. I feel you
are making it more complex than it is.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

WARNING: multiple messages have this Message-ID (diff)
From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCHv2 07/19] mfd: ab8500: Use power_supply_*() API for accessing function attrs
Date: Tue, 20 Jan 2015 17:06:03 +0100	[thread overview]
Message-ID: <20150120160602.GB32144@amd> (raw)
In-Reply-To: <20150120155149.GG13701@x1>

On Tue 2015-01-20 15:51:49, Lee Jones wrote:
> On Tue, 20 Jan 2015, Krzysztof Kozlowski wrote:
> 
> > On wto, 2015-01-20 at 13:36 +0000, Lee Jones wrote:
> > > On Mon, 05 Jan 2015, Krzysztof Kozlowski wrote:
> > > 
> > > > Replace direct calls to power supply function attributes with wrappers.
> > > > Wrappers provide safe access in case of unregistering the power
> > > > supply (e.g. by removing the driver). Replace:
> > > >  - get_property -> power_supply_get_property
> > > > 
> > > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > > > Acked-by: Jonghwa Lee <jonghwa3.lee@samusng.com>
> > > > Acked-by: Pavel Machek <pavel@ucw.cz>
> > > > Acked-by: Lee Jones <lee.jones@linaro.org>
> > > 
> > > You've sent this to me already Acked.  I don't see 00/00, so I have no
> > > idea what's going on.  Do you want me to take this patch?  Can it be
> > > taking on its own?
> > 
> > git send-email automatically CC-you because you acked this. The depends
> > on previous patches adding this API so please do not pick it up. 
> 
> You should always send MFD related patches to me (either
> automatically, or manually).
> 
> > Everything (with respective acks) should go through one power supply
> > tree.
> 
> That's not how it works.  We need to decide that amongst ourselves
> and it needs to culminate in pull-requests being sent out to all of
> the effected Maintainers.

So go ahead and decide. If the patches are ok, I see no problem in it
going through power supply tree, and neither should you. I feel you
are making it more complex than it is.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  parent reply	other threads:[~2015-01-20 16:06 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-05 15:47 [RFC PATCHv2 00/19] power_supply: Allow safe usage of power supply Krzysztof Kozlowski
2015-01-05 15:47 ` Krzysztof Kozlowski
2015-01-05 15:47 ` [RFC PATCHv2 01/19] power_supply: Add driver private data Krzysztof Kozlowski
2015-01-05 15:47   ` Krzysztof Kozlowski
2015-01-05 15:47 ` [RFC PATCHv2 02/19] power_supply: Move run-time configuration to separate structure Krzysztof Kozlowski
2015-01-05 15:47   ` Krzysztof Kozlowski
2015-01-05 15:47 ` [RFC PATCHv2 03/19] power_supply: Add API for safe access of power supply function attrs Krzysztof Kozlowski
2015-01-05 15:47   ` Krzysztof Kozlowski
2015-01-05 15:47 ` [RFC PATCHv2 04/19] power_supply: sysfs: Use power_supply_*() API for accessing " Krzysztof Kozlowski
2015-01-05 15:47   ` Krzysztof Kozlowski
2015-01-05 15:47 ` [RFC PATCHv2 05/19] power: 88pm860x_charger: " Krzysztof Kozlowski
2015-01-05 15:47   ` Krzysztof Kozlowski
2015-01-05 15:47 ` [RFC PATCHv2 06/19] power: ab8500: " Krzysztof Kozlowski
2015-01-05 15:47   ` Krzysztof Kozlowski
2015-01-05 15:47 ` [RFC PATCHv2 07/19] mfd: " Krzysztof Kozlowski
2015-01-05 15:47   ` Krzysztof Kozlowski
2015-01-20 13:36   ` Lee Jones
2015-01-20 13:36     ` Lee Jones
2015-01-20 14:16     ` Krzysztof Kozlowski
2015-01-20 14:16       ` Krzysztof Kozlowski
2015-01-20 15:51       ` Lee Jones
2015-01-20 15:51         ` Lee Jones
2015-01-20 16:01         ` Krzysztof Kozlowski
2015-01-20 16:01           ` Krzysztof Kozlowski
2015-01-20 16:26           ` Lee Jones
2015-01-20 16:26             ` Lee Jones
2015-01-20 16:26             ` Lee Jones
2015-01-20 16:06         ` Pavel Machek [this message]
2015-01-20 16:06           ` Pavel Machek
2015-01-05 15:47 ` [RFC PATCHv2 08/19] power: apm_power: " Krzysztof Kozlowski
2015-01-05 15:47   ` Krzysztof Kozlowski
2015-01-05 15:47 ` [RFC PATCHv2 09/19] power: bq2415x_charger: " Krzysztof Kozlowski
2015-01-05 15:47   ` Krzysztof Kozlowski
2015-01-05 15:47 ` [RFC PATCHv2 10/19] power: charger-manager: " Krzysztof Kozlowski
2015-01-05 15:47   ` Krzysztof Kozlowski
2015-01-05 15:47 ` [RFC PATCHv2 11/19] power_supply: Change ownership from driver to core Krzysztof Kozlowski
2015-01-05 15:47   ` Krzysztof Kozlowski
2015-01-05 15:47 ` [RFC PATCHv2 12/19] power_supply: Add power_supply_put for decrementing device reference counter Krzysztof Kozlowski
2015-01-05 15:47   ` Krzysztof Kozlowski
2015-01-05 15:47 ` [RFC PATCHv2 13/19] power: charger-manager: Decrement the power supply's " Krzysztof Kozlowski
2015-01-05 15:47   ` Krzysztof Kozlowski
2015-01-05 15:47 ` [RFC PATCHv2 14/19] x86/olpc/xo1/sci: Use newly added power_supply_put API Krzysztof Kozlowski
2015-01-05 15:47   ` Krzysztof Kozlowski
2015-01-05 15:47 ` [RFC PATCHv2 15/19] x86/olpc/xo15/sci: " Krzysztof Kozlowski
2015-01-05 15:47   ` Krzysztof Kozlowski
2015-01-05 15:47 ` [RFC PATCHv2 16/19] power: 88pm860x_charger: Decrement the power supply's device reference counter Krzysztof Kozlowski
2015-01-05 15:47   ` Krzysztof Kozlowski
2015-01-05 15:48 ` [RFC PATCHv2 17/19] power: bq2415x_charger: " Krzysztof Kozlowski
2015-01-05 15:48   ` Krzysztof Kozlowski
2015-01-05 15:48 ` [RFC PATCHv2 18/19] mfd: ab8500: " Krzysztof Kozlowski
2015-01-05 15:48   ` Krzysztof Kozlowski
2015-01-20 13:36   ` Lee Jones
2015-01-20 13:36     ` Lee Jones
2015-01-05 15:48 ` [RFC PATCHv2 19/19] arm: mach-pxa: " Krzysztof Kozlowski
2015-01-05 15:48   ` Krzysztof Kozlowski
2015-01-21 15:22 ` [RFC PATCHv2 00/19] power_supply: Allow safe usage of power supply Sebastian Reichel
2015-01-21 15:22   ` Sebastian Reichel
2015-01-21 15:42   ` Krzysztof Kozlowski
2015-01-21 15:42     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150120160602.GB32144@amd \
    --to=pavel@ucw.cz \
    --cc=dbaryshkov@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=k.kozlowski@samsung.com \
    --cc=lee.jones@linaro.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.