All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] efi: don't look for chosen@0 node on DT platforms
@ 2015-01-20 16:34 ` Leif Lindholm
  0 siblings, 0 replies; 4+ messages in thread
From: Leif Lindholm @ 2015-01-20 16:34 UTC (permalink / raw)
  To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-efi-u79uwXL29TY76Z2rM5mHXA
  Cc: msalter-H+wXaHxf7aLQT0dZR+AlfA,
	matt.fleming-ral2JQCrhuEAvxtiuMwx3w

Due to some scary special case handling noticed in drivers/of, various
bits of the ARM* EFI support patches did duplicate looking for @0
variants of various nodes. Unless on an ancient PPC system, these are
not in fact required. Most instances have become refactored out along
the way, this removes the last one.

Signed-off-by: Leif Lindholm <leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
 drivers/firmware/efi/efi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
index 9035c1b..9fd923a 100644
--- a/drivers/firmware/efi/efi.c
+++ b/drivers/firmware/efi/efi.c
@@ -403,8 +403,7 @@ static int __init fdt_find_uefi_params(unsigned long node, const char *uname,
 	u64 val;
 	int i, len;
 
-	if (depth != 1 ||
-	    (strcmp(uname, "chosen") != 0 && strcmp(uname, "chosen@0") != 0))
+	if (depth != 1 || strcmp(uname, "chosen") != 0)
 		return 0;
 
 	for (i = 0; i < ARRAY_SIZE(dt_params); i++) {
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] efi: don't look for chosen@0 node on DT platforms
@ 2015-01-20 16:34 ` Leif Lindholm
  0 siblings, 0 replies; 4+ messages in thread
From: Leif Lindholm @ 2015-01-20 16:34 UTC (permalink / raw)
  To: linux-arm-kernel

Due to some scary special case handling noticed in drivers/of, various
bits of the ARM* EFI support patches did duplicate looking for @0
variants of various nodes. Unless on an ancient PPC system, these are
not in fact required. Most instances have become refactored out along
the way, this removes the last one.

Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
---
 drivers/firmware/efi/efi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
index 9035c1b..9fd923a 100644
--- a/drivers/firmware/efi/efi.c
+++ b/drivers/firmware/efi/efi.c
@@ -403,8 +403,7 @@ static int __init fdt_find_uefi_params(unsigned long node, const char *uname,
 	u64 val;
 	int i, len;
 
-	if (depth != 1 ||
-	    (strcmp(uname, "chosen") != 0 && strcmp(uname, "chosen at 0") != 0))
+	if (depth != 1 || strcmp(uname, "chosen") != 0)
 		return 0;
 
 	for (i = 0; i < ARRAY_SIZE(dt_params); i++) {
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] efi: don't look for chosen@0 node on DT platforms
  2015-01-20 16:34 ` Leif Lindholm
@ 2015-01-20 22:42     ` Matt Fleming
  -1 siblings, 0 replies; 4+ messages in thread
From: Matt Fleming @ 2015-01-20 22:42 UTC (permalink / raw)
  To: Leif Lindholm
  Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-efi-u79uwXL29TY76Z2rM5mHXA, msalter-H+wXaHxf7aLQT0dZR+AlfA,
	matt.fleming-ral2JQCrhuEAvxtiuMwx3w

On Tue, 20 Jan, at 04:34:38PM, Leif Lindholm wrote:
> Due to some scary special case handling noticed in drivers/of, various
> bits of the ARM* EFI support patches did duplicate looking for @0
> variants of various nodes. Unless on an ancient PPC system, these are
> not in fact required. Most instances have become refactored out along
> the way, this removes the last one.
> 
> Signed-off-by: Leif Lindholm <leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
>  drivers/firmware/efi/efi.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Thanks Leif. Applied for v3.20.

-- 
Matt Fleming, Intel Open Source Technology Center

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH] efi: don't look for chosen@0 node on DT platforms
@ 2015-01-20 22:42     ` Matt Fleming
  0 siblings, 0 replies; 4+ messages in thread
From: Matt Fleming @ 2015-01-20 22:42 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, 20 Jan, at 04:34:38PM, Leif Lindholm wrote:
> Due to some scary special case handling noticed in drivers/of, various
> bits of the ARM* EFI support patches did duplicate looking for @0
> variants of various nodes. Unless on an ancient PPC system, these are
> not in fact required. Most instances have become refactored out along
> the way, this removes the last one.
> 
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
>  drivers/firmware/efi/efi.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Thanks Leif. Applied for v3.20.

-- 
Matt Fleming, Intel Open Source Technology Center

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-20 22:42 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-20 16:34 [PATCH] efi: don't look for chosen@0 node on DT platforms Leif Lindholm
2015-01-20 16:34 ` Leif Lindholm
     [not found] ` <1421771678-31812-1-git-send-email-leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-01-20 22:42   ` Matt Fleming
2015-01-20 22:42     ` Matt Fleming

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.