From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] clocksource: sun5i: Switch to request_irq
Date: Wed, 21 Jan 2015 10:17:36 +0100 [thread overview]
Message-ID: <20150121091736.GE4367@lukather> (raw)
In-Reply-To: <54BBFE38.5000204@linaro.org>
On Sun, Jan 18, 2015 at 07:40:56PM +0100, Daniel Lezcano wrote:
> On 01/11/2015 12:40 PM, Maxime Ripard wrote:
> >The current code uses setup_irq, while it could perfectly use the much simpler
> >request_irq. Switch to that.
> >
> >Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> >---
> > drivers/clocksource/timer-sun5i.c | 10 ++--------
> > 1 file changed, 2 insertions(+), 8 deletions(-)
> >
> >diff --git a/drivers/clocksource/timer-sun5i.c b/drivers/clocksource/timer-sun5i.c
> >index 02268448dc85..738853873a3b 100644
> >--- a/drivers/clocksource/timer-sun5i.c
> >+++ b/drivers/clocksource/timer-sun5i.c
> >@@ -130,13 +130,6 @@ static irqreturn_t sun5i_timer_interrupt(int irq, void *dev_id)
> > return IRQ_HANDLED;
> > }
> >
> >-static struct irqaction sun5i_timer_irq = {
> >- .name = "sun5i_timer0",
> >- .flags = IRQF_TIMER | IRQF_IRQPOLL,
> >- .handler = sun5i_timer_interrupt,
> >- .dev_id = &sun5i_clockevent,
> >-};
> >-
> > static u64 sun5i_timer_sched_read(void)
> > {
> > return ~readl(timer_base + TIMER_CNTVAL_LO_REG(1));
> >@@ -178,7 +171,8 @@ static void __init sun5i_timer_init(struct device_node *node)
> >
> > ticks_per_jiffy = DIV_ROUND_UP(rate, HZ);
> >
> >- ret = setup_irq(irq, &sun5i_timer_irq);
> >+ ret = request_irq(irq, sun5i_timer_interrupt, IRQF_TIMER | IRQF_IRQPOLL,
> >+ "sun5i_timer", &sun5i_clockevent);
>
> Is the timer name change done in purpose ?
Hmm, no, it's a mistake. I'll resend a v2.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150121/cd1b5881/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/5] clocksource: sun5i: Switch to request_irq
Date: Wed, 21 Jan 2015 10:17:36 +0100 [thread overview]
Message-ID: <20150121091736.GE4367@lukather> (raw)
In-Reply-To: <54BBFE38.5000204@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1630 bytes --]
On Sun, Jan 18, 2015 at 07:40:56PM +0100, Daniel Lezcano wrote:
> On 01/11/2015 12:40 PM, Maxime Ripard wrote:
> >The current code uses setup_irq, while it could perfectly use the much simpler
> >request_irq. Switch to that.
> >
> >Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> >---
> > drivers/clocksource/timer-sun5i.c | 10 ++--------
> > 1 file changed, 2 insertions(+), 8 deletions(-)
> >
> >diff --git a/drivers/clocksource/timer-sun5i.c b/drivers/clocksource/timer-sun5i.c
> >index 02268448dc85..738853873a3b 100644
> >--- a/drivers/clocksource/timer-sun5i.c
> >+++ b/drivers/clocksource/timer-sun5i.c
> >@@ -130,13 +130,6 @@ static irqreturn_t sun5i_timer_interrupt(int irq, void *dev_id)
> > return IRQ_HANDLED;
> > }
> >
> >-static struct irqaction sun5i_timer_irq = {
> >- .name = "sun5i_timer0",
> >- .flags = IRQF_TIMER | IRQF_IRQPOLL,
> >- .handler = sun5i_timer_interrupt,
> >- .dev_id = &sun5i_clockevent,
> >-};
> >-
> > static u64 sun5i_timer_sched_read(void)
> > {
> > return ~readl(timer_base + TIMER_CNTVAL_LO_REG(1));
> >@@ -178,7 +171,8 @@ static void __init sun5i_timer_init(struct device_node *node)
> >
> > ticks_per_jiffy = DIV_ROUND_UP(rate, HZ);
> >
> >- ret = setup_irq(irq, &sun5i_timer_irq);
> >+ ret = request_irq(irq, sun5i_timer_interrupt, IRQF_TIMER | IRQF_IRQPOLL,
> >+ "sun5i_timer", &sun5i_clockevent);
>
> Is the timer name change done in purpose ?
Hmm, no, it's a mistake. I'll resend a v2.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-01-21 9:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-11 11:40 [PATCH 0/5] clocksource: sun5i: Support parent clock rate changes Maxime Ripard
2015-01-11 11:40 ` Maxime Ripard
2015-01-11 11:40 ` [PATCH 1/5] clocksource: sun5i: Switch to request_irq Maxime Ripard
2015-01-11 11:40 ` Maxime Ripard
2015-01-18 18:40 ` Daniel Lezcano
2015-01-18 18:40 ` Daniel Lezcano
2015-01-21 9:17 ` Maxime Ripard [this message]
2015-01-21 9:17 ` Maxime Ripard
2015-01-11 11:40 ` [PATCH 2/5] clocksource: sun5i: Use of_io_request_and_map Maxime Ripard
2015-01-11 11:40 ` Maxime Ripard
2015-01-11 11:40 ` [PATCH 3/5] clocksource: sun5i: Remove sched_clock Maxime Ripard
2015-01-11 11:40 ` Maxime Ripard
2015-01-11 11:40 ` [PATCH 4/5] clocksource: sun5i: Refactor the current code Maxime Ripard
2015-01-11 11:40 ` Maxime Ripard
2015-01-11 11:40 ` [PATCH 5/5] clocksource: sun5i: Add clock notifiers Maxime Ripard
2015-01-11 11:40 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150121091736.GE4367@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.