All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/8] Fix perf probe issues on powerpc
Date: Wed, 21 Jan 2015 09:51:42 -0300	[thread overview]
Message-ID: <20150121125142.GC3420@kernel.org> (raw)
In-Reply-To: <cover.1418146300.git.naveen.n.rao@linux.vnet.ibm.com>

Em Tue, Dec 09, 2014 at 11:03:58PM +0530, Naveen N. Rao escreveu:
> This patchset fixes various issues with perf probe on powerpc
> across ABIv1 and ABIv2:
> - in the presence of DWARF debug-info,
> - in the absence of DWARF, but with the symbol table, and
> - in the absence of debug-info, but with kallsyms.
> 
> Applies cleanly on v3.18 and on -tip with minor changes to patch 6.
> Tested on ppc64 BE and LE.
> 
> - Naveen
> 
> Naveen N. Rao (8):
>   kprobes: Fix kallsyms lookup across powerpc ABIv1 and ABIv2
>   perf probe powerpc: Fix symbol fixup issues due to ELF type
>   perf probe: Improve detection of file/function name in the probe
>     pattern
>   perf probe powerpc: Handle powerpc dot symbols
>   perf probe powerpc: Allow matching against dot symbols
>   perf tools powerpc: Fix PPC64 ELF ABIv2 symbol decoding
>   perf probe powerpc: Use DWARF info only if necessary
>   perf probe powerpc: Fixup function entry if using kallsyms lookup

Naveen,

	I saw several comments by Michael, have you tried to address
those comments and have you resubmitted this patchset?

Best regards,

- Arnaldo

WARNING: multiple messages have this Message-ID (diff)
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	mpe@ellerman.id.au, ananth@in.ibm.com
Subject: Re: [RFC PATCH 0/8] Fix perf probe issues on powerpc
Date: Wed, 21 Jan 2015 09:51:42 -0300	[thread overview]
Message-ID: <20150121125142.GC3420@kernel.org> (raw)
In-Reply-To: <cover.1418146300.git.naveen.n.rao@linux.vnet.ibm.com>

Em Tue, Dec 09, 2014 at 11:03:58PM +0530, Naveen N. Rao escreveu:
> This patchset fixes various issues with perf probe on powerpc
> across ABIv1 and ABIv2:
> - in the presence of DWARF debug-info,
> - in the absence of DWARF, but with the symbol table, and
> - in the absence of debug-info, but with kallsyms.
> 
> Applies cleanly on v3.18 and on -tip with minor changes to patch 6.
> Tested on ppc64 BE and LE.
> 
> - Naveen
> 
> Naveen N. Rao (8):
>   kprobes: Fix kallsyms lookup across powerpc ABIv1 and ABIv2
>   perf probe powerpc: Fix symbol fixup issues due to ELF type
>   perf probe: Improve detection of file/function name in the probe
>     pattern
>   perf probe powerpc: Handle powerpc dot symbols
>   perf probe powerpc: Allow matching against dot symbols
>   perf tools powerpc: Fix PPC64 ELF ABIv2 symbol decoding
>   perf probe powerpc: Use DWARF info only if necessary
>   perf probe powerpc: Fixup function entry if using kallsyms lookup

Naveen,

	I saw several comments by Michael, have you tried to address
those comments and have you resubmitted this patchset?

Best regards,

- Arnaldo

  parent reply	other threads:[~2015-01-21 12:51 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-09 17:33 [RFC PATCH 0/8] Fix perf probe issues on powerpc Naveen N. Rao
2014-12-09 17:33 ` Naveen N. Rao
2014-12-09 17:33 ` [RFC PATCH 1/8] kprobes: Fix kallsyms lookup across powerpc ABIv1 and ABIv2 Naveen N. Rao
2014-12-09 17:33   ` Naveen N. Rao
2014-12-10  9:37   ` Michael Ellerman
2014-12-10  9:37     ` Michael Ellerman
2014-12-10 10:26     ` Naveen N. Rao
2014-12-10 10:26       ` Naveen N. Rao
2014-12-09 17:34 ` [RFC PATCH 2/8] perf probe powerpc: Fix symbol fixup issues due to ELF type Naveen N. Rao
2014-12-09 17:34   ` Naveen N. Rao
2014-12-09 21:07   ` Arnaldo Carvalho de Melo
2014-12-09 21:07     ` Arnaldo Carvalho de Melo
2014-12-10  9:35     ` Naveen N. Rao
2014-12-10  9:35       ` Naveen N. Rao
2014-12-10  9:50   ` Michael Ellerman
2014-12-10  9:50     ` Michael Ellerman
2014-12-10 10:41     ` Naveen N. Rao
2014-12-10 10:41       ` Naveen N. Rao
2014-12-09 17:34 ` [RFC PATCH 3/8] perf probe: Improve detection of file/function name in the probe pattern Naveen N. Rao
2014-12-09 17:34   ` Naveen N. Rao
2014-12-10 10:00   ` Michael Ellerman
2014-12-10 10:00     ` Michael Ellerman
2014-12-10 10:59     ` Naveen N. Rao
2014-12-10 10:59       ` Naveen N. Rao
2014-12-10 11:12       ` Michael Ellerman
2014-12-10 11:12         ` Michael Ellerman
2014-12-09 17:34 ` [RFC PATCH 4/8] perf probe powerpc: Handle powerpc dot symbols Naveen N. Rao
2014-12-09 17:34   ` Naveen N. Rao
2014-12-10 10:01   ` Michael Ellerman
2014-12-10 10:01     ` Michael Ellerman
2014-12-09 17:34 ` [RFC PATCH 5/8] perf probe powerpc: Allow matching against " Naveen N. Rao
2014-12-09 17:34   ` Naveen N. Rao
2014-12-10 10:03   ` Michael Ellerman
2014-12-10 10:03     ` Michael Ellerman
2014-12-09 17:34 ` [RFC PATCH 6/8] perf tools powerpc: Fix PPC64 ELF ABIv2 symbol decoding Naveen N. Rao
2014-12-09 17:34   ` Naveen N. Rao
2014-12-10 10:13   ` Michael Ellerman
2014-12-10 10:13     ` Michael Ellerman
2014-12-10 11:21     ` Naveen N. Rao
2014-12-10 11:21       ` Naveen N. Rao
2014-12-09 17:34 ` [RFC PATCH 7/8] perf probe powerpc: Use DWARF info only if necessary Naveen N. Rao
2014-12-09 17:34   ` Naveen N. Rao
2014-12-10 10:17   ` Michael Ellerman
2014-12-10 10:17     ` Michael Ellerman
2014-12-10 11:48     ` Naveen N. Rao
2014-12-10 11:48       ` Naveen N. Rao
2014-12-09 17:34 ` [RFC PATCH 8/8] perf probe powerpc: Fixup function entry if using kallsyms lookup Naveen N. Rao
2014-12-09 17:34   ` Naveen N. Rao
2014-12-09 21:14   ` Arnaldo Carvalho de Melo
2014-12-09 21:14     ` Arnaldo Carvalho de Melo
2014-12-10  4:11     ` Ananth N Mavinakayanahalli
2014-12-10  4:11       ` Ananth N Mavinakayanahalli
2014-12-10  4:12 ` [RFC PATCH 0/8] Fix perf probe issues on powerpc Ananth N Mavinakayanahalli
2014-12-10  4:12   ` Ananth N Mavinakayanahalli
2015-01-21 12:51 ` Arnaldo Carvalho de Melo [this message]
2015-01-21 12:51   ` Arnaldo Carvalho de Melo
2015-01-21 15:33   ` Naveen N. Rao
2015-01-21 15:33     ` Naveen N. Rao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150121125142.GC3420@kernel.org \
    --to=acme@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=naveen.n.rao@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.