From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Zidan Wang <zidan.wang@freescale.com>
Cc: timur@tabi.org, Xiubo.Lee@gmail.com, lgirdwood@gmail.com,
broonie@kernel.org, perex@perex.cz, tiwai@suse.de,
alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel][PATCH 3/3] ASoC: fsl_sai: Add support for Right-J mode
Date: Wed, 21 Jan 2015 10:53:20 -0800 [thread overview]
Message-ID: <20150121185319.GA4238@Alpha> (raw)
In-Reply-To: <1421756480-7055-4-git-send-email-zidan.wang@freescale.com>
On Tue, Jan 20, 2015 at 08:21:20PM +0800, Zidan Wang wrote:
> Add Right-J mode and set TCR5 FBT bit to let data right justify.
>
> Signed-off-by: Zidan Wang <zidan.wang@freescale.com>
> - if (sai->is_lsb_first)
> + if (sai->is_lsb_first && sai->is_right_j_mode)
> val_cr5 |= FSL_SAI_CR5_FBT(0);
Are you sure that FBT(0) is correct for right justified mode?
Because the original code is using FBT(0) for the lsb_first
situation and it shouldn't be right justified mode as default.
Nicolin
WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Zidan Wang <zidan.wang@freescale.com>
Cc: alsa-devel@alsa-project.org, timur@tabi.org, Xiubo.Lee@gmail.com,
tiwai@suse.de, linux-kernel@vger.kernel.org, lgirdwood@gmail.com,
perex@perex.cz, broonie@kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [alsa-devel][PATCH 3/3] ASoC: fsl_sai: Add support for Right-J mode
Date: Wed, 21 Jan 2015 10:53:20 -0800 [thread overview]
Message-ID: <20150121185319.GA4238@Alpha> (raw)
In-Reply-To: <1421756480-7055-4-git-send-email-zidan.wang@freescale.com>
On Tue, Jan 20, 2015 at 08:21:20PM +0800, Zidan Wang wrote:
> Add Right-J mode and set TCR5 FBT bit to let data right justify.
>
> Signed-off-by: Zidan Wang <zidan.wang@freescale.com>
> - if (sai->is_lsb_first)
> + if (sai->is_lsb_first && sai->is_right_j_mode)
> val_cr5 |= FSL_SAI_CR5_FBT(0);
Are you sure that FBT(0) is correct for right justified mode?
Because the original code is using FBT(0) for the lsb_first
situation and it shouldn't be right justified mode as default.
Nicolin
next prev parent reply other threads:[~2015-01-21 18:53 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 12:21 [PATCH 0/3] Add master mode, tmd and right-j mode support Zidan Wang
2015-01-20 12:21 ` [alsa-devel][PATCH " Zidan Wang
2015-01-20 12:21 ` Zidan Wang
2015-01-20 12:21 ` [alsa-devel][PATCH 1/3] SoC: fsl_sai: add sai master " Zidan Wang
2015-01-20 12:21 ` Zidan Wang
2015-01-20 12:21 ` Zidan Wang
2015-01-21 6:07 ` Nicolin Chen
2015-01-21 6:07 ` Nicolin Chen
2015-01-21 9:25 ` [PATCH " Zidan Wang
2015-01-21 9:25 ` [alsa-devel][PATCH " Zidan Wang
2015-01-21 9:25 ` Zidan Wang
2015-01-21 17:36 ` Nicolin Chen
2015-01-21 17:36 ` Nicolin Chen
2015-01-20 12:21 ` [PATCH 2/3] ASoC: fsl_sai: Add support for tdm slots operation Zidan Wang
2015-01-20 12:21 ` [alsa-devel][PATCH " Zidan Wang
2015-01-20 12:21 ` Zidan Wang
2015-01-21 18:08 ` Nicolin Chen
2015-01-21 18:08 ` Nicolin Chen
2015-01-22 4:55 ` Zidan Wang
2015-01-22 4:55 ` Zidan Wang
2015-01-22 4:55 ` Zidan Wang
2015-01-22 5:44 ` Nicolin Chen
2015-01-22 5:44 ` Nicolin Chen
2015-01-22 6:20 ` Zidan Wang
2015-01-22 6:20 ` Zidan Wang
2015-01-22 6:20 ` Zidan Wang
2015-01-22 23:50 ` Nicolin Chen
2015-01-22 23:50 ` Nicolin Chen
2015-01-23 2:55 ` [PATCH " Zidan Wang
2015-01-23 2:55 ` [alsa-devel][PATCH " Zidan Wang
2015-01-23 2:55 ` Zidan Wang
2015-01-23 8:27 ` Nicolin Chen
2015-01-23 8:27 ` Nicolin Chen
2015-01-20 12:21 ` [PATCH 3/3] ASoC: fsl_sai: Add support for Right-J mode Zidan Wang
2015-01-20 12:21 ` [alsa-devel][PATCH " Zidan Wang
2015-01-20 12:21 ` Zidan Wang
2015-01-21 18:53 ` Nicolin Chen [this message]
2015-01-21 18:53 ` Nicolin Chen
2015-01-22 5:13 ` Zidan Wang
2015-01-22 5:13 ` Zidan Wang
2015-01-22 5:13 ` Zidan Wang
2015-01-22 5:46 ` Nicolin Chen
2015-01-22 5:46 ` Nicolin Chen
2015-01-21 1:15 ` [alsa-devel] [PATCH 0/3] Add master mode, tmd and right-j mode support Fabio Estevam
2015-01-21 1:15 ` Fabio Estevam
2015-01-21 6:29 ` Nicolin Chen
2015-01-21 6:29 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150121185319.GA4238@Alpha \
--to=nicoleotsuka@gmail.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=perex@perex.cz \
--cc=timur@tabi.org \
--cc=tiwai@suse.de \
--cc=zidan.wang@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.