From: Dave Chinner <david@fromorbit.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 0/17 v3] quota: Unify VFS and XFS quota interfaces
Date: Thu, 22 Jan 2015 08:38:26 +1100 [thread overview]
Message-ID: <20150121213826.GL16510@dastard> (raw)
In-Reply-To: <1421412471-4747-1-git-send-email-jack@suse.cz>
On Fri, Jan 16, 2015 at 01:47:34PM +0100, Jan Kara wrote:
> Hello,
>
> this is another iteration of patches to unify VFS and XFS quota interfaces so
> that XFS quotactls work for filesystems with VFS quotas and vice versa. This
> is useful so that userspace doesn't have to care that much about which
> filesystem it is using at least when using basic quota functionality. In
> particular we should be able to reuse project quota tests in xfstests for ext4.
>
> The patches are based on quota cleanup series [1] and XFS cleanup series [2]
> I've sent previously and based on 3.19-rc4 + for-next branch of XFS tree. I
> could further split this series into per-quotactl series but frankly I don't
> think it will help reviewers in any way (the patches in the current series are
> already ordered by quotactl).
Hi Jan,
Do you have a this series in a git tree somewhere so it's easy to
merge and test?
> All the comments to the first version of the series are hopefully addressed,
> except for Dave's request to reduce number of copying of dquot information -
> I have benchmarked that reducing number of copies from 3 to 2 brings just 2%
> improvement in speed in my test setup and getting quota information isn't IMHO
> so performance critical that it would be worth the complications of the code.
I think the numbers address my concern adequately ;)
Cheers,
Dave.
--
Dave Chinner
david at fromorbit.com
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com,
ocfs2-devel@oss.oracle.com, xfs@oss.sgi.com
Subject: Re: [PATCH 0/17 v3] quota: Unify VFS and XFS quota interfaces
Date: Thu, 22 Jan 2015 08:38:26 +1100 [thread overview]
Message-ID: <20150121213826.GL16510@dastard> (raw)
In-Reply-To: <1421412471-4747-1-git-send-email-jack@suse.cz>
On Fri, Jan 16, 2015 at 01:47:34PM +0100, Jan Kara wrote:
> Hello,
>
> this is another iteration of patches to unify VFS and XFS quota interfaces so
> that XFS quotactls work for filesystems with VFS quotas and vice versa. This
> is useful so that userspace doesn't have to care that much about which
> filesystem it is using at least when using basic quota functionality. In
> particular we should be able to reuse project quota tests in xfstests for ext4.
>
> The patches are based on quota cleanup series [1] and XFS cleanup series [2]
> I've sent previously and based on 3.19-rc4 + for-next branch of XFS tree. I
> could further split this series into per-quotactl series but frankly I don't
> think it will help reviewers in any way (the patches in the current series are
> already ordered by quotactl).
Hi Jan,
Do you have a this series in a git tree somewhere so it's easy to
merge and test?
> All the comments to the first version of the series are hopefully addressed,
> except for Dave's request to reduce number of copying of dquot information -
> I have benchmarked that reducing number of copies from 3 to 2 brings just 2%
> improvement in speed in my test setup and getting quota information isn't IMHO
> so performance critical that it would be worth the complications of the code.
I think the numbers address my concern adequately ;)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com,
cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 0/17 v3] quota: Unify VFS and XFS quota interfaces
Date: Thu, 22 Jan 2015 08:38:26 +1100 [thread overview]
Message-ID: <20150121213826.GL16510@dastard> (raw)
In-Reply-To: <1421412471-4747-1-git-send-email-jack@suse.cz>
On Fri, Jan 16, 2015 at 01:47:34PM +0100, Jan Kara wrote:
> Hello,
>
> this is another iteration of patches to unify VFS and XFS quota interfaces so
> that XFS quotactls work for filesystems with VFS quotas and vice versa. This
> is useful so that userspace doesn't have to care that much about which
> filesystem it is using at least when using basic quota functionality. In
> particular we should be able to reuse project quota tests in xfstests for ext4.
>
> The patches are based on quota cleanup series [1] and XFS cleanup series [2]
> I've sent previously and based on 3.19-rc4 + for-next branch of XFS tree. I
> could further split this series into per-quotactl series but frankly I don't
> think it will help reviewers in any way (the patches in the current series are
> already ordered by quotactl).
Hi Jan,
Do you have a this series in a git tree somewhere so it's easy to
merge and test?
> All the comments to the first version of the series are hopefully addressed,
> except for Dave's request to reduce number of copying of dquot information -
> I have benchmarked that reducing number of copies from 3 to 2 brings just 2%
> improvement in speed in my test setup and getting quota information isn't IMHO
> so performance critical that it would be worth the complications of the code.
I think the numbers address my concern adequately ;)
Cheers,
Dave.
--
Dave Chinner
david at fromorbit.com
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com,
cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com
Subject: Re: [PATCH 0/17 v3] quota: Unify VFS and XFS quota interfaces
Date: Thu, 22 Jan 2015 08:38:26 +1100 [thread overview]
Message-ID: <20150121213826.GL16510@dastard> (raw)
In-Reply-To: <1421412471-4747-1-git-send-email-jack@suse.cz>
On Fri, Jan 16, 2015 at 01:47:34PM +0100, Jan Kara wrote:
> Hello,
>
> this is another iteration of patches to unify VFS and XFS quota interfaces so
> that XFS quotactls work for filesystems with VFS quotas and vice versa. This
> is useful so that userspace doesn't have to care that much about which
> filesystem it is using at least when using basic quota functionality. In
> particular we should be able to reuse project quota tests in xfstests for ext4.
>
> The patches are based on quota cleanup series [1] and XFS cleanup series [2]
> I've sent previously and based on 3.19-rc4 + for-next branch of XFS tree. I
> could further split this series into per-quotactl series but frankly I don't
> think it will help reviewers in any way (the patches in the current series are
> already ordered by quotactl).
Hi Jan,
Do you have a this series in a git tree somewhere so it's easy to
merge and test?
> All the comments to the first version of the series are hopefully addressed,
> except for Dave's request to reduce number of copying of dquot information -
> I have benchmarked that reducing number of copies from 3 to 2 brings just 2%
> improvement in speed in my test setup and getting quota information isn't IMHO
> so performance critical that it would be worth the complications of the code.
I think the numbers address my concern adequately ;)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2015-01-21 21:38 UTC|newest]
Thread overview: 150+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 12:47 [Cluster-devel] [PATCH 0/17 v3] quota: Unify VFS and XFS quota interfaces Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-16 12:47 ` [Cluster-devel] [PATCH 01/17] quota: Split ->set_xstate callback into two Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-19 9:00 ` [Cluster-devel] " Christoph Hellwig
2015-01-19 9:00 ` Christoph Hellwig
2015-01-19 9:00 ` [Ocfs2-devel] " Christoph Hellwig
2015-01-19 9:00 ` Christoph Hellwig
2015-01-16 12:47 ` [Cluster-devel] [PATCH 02/17] quota: Wire up ->quota_{enable, disable} callbacks into Q_QUOTA{ON, OFF} Jan Kara
2015-01-16 12:47 ` [PATCH 02/17] quota: Wire up ->quota_{enable,disable} callbacks into Q_QUOTA{ON,OFF} Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] [PATCH 02/17] quota: Wire up ->quota_{enable, disable} callbacks into Q_QUOTA{ON, OFF} Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-19 9:01 ` [Cluster-devel] " Christoph Hellwig
2015-01-19 9:01 ` [PATCH 02/17] quota: Wire up ->quota_{enable,disable} callbacks into Q_QUOTA{ON,OFF} Christoph Hellwig
2015-01-19 9:01 ` [Ocfs2-devel] [PATCH 02/17] quota: Wire up ->quota_{enable, disable} callbacks into Q_QUOTA{ON, OFF} Christoph Hellwig
2015-01-19 9:01 ` [PATCH 02/17] quota: Wire up ->quota_{enable,disable} callbacks into Q_QUOTA{ON,OFF} Christoph Hellwig
2015-01-20 17:01 ` [Cluster-devel] [PATCH 02/17] quota: Wire up ->quota_{enable, disable} callbacks into Q_QUOTA{ON, OFF} Jan Kara
2015-01-20 17:01 ` [Ocfs2-devel] " Jan Kara
2015-01-20 17:01 ` [PATCH 02/17] quota: Wire up ->quota_{enable,disable} callbacks into Q_QUOTA{ON,OFF} Jan Kara
2015-01-16 12:47 ` [Cluster-devel] [PATCH 03/17] quota: Add ->quota_{enable, disable} callbacks for VFS quotas Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-19 9:02 ` [Cluster-devel] " Christoph Hellwig
2015-01-19 9:02 ` [PATCH 03/17] quota: Add ->quota_{enable,disable} " Christoph Hellwig
2015-01-19 9:02 ` [Ocfs2-devel] [PATCH 03/17] quota: Add ->quota_{enable, disable} " Christoph Hellwig
2015-01-19 9:02 ` [PATCH 03/17] quota: Add ->quota_{enable,disable} " Christoph Hellwig
2015-01-20 17:08 ` [Cluster-devel] [PATCH 03/17] quota: Add ->quota_{enable, disable} " Jan Kara
2015-01-20 17:08 ` [PATCH 03/17] quota: Add ->quota_{enable,disable} " Jan Kara
2015-01-20 17:08 ` [Ocfs2-devel] [PATCH 03/17] quota: Add ->quota_{enable, disable} " Jan Kara
2015-01-20 17:08 ` [PATCH 03/17] quota: Add ->quota_{enable,disable} " Jan Kara
2015-01-16 12:47 ` [Cluster-devel] [PATCH 04/17] ext4: Use generic helpers for quotaon and quotaoff Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-19 9:03 ` [Cluster-devel] " Christoph Hellwig
2015-01-19 9:03 ` [Ocfs2-devel] " Christoph Hellwig
2015-01-19 9:03 ` Christoph Hellwig
2015-01-16 12:47 ` [Cluster-devel] [PATCH 05/17] ocfs2: " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-19 9:03 ` [Cluster-devel] " Christoph Hellwig
2015-01-19 9:03 ` Christoph Hellwig
2015-01-19 9:03 ` [Ocfs2-devel] " Christoph Hellwig
2015-01-19 9:03 ` Christoph Hellwig
2015-01-20 17:13 ` [Cluster-devel] " Jan Kara
2015-01-20 17:13 ` [Ocfs2-devel] " Jan Kara
2015-01-20 17:13 ` Jan Kara
2015-01-16 12:47 ` [Cluster-devel] [PATCH 06/17] quota: Remove quota_on_meta callback Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-19 9:04 ` [Cluster-devel] " Christoph Hellwig
2015-01-19 9:04 ` [Ocfs2-devel] " Christoph Hellwig
2015-01-19 9:04 ` Christoph Hellwig
2015-01-16 12:47 ` [Cluster-devel] [PATCH 07/17] quota: Switch ->get_dqblk() and ->set_dqblk() to use bytes as space units Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-19 9:07 ` [Cluster-devel] " Christoph Hellwig
2015-01-19 9:07 ` Christoph Hellwig
2015-01-19 9:07 ` [Ocfs2-devel] " Christoph Hellwig
2015-01-19 9:07 ` Christoph Hellwig
2015-01-20 16:53 ` [Cluster-devel] " Jan Kara
2015-01-20 16:53 ` Jan Kara
2015-01-20 16:53 ` [Ocfs2-devel] " Jan Kara
2015-01-20 16:53 ` Jan Kara
2015-01-16 12:47 ` [Cluster-devel] [PATCH 08/17] quota: Store maximum space limit in bytes Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-19 9:07 ` [Cluster-devel] " Christoph Hellwig
2015-01-19 9:07 ` Christoph Hellwig
2015-01-19 9:07 ` [Ocfs2-devel] " Christoph Hellwig
2015-01-19 9:07 ` Christoph Hellwig
2015-01-16 12:47 ` [Cluster-devel] [PATCH 09/17] quota: Make Q_XQUOTASYNC support VFS quota syncing Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-19 9:09 ` [Cluster-devel] " Christoph Hellwig
2015-01-19 9:09 ` Christoph Hellwig
2015-01-19 9:09 ` [Ocfs2-devel] " Christoph Hellwig
2015-01-19 9:09 ` Christoph Hellwig
2015-01-20 17:16 ` [Cluster-devel] " Jan Kara
2015-01-20 17:16 ` Jan Kara
2015-01-20 17:16 ` [Ocfs2-devel] " Jan Kara
2015-01-20 17:16 ` Jan Kara
2015-01-16 12:47 ` [Cluster-devel] [PATCH 10/17] quota: Make VFS quotas use new interface for getting quota info Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-19 9:10 ` [Cluster-devel] " Christoph Hellwig
2015-01-19 9:10 ` [Ocfs2-devel] " Christoph Hellwig
2015-01-19 9:10 ` Christoph Hellwig
2015-01-16 12:47 ` [Cluster-devel] [PATCH 11/17] quota: Wire up Q_GETXSTATE and Q_GETXSTATV calls to work with ->get_state Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-19 9:11 ` [Cluster-devel] " Christoph Hellwig
2015-01-19 9:11 ` [Ocfs2-devel] " Christoph Hellwig
2015-01-19 9:11 ` Christoph Hellwig
2015-01-16 12:47 ` [Cluster-devel] [PATCH 12/17] xfs: Convert to using ->get_state callback Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-19 9:38 ` [Cluster-devel] " Christoph Hellwig
2015-01-19 9:38 ` [Ocfs2-devel] " Christoph Hellwig
2015-01-19 9:38 ` Christoph Hellwig
2015-01-20 17:33 ` [Cluster-devel] " Jan Kara
2015-01-20 17:33 ` Jan Kara
2015-01-20 17:33 ` [Ocfs2-devel] " Jan Kara
2015-01-20 17:33 ` Jan Kara
2015-01-16 12:47 ` [Cluster-devel] [PATCH 13/17] gfs2: " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-16 12:47 ` [Cluster-devel] [PATCH 14/17] quota: Remove ->get_xstate and ->get_xstatev callbacks Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-19 9:38 ` [Cluster-devel] " Christoph Hellwig
2015-01-19 9:38 ` Christoph Hellwig
2015-01-19 9:38 ` [Ocfs2-devel] " Christoph Hellwig
2015-01-19 9:38 ` Christoph Hellwig
2015-01-16 12:47 ` [Cluster-devel] [PATCH 15/17] quota: Make ->set_info use structure with neccesary info to VFS and XFS Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-16 12:47 ` [Cluster-devel] [PATCH 16/17] xfs: Add support for Q_SETINFO Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-16 12:47 ` [Cluster-devel] [PATCH 17/17] quota: Hook up Q_XSETQLIM for id 0 to ->set_info Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-21 21:38 ` Dave Chinner [this message]
2015-01-21 21:38 ` [PATCH 0/17 v3] quota: Unify VFS and XFS quota interfaces Dave Chinner
2015-01-21 21:38 ` [Ocfs2-devel] " Dave Chinner
2015-01-21 21:38 ` Dave Chinner
2015-01-21 22:23 ` [Cluster-devel] " Jan Kara
2015-01-21 22:23 ` Jan Kara
2015-01-21 22:23 ` [Ocfs2-devel] " Jan Kara
2015-01-21 22:23 ` Jan Kara
2015-01-21 23:10 ` [Cluster-devel] " Dave Chinner
2015-01-21 23:10 ` [Ocfs2-devel] " Dave Chinner
2015-01-21 23:10 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150121213826.GL16510@dastard \
--to=david@fromorbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.