From: lorenzo.pieralisi@arm.com (Lorenzo Pieralisi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC 2/2] ARM64: psci: implement system suspend using PSCI v0.2 CPU SUSPEND
Date: Thu, 22 Jan 2015 12:08:50 +0000 [thread overview]
Message-ID: <20150122120850.GC1218@red-moon> (raw)
In-Reply-To: <20150122061812.GB9244@leoy-linaro>
On Thu, Jan 22, 2015 at 06:18:12AM +0000, Leo Yan wrote:
[...]
> How about unify the power states passing for cpu idle and suspend?
>
> below is a example for dts which place all power state into psci
> entry, so that idle-states and system suspend both can reference
> the power state.
>
> psci {
> compatible = "arm,psci-0.2";
> method = "smc";
>
> power_state {
> CPU_POWER_OFF: cpu_power_off {
> state = <0x00010000>;
> };
>
> CLUSTER_POWER_OFF: cluster_power_off {
> state = <0x01010000>;
> };
>
> SOC_SUSPEND: soc_suspend {
> state = <0x01010001>;
> };
> };
> };
I do not see why this would help. We would end up with phandles to
the nodes above to get the parameter from idle-states, to me it
looks like churn honestly, I do not see where the improvement is.
Lorenzo
WARNING: multiple messages have this Message-ID (diff)
From: Lorenzo Pieralisi <lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org>
To: Leo Yan <leo.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Sudeep Holla <Sudeep.Holla-5wv7dgnIgG8@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <Mark.Rutland-5wv7dgnIgG8@public.gmane.org>,
Catalin Marinas <Catalin.Marinas-5wv7dgnIgG8@public.gmane.org>,
Amit Daniel Kachhap
<amit.daniel-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Jonghwa Lee
<jonghwa3.lee-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Jisheng Zhang <jszhang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH RFC 2/2] ARM64: psci: implement system suspend using PSCI v0.2 CPU SUSPEND
Date: Thu, 22 Jan 2015 12:08:50 +0000 [thread overview]
Message-ID: <20150122120850.GC1218@red-moon> (raw)
In-Reply-To: <20150122061812.GB9244@leoy-linaro>
On Thu, Jan 22, 2015 at 06:18:12AM +0000, Leo Yan wrote:
[...]
> How about unify the power states passing for cpu idle and suspend?
>
> below is a example for dts which place all power state into psci
> entry, so that idle-states and system suspend both can reference
> the power state.
>
> psci {
> compatible = "arm,psci-0.2";
> method = "smc";
>
> power_state {
> CPU_POWER_OFF: cpu_power_off {
> state = <0x00010000>;
> };
>
> CLUSTER_POWER_OFF: cluster_power_off {
> state = <0x01010000>;
> };
>
> SOC_SUSPEND: soc_suspend {
> state = <0x01010001>;
> };
> };
> };
I do not see why this would help. We would end up with phandles to
the nodes above to get the parameter from idle-states, to me it
looks like churn honestly, I do not see where the improvement is.
Lorenzo
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-01-22 12:08 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 11:35 [PATCH RFC 0/2] ARM: DT: add bindings for system suspend Sudeep Holla
2015-01-21 11:35 ` Sudeep Holla
2015-01-21 11:35 ` [PATCH RFC 1/2] Documentation: arm: define DT " Sudeep Holla
2015-01-21 11:35 ` Sudeep Holla
2015-01-21 13:21 ` Jisheng Zhang
2015-01-21 13:21 ` Jisheng Zhang
2015-01-21 13:35 ` Jisheng Zhang
2015-01-21 13:35 ` Jisheng Zhang
2015-01-21 13:56 ` Lorenzo Pieralisi
2015-01-21 13:56 ` Lorenzo Pieralisi
2015-01-22 4:33 ` Jisheng Zhang
2015-01-22 4:33 ` Jisheng Zhang
2015-01-22 6:29 ` Jisheng Zhang
2015-01-22 6:29 ` Jisheng Zhang
2015-01-22 11:59 ` Lorenzo Pieralisi
2015-01-22 11:59 ` Lorenzo Pieralisi
2015-01-22 12:09 ` Jisheng Zhang
2015-01-22 12:09 ` Jisheng Zhang
2015-02-04 16:10 ` Mark Rutland
2015-02-04 16:10 ` Mark Rutland
2015-02-05 13:28 ` Sudeep Holla
2015-02-05 13:28 ` Sudeep Holla
2015-02-05 13:32 ` Mark Rutland
2015-02-05 13:32 ` Mark Rutland
2015-02-05 13:49 ` Sudeep Holla
2015-02-05 13:49 ` Sudeep Holla
2015-01-21 11:35 ` [PATCH RFC 2/2] ARM64: psci: implement system suspend using PSCI v0.2 CPU SUSPEND Sudeep Holla
2015-01-21 11:35 ` Sudeep Holla
2015-01-22 6:18 ` Leo Yan
2015-01-22 6:18 ` Leo Yan
2015-01-22 12:08 ` Lorenzo Pieralisi [this message]
2015-01-22 12:08 ` Lorenzo Pieralisi
2015-01-22 14:34 ` Leo Yan
2015-01-22 14:34 ` Leo Yan
2015-01-23 10:58 ` Mark Rutland
2015-01-23 10:58 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150122120850.GC1218@red-moon \
--to=lorenzo.pieralisi@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.