From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Alexander Sverdlin <alexander.sverdlin-OYasijW0DpE@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
jdelvare-l3A5Bk7waGM@public.gmane.org,
Laurent Pinchart
<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
Lawnick Michael 61283229
<michael.lawnick-OYasijW0DpE@public.gmane.org>,
Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v3] of: i2c: Add i2c-mux-idle-disconnect DT property to PCA954x mux driver
Date: Thu, 22 Jan 2015 15:56:43 +0100 [thread overview]
Message-ID: <20150122145643.GH3413@katana> (raw)
In-Reply-To: <54BD069C.2080108-OYasijW0DpE@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 460 bytes --]
> - (pdata && pdata->modes[num].deselect_on_exit)
> + (idle_disconnect_pd || idle_disconnect_dt)
I like that. Very readable.
I don't like the buildlog, however:
drivers/i2c/muxes/i2c-mux-pca954x.c: In function 'pca954x_probe':
drivers/i2c/muxes/i2c-mux-pca954x.c:231:3: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
drivers/i2c/muxes/i2c-mux-pca954x.c:190:22: warning: unused variable 'np' [-Wunused-variable]
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-01-22 14:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-19 17:00 [PATCH v2] of: i2c: Add idle-disconnect DT property to PCA954x mux driver Alexander Sverdlin
[not found] ` <5494599A.8050803-OYasijW0DpE@public.gmane.org>
2015-01-15 12:32 ` Wolfram Sang
2015-01-15 13:09 ` Alexander Sverdlin
[not found] ` <54B7BBF5.4010001-OYasijW0DpE@public.gmane.org>
2015-01-15 13:19 ` Wolfram Sang
2015-01-15 13:35 ` Alexander Sverdlin
[not found] ` <54B7C206.8030809-OYasijW0DpE@public.gmane.org>
2015-01-19 13:29 ` [PATCH v3] of: i2c: Add i2c-mux-idle-disconnect " Alexander Sverdlin
[not found] ` <54BD069C.2080108-OYasijW0DpE@public.gmane.org>
2015-01-22 14:56 ` Wolfram Sang [this message]
2015-01-23 15:41 ` [PATCH v4] " Alexander Sverdlin
[not found] ` <54C26BA9.4050405-OYasijW0DpE@public.gmane.org>
2015-01-23 16:13 ` Wolfram Sang
2015-01-15 14:40 ` [PATCH v2] of: i2c: Add idle-disconnect " Laurent Pinchart
2015-01-15 15:48 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150122145643.GH3413@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=alexander.sverdlin-OYasijW0DpE@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=jdelvare-l3A5Bk7waGM@public.gmane.org \
--cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=michael.lawnick-OYasijW0DpE@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.