From: Stephen Boyd <sboyd@codeaurora.org>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: linux-kernel@vger.kernel.org,
Mike Turquette <mturquette@linaro.org>,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Paul Walmsley <paul@pwsan.com>, Tony Lindgren <tony@atomide.com>,
Russell King <linux@arm.linux.org.uk>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v12 3/6] clk: Make clk API return per-user struct clk instances
Date: Thu, 22 Jan 2015 14:42:51 -0800 [thread overview]
Message-ID: <20150122224250.GP27202@codeaurora.org> (raw)
In-Reply-To: <1421943207-5180-4-git-send-email-tomeu.vizoso@collabora.com>
On 01/22, Tomeu Vizoso wrote:
> Moves clock state to struct clk_core, but takes care to change as little API as
> possible.
>
> struct clk_hw still has a pointer to a struct clk, which is the
> implementation's per-user clk instance, for backwards compatibility.
>
> The struct clk that clk_get_parent() returns isn't owned by the caller, but by
> the clock implementation, so the former shouldn't call clk_put() on it.
>
> Because some boards in mach-omap2 still register clocks statically, their clock
> registration had to be updated to take into account that the clock information
> is stored in struct clk_core now.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
>
> ---
My comment on v11 still stands about __clk_create_clk() in
clkdev.c, but otherwise I don't see problems. You can have my
reviewed-by anyway.
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v12 3/6] clk: Make clk API return per-user struct clk instances
Date: Thu, 22 Jan 2015 14:42:51 -0800 [thread overview]
Message-ID: <20150122224250.GP27202@codeaurora.org> (raw)
In-Reply-To: <1421943207-5180-4-git-send-email-tomeu.vizoso@collabora.com>
On 01/22, Tomeu Vizoso wrote:
> Moves clock state to struct clk_core, but takes care to change as little API as
> possible.
>
> struct clk_hw still has a pointer to a struct clk, which is the
> implementation's per-user clk instance, for backwards compatibility.
>
> The struct clk that clk_get_parent() returns isn't owned by the caller, but by
> the clock implementation, so the former shouldn't call clk_put() on it.
>
> Because some boards in mach-omap2 still register clocks statically, their clock
> registration had to be updated to take into account that the clock information
> is stored in struct clk_core now.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
>
> ---
My comment on v11 still stands about __clk_create_clk() in
clkdev.c, but otherwise I don't see problems. You can have my
reviewed-by anyway.
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-01-22 22:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 16:13 [PATCH v12 0/6] Per-user clock constraints Tomeu Vizoso
2015-01-22 16:13 ` [PATCH v12 1/6] clk: Remove unneeded NULL checks Tomeu Vizoso
2015-01-22 16:13 ` [PATCH v12 2/6] clk: Remove __clk_register Tomeu Vizoso
2015-01-22 19:00 ` Stephen Boyd
2015-01-22 16:13 ` [PATCH v12 3/6] clk: Make clk API return per-user struct clk instances Tomeu Vizoso
2015-01-22 16:13 ` Tomeu Vizoso
2015-01-22 22:42 ` Stephen Boyd [this message]
2015-01-22 22:42 ` Stephen Boyd
2015-01-22 16:13 ` [PATCH v12 4/6] clk: Add rate constraints to clocks Tomeu Vizoso
2015-01-22 16:13 ` Tomeu Vizoso
2015-01-22 22:48 ` Stephen Boyd
2015-01-22 22:48 ` Stephen Boyd
2015-01-22 16:13 ` [PATCH v12 5/6] clkdev: Export clk_register_clkdev Tomeu Vizoso
2015-01-22 16:13 ` Tomeu Vizoso
2015-01-22 19:01 ` Stephen Boyd
2015-01-22 19:01 ` Stephen Boyd
2015-01-22 16:13 ` [PATCH v12 6/6] clk: Add module for unit tests Tomeu Vizoso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150122224250.GP27202@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=javier.martinez@collabora.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mturquette@linaro.org \
--cc=paul@pwsan.com \
--cc=tomeu.vizoso@collabora.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.