From: Dan Carpenter <dan.carpenter@oracle.com>
To: Gleb Natapov <gleb@kernel.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, kvm@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [patch] KVM: always initialize *pdata in get_msr()
Date: Fri, 23 Jan 2015 14:32:32 +0000 [thread overview]
Message-ID: <20150123143232.GA4298@mwanda> (raw)
Smatch complains that there are some paths where we use uninitialized
data in em_sysenter().
arch/x86/kvm/emulate.c:2410 em_sysenter()
error: potentially using uninitialized 'msr_data'.
A couple examples of paths which don't set "pdata" are found in
get_msr_hyperv() and kvm_x2apic_msr_read(). I looked at this code and
it seems like setting it to zero is a common default behaviour.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
From static analysis only, not from real life.
diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
index a17d848..f0e30d2 100644
--- a/arch/x86/kvm/svm.c
+++ b/arch/x86/kvm/svm.c
@@ -3063,6 +3063,8 @@ static int svm_get_msr(struct kvm_vcpu *vcpu, unsigned ecx, u64 *data)
{
struct vcpu_svm *svm = to_svm(vcpu);
+ *data = 0;
+
switch (ecx) {
case MSR_IA32_TSC: {
*data = svm->vmcb->control.tsc_offset +
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index ce35071..3bdb9ca 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -2544,6 +2544,7 @@ static int vmx_get_msr(struct kvm_vcpu *vcpu, u32 msr_index, u64 *pdata)
printk(KERN_ERR "BUG: get_msr called with NULL pdata\n");
return -EINVAL;
}
+ *pdata = 0;
switch (msr_index) {
#ifdef CONFIG_X86_64
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Gleb Natapov <gleb@kernel.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, kvm@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [patch] KVM: always initialize *pdata in get_msr()
Date: Fri, 23 Jan 2015 17:32:32 +0300 [thread overview]
Message-ID: <20150123143232.GA4298@mwanda> (raw)
Smatch complains that there are some paths where we use uninitialized
data in em_sysenter().
arch/x86/kvm/emulate.c:2410 em_sysenter()
error: potentially using uninitialized 'msr_data'.
A couple examples of paths which don't set "pdata" are found in
get_msr_hyperv() and kvm_x2apic_msr_read(). I looked at this code and
it seems like setting it to zero is a common default behaviour.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
>From static analysis only, not from real life.
diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
index a17d848..f0e30d2 100644
--- a/arch/x86/kvm/svm.c
+++ b/arch/x86/kvm/svm.c
@@ -3063,6 +3063,8 @@ static int svm_get_msr(struct kvm_vcpu *vcpu, unsigned ecx, u64 *data)
{
struct vcpu_svm *svm = to_svm(vcpu);
+ *data = 0;
+
switch (ecx) {
case MSR_IA32_TSC: {
*data = svm->vmcb->control.tsc_offset +
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index ce35071..3bdb9ca 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -2544,6 +2544,7 @@ static int vmx_get_msr(struct kvm_vcpu *vcpu, u32 msr_index, u64 *pdata)
printk(KERN_ERR "BUG: get_msr called with NULL pdata\n");
return -EINVAL;
}
+ *pdata = 0;
switch (msr_index) {
#ifdef CONFIG_X86_64
next reply other threads:[~2015-01-23 14:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 14:32 Dan Carpenter [this message]
2015-01-23 14:32 ` [patch] KVM: always initialize *pdata in get_msr() Dan Carpenter
2015-01-23 16:08 ` Radim Krčmář
2015-01-23 16:08 ` Radim Krčmář
2015-01-24 9:26 ` Dan Carpenter
2015-01-24 9:26 ` Dan Carpenter
2015-01-23 17:50 ` Paolo Bonzini
2015-01-23 17:50 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150123143232.GA4298@mwanda \
--to=dan.carpenter@oracle.com \
--cc=gleb@kernel.org \
--cc=hpa@zytor.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.