From: Bjorn Helgaas <bhelgaas@google.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
Tanmay Inamdar <tinamdar@apm.com>
Subject: Re: [PATCH] PCI: xgene: Include clk.h instead of clk-private.h
Date: Fri, 23 Jan 2015 17:22:23 -0600 [thread overview]
Message-ID: <20150123232223.GU29776@google.com> (raw)
In-Reply-To: <1421954754-3217-1-git-send-email-sboyd@codeaurora.org>
On Thu, Jan 22, 2015 at 11:25:54AM -0800, Stephen Boyd wrote:
> This driver should be including clk.h as it's a clock consumer,
> not a clock provider that needs to register clocks early.
>
> Cc: Tanmay Inamdar <tinamdar@apm.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Applied provisionally to pci/host-xgene for v3.20, thanks!
I'm hoping for an ack from Tanmay.
> ---
> drivers/pci/host/pci-xgene.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pci-xgene.c b/drivers/pci/host/pci-xgene.c
> index b1d0596457c5..fdb348d3ccd3 100644
> --- a/drivers/pci/host/pci-xgene.c
> +++ b/drivers/pci/host/pci-xgene.c
> @@ -16,7 +16,7 @@
> * GNU General Public License for more details.
> *
> */
> -#include <linux/clk-private.h>
> +#include <linux/clk.h>
> #include <linux/delay.h>
> #include <linux/io.h>
> #include <linux/jiffies.h>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
WARNING: multiple messages have this Message-ID (diff)
From: bhelgaas@google.com (Bjorn Helgaas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] PCI: xgene: Include clk.h instead of clk-private.h
Date: Fri, 23 Jan 2015 17:22:23 -0600 [thread overview]
Message-ID: <20150123232223.GU29776@google.com> (raw)
In-Reply-To: <1421954754-3217-1-git-send-email-sboyd@codeaurora.org>
On Thu, Jan 22, 2015 at 11:25:54AM -0800, Stephen Boyd wrote:
> This driver should be including clk.h as it's a clock consumer,
> not a clock provider that needs to register clocks early.
>
> Cc: Tanmay Inamdar <tinamdar@apm.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Applied provisionally to pci/host-xgene for v3.20, thanks!
I'm hoping for an ack from Tanmay.
> ---
> drivers/pci/host/pci-xgene.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pci-xgene.c b/drivers/pci/host/pci-xgene.c
> index b1d0596457c5..fdb348d3ccd3 100644
> --- a/drivers/pci/host/pci-xgene.c
> +++ b/drivers/pci/host/pci-xgene.c
> @@ -16,7 +16,7 @@
> * GNU General Public License for more details.
> *
> */
> -#include <linux/clk-private.h>
> +#include <linux/clk.h>
> #include <linux/delay.h>
> #include <linux/io.h>
> #include <linux/jiffies.h>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
next prev parent reply other threads:[~2015-01-23 23:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 19:25 [PATCH] PCI: xgene: Include clk.h instead of clk-private.h Stephen Boyd
2015-01-22 19:25 ` Stephen Boyd
2015-01-23 23:22 ` Bjorn Helgaas [this message]
2015-01-23 23:22 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150123232223.GU29776@google.com \
--to=bhelgaas@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=tinamdar@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.