From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: sun4i: Add initial dts for Gemei G9 tablet
Date: Sat, 24 Jan 2015 15:39:45 +0100 [thread overview]
Message-ID: <20150124143945.GD8470@lukather> (raw)
In-Reply-To: <1422050375.1799.9.camel@plaes.org>
Hi,
On Fri, Jan 23, 2015 at 11:59:35PM +0200, Priit Laes wrote:
>
> On Fri, 2015-01-23 at 22:22 +0100, Maxime Ripard wrote:
> > On Fri, Jan 23, 2015 at 10:36:49PM +0200, Priit Laes wrote:
> > > Gemei G9 is an A10 based tablet, with 1G RAM, 16G NAND, 1024x768
> > > IPS LCD display, stereo speakers, 1.3MP front camera and 5 MP
> > > rear camera, 8000mAh battery, GT901 2+1 touchscreen, Bosch BMA250
> > > accelerometer and RTL8188CUS USB wifi. It also has MicroSD slot,
> > > miniHDMI, 1 x MicroUSB OTG port and 1 x MicroUSB host port and
> > > 3.5mm headphone jack.
> > > More details are available at: http://linux-sunxi.org/Gemei_G9
> > >
> [..]
> > >
> > > +/ {
> > > + model = "Gemei G9 Tablet";
> > > + compatible = "gemei,g9", "allwinner,sun4i-a10";
> > > +};
> > > +
> > > +/*
> > > + * http://linux-sunxi.org/Gemei_G9
> >
> > Please don't put URL in the DT. This is very likely to change in the
> > future, and won't be valid anymore.
>
> OK! The URL in commit message is ok to stay?
Yeah, I'm not that fond of it, but it's not that important either.
> > > +&i2c1 {
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&i2c1_pins_a>;
> > > + status = "okay";
> > > +
> > > + /* Accelerometer */
> > > + bma250 at 18 {
> > > + compatible = "bosch,bma250";
> > > + reg = <0x18>;
> >
> > Is there a driver for this? It looks weird that it doesn't need more
> > properties than that.
>
> Yes, it's supported by drivers/iio/accel/bma180.c though I have to
> admit that this name is a bit misleading. (bosch-bma.c would
> better, I guess).
>
> And I was a bit surprised that it worked out of the box too, but the
> device was present under /sys and I was able to read x, y, z and
> temperature values.
Cool :)
There's no interrupt wired to it then?
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150124/3f1eb110/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Priit Laes <plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] ARM: dts: sun4i: Add initial dts for Gemei G9 tablet
Date: Sat, 24 Jan 2015 15:39:45 +0100 [thread overview]
Message-ID: <20150124143945.GD8470@lukather> (raw)
In-Reply-To: <1422050375.1799.9.camel-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1988 bytes --]
Hi,
On Fri, Jan 23, 2015 at 11:59:35PM +0200, Priit Laes wrote:
>
> On Fri, 2015-01-23 at 22:22 +0100, Maxime Ripard wrote:
> > On Fri, Jan 23, 2015 at 10:36:49PM +0200, Priit Laes wrote:
> > > Gemei G9 is an A10 based tablet, with 1G RAM, 16G NAND, 1024x768
> > > IPS LCD display, stereo speakers, 1.3MP front camera and 5 MP
> > > rear camera, 8000mAh battery, GT901 2+1 touchscreen, Bosch BMA250
> > > accelerometer and RTL8188CUS USB wifi. It also has MicroSD slot,
> > > miniHDMI, 1 x MicroUSB OTG port and 1 x MicroUSB host port and
> > > 3.5mm headphone jack.
> > > More details are available at: http://linux-sunxi.org/Gemei_G9
> > >
> [..]
> > >
> > > +/ {
> > > + model = "Gemei G9 Tablet";
> > > + compatible = "gemei,g9", "allwinner,sun4i-a10";
> > > +};
> > > +
> > > +/*
> > > + * http://linux-sunxi.org/Gemei_G9
> >
> > Please don't put URL in the DT. This is very likely to change in the
> > future, and won't be valid anymore.
>
> OK! The URL in commit message is ok to stay?
Yeah, I'm not that fond of it, but it's not that important either.
> > > +&i2c1 {
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&i2c1_pins_a>;
> > > + status = "okay";
> > > +
> > > + /* Accelerometer */
> > > + bma250@18 {
> > > + compatible = "bosch,bma250";
> > > + reg = <0x18>;
> >
> > Is there a driver for this? It looks weird that it doesn't need more
> > properties than that.
>
> Yes, it's supported by drivers/iio/accel/bma180.c though I have to
> admit that this name is a bit misleading. (bosch-bma.c would
> better, I guess).
>
> And I was a bit surprised that it worked out of the box too, but the
> device was present under /sys and I was able to read x, y, z and
> temperature values.
Cool :)
There's no interrupt wired to it then?
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Priit Laes <plaes@plaes.org>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: sun4i: Add initial dts for Gemei G9 tablet
Date: Sat, 24 Jan 2015 15:39:45 +0100 [thread overview]
Message-ID: <20150124143945.GD8470@lukather> (raw)
In-Reply-To: <1422050375.1799.9.camel@plaes.org>
[-- Attachment #1: Type: text/plain, Size: 1988 bytes --]
Hi,
On Fri, Jan 23, 2015 at 11:59:35PM +0200, Priit Laes wrote:
>
> On Fri, 2015-01-23 at 22:22 +0100, Maxime Ripard wrote:
> > On Fri, Jan 23, 2015 at 10:36:49PM +0200, Priit Laes wrote:
> > > Gemei G9 is an A10 based tablet, with 1G RAM, 16G NAND, 1024x768
> > > IPS LCD display, stereo speakers, 1.3MP front camera and 5 MP
> > > rear camera, 8000mAh battery, GT901 2+1 touchscreen, Bosch BMA250
> > > accelerometer and RTL8188CUS USB wifi. It also has MicroSD slot,
> > > miniHDMI, 1 x MicroUSB OTG port and 1 x MicroUSB host port and
> > > 3.5mm headphone jack.
> > > More details are available at: http://linux-sunxi.org/Gemei_G9
> > >
> [..]
> > >
> > > +/ {
> > > + model = "Gemei G9 Tablet";
> > > + compatible = "gemei,g9", "allwinner,sun4i-a10";
> > > +};
> > > +
> > > +/*
> > > + * http://linux-sunxi.org/Gemei_G9
> >
> > Please don't put URL in the DT. This is very likely to change in the
> > future, and won't be valid anymore.
>
> OK! The URL in commit message is ok to stay?
Yeah, I'm not that fond of it, but it's not that important either.
> > > +&i2c1 {
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&i2c1_pins_a>;
> > > + status = "okay";
> > > +
> > > + /* Accelerometer */
> > > + bma250@18 {
> > > + compatible = "bosch,bma250";
> > > + reg = <0x18>;
> >
> > Is there a driver for this? It looks weird that it doesn't need more
> > properties than that.
>
> Yes, it's supported by drivers/iio/accel/bma180.c though I have to
> admit that this name is a bit misleading. (bosch-bma.c would
> better, I guess).
>
> And I was a bit surprised that it worked out of the box too, but the
> device was present under /sys and I was able to read x, y, z and
> temperature values.
Cool :)
There's no interrupt wired to it then?
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-01-24 14:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 20:36 [PATCH] ARM: dts: sun4i: Add initial dts for Gemei G9 tablet Priit Laes
2015-01-23 20:36 ` Priit Laes
2015-01-23 20:36 ` Priit Laes
2015-01-23 21:22 ` Maxime Ripard
2015-01-23 21:22 ` Maxime Ripard
2015-01-23 21:22 ` Maxime Ripard
2015-01-23 21:59 ` Priit Laes
2015-01-23 21:59 ` Priit Laes
2015-01-23 21:59 ` Priit Laes
2015-01-24 14:39 ` Maxime Ripard [this message]
2015-01-24 14:39 ` Maxime Ripard
2015-01-24 14:39 ` Maxime Ripard
2015-01-24 15:53 ` Priit Laes
2015-01-24 15:53 ` Priit Laes
2015-01-24 15:53 ` Priit Laes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150124143945.GD8470@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.