From: Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Esben Haabendal
<esben.haabendal-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Stefan Roese <sr-ynQEQJNshbs@public.gmane.org>
Subject: Re: Backport of spi-fsl-spi bugfix to 3.14.y
Date: Sun, 25 Jan 2015 09:38:53 -0800 [thread overview]
Message-ID: <20150125173853.GA6467@kroah.com> (raw)
In-Reply-To: <20150123124529.GU21293-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On Fri, Jan 23, 2015 at 12:45:29PM +0000, Mark Brown wrote:
> On Tue, Jan 06, 2015 at 10:15:47PM +0100, Esben Haabendal wrote:
> > On 5 January 2015 at 16:48, Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
>
> > >> Please consider commit 4302a59629f7a0bd70fd1605d2b558597517372a
> > >> (spi: fsl: Fix problem with multi message transfers) for inclusion in
> > >> stable kernel 3.14.
>
> > >> It fixes a regression when using mmc_spi driver on top of spi-fsl-spi
> > >> driver (tested with powerpc mpc8313 based board).
>
> > > Has this ever worked?
>
> > Yes, I have used mmc_spi with spi-fsl-spi on the same board with success
> > with in 2.6.33, 3.0 and 3.4.
>
> > I have no idea what has caused this to break. Maybe mmc_spi driver was
> > not doing multi message transfers earlier?
>
> So, I now see this has actually been merged into stable without getting
> to the bottom of why it's helping anything... this is a bit worrying
> since it's adding new functionality and not really a bug fix. It'd have
> been good to at least get a followup here.
Do you want me to revert something from the stable tree? If so, has it
also been reverted upstream?
confused,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Mark Brown <broonie@kernel.org>
Cc: Esben Haabendal <esben.haabendal@gmail.com>,
stable@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org, Stefan Roese <sr@denx.de>
Subject: Re: Backport of spi-fsl-spi bugfix to 3.14.y
Date: Sun, 25 Jan 2015 09:38:53 -0800 [thread overview]
Message-ID: <20150125173853.GA6467@kroah.com> (raw)
In-Reply-To: <20150123124529.GU21293@sirena.org.uk>
On Fri, Jan 23, 2015 at 12:45:29PM +0000, Mark Brown wrote:
> On Tue, Jan 06, 2015 at 10:15:47PM +0100, Esben Haabendal wrote:
> > On 5 January 2015 at 16:48, Mark Brown <broonie@kernel.org> wrote:
>
> > >> Please consider commit 4302a59629f7a0bd70fd1605d2b558597517372a
> > >> (spi: fsl: Fix problem with multi message transfers) for inclusion in
> > >> stable kernel 3.14.
>
> > >> It fixes a regression when using mmc_spi driver on top of spi-fsl-spi
> > >> driver (tested with powerpc mpc8313 based board).
>
> > > Has this ever worked?
>
> > Yes, I have used mmc_spi with spi-fsl-spi on the same board with success
> > with in 2.6.33, 3.0 and 3.4.
>
> > I have no idea what has caused this to break. Maybe mmc_spi driver was
> > not doing multi message transfers earlier?
>
> So, I now see this has actually been merged into stable without getting
> to the bottom of why it's helping anything... this is a bit worrying
> since it's adding new functionality and not really a bug fix. It'd have
> been good to at least get a followup here.
Do you want me to revert something from the stable tree? If so, has it
also been reverted upstream?
confused,
greg k-h
next prev parent reply other threads:[~2015-01-25 17:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 15:42 Backport of spi-fsl-spi bugfix to 3.14.y Esben Haabendal
2015-01-05 15:42 ` Esben Haabendal
2015-01-05 15:48 ` Mark Brown
2015-01-06 21:15 ` Esben Haabendal
[not found] ` <CAOR3GqUBWyfUvNG-8JiPVkis6b_25Eq_REtcp=kLN3CUoqsG6g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-23 12:45 ` Mark Brown
2015-01-23 12:45 ` Mark Brown
[not found] ` <20150123124529.GU21293-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-01-25 17:38 ` Greg Kroah-Hartman [this message]
2015-01-25 17:38 ` Greg Kroah-Hartman
2015-01-25 20:12 ` Mark Brown
[not found] ` <20150125201254.GX21293-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-01-25 22:07 ` Greg Kroah-Hartman
2015-01-25 22:07 ` Greg Kroah-Hartman
2015-02-04 9:03 ` Esben Haabendal
2015-02-05 14:33 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150125173853.GA6467@kroah.com \
--to=gregkh-hqyy1w1ycw8ekmwlsbkhg0b+6bgklq7r@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=esben.haabendal-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sr-ynQEQJNshbs@public.gmane.org \
--cc=stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.