From: baruch@tkos.co.il (Baruch Siach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 2/2] clocksource: driver for Conexant Digicolor SoC timer
Date: Mon, 26 Jan 2015 15:47:51 +0200 [thread overview]
Message-ID: <20150126134751.GE3148@tarshish> (raw)
In-Reply-To: <54C644AF.9030208@linaro.org>
Hi Daniel,
On Mon, Jan 26, 2015 at 02:44:15PM +0100, Daniel Lezcano wrote:
> >diff --git a/drivers/clocksource/Makefile b/drivers/clocksource/Makefile
> >index 94d90b24b56b..a993c108be67 100644
> >--- a/drivers/clocksource/Makefile
> >+++ b/drivers/clocksource/Makefile
> >@@ -10,6 +10,7 @@ obj-$(CONFIG_SH_TIMER_TMU) += sh_tmu.o
> > obj-$(CONFIG_EM_TIMER_STI) += em_sti.o
> > obj-$(CONFIG_CLKBLD_I8253) += i8253.o
> > obj-$(CONFIG_CLKSRC_MMIO) += mmio.o
> >+obj-$(CONFIG_ARCH_DIGICOLOR) += timer-digicolor.o
>
> Ah, one minor change I forgot to mention in the last review (sorry about
> that).
>
> Don't depend on the ARCH, add and select a TIMER_DIGICOLOR (or whatever the
> name you prefer) in the mach-digicolor/Kconfig and use it here.
OK. I'll make the change. I'm just curious: what is the advantage of having a
separate config symbol for the timer?
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
WARNING: multiple messages have this Message-ID (diff)
From: Baruch Siach <baruch@tkos.co.il>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 2/2] clocksource: driver for Conexant Digicolor SoC timer
Date: Mon, 26 Jan 2015 15:47:51 +0200 [thread overview]
Message-ID: <20150126134751.GE3148@tarshish> (raw)
In-Reply-To: <54C644AF.9030208@linaro.org>
Hi Daniel,
On Mon, Jan 26, 2015 at 02:44:15PM +0100, Daniel Lezcano wrote:
> >diff --git a/drivers/clocksource/Makefile b/drivers/clocksource/Makefile
> >index 94d90b24b56b..a993c108be67 100644
> >--- a/drivers/clocksource/Makefile
> >+++ b/drivers/clocksource/Makefile
> >@@ -10,6 +10,7 @@ obj-$(CONFIG_SH_TIMER_TMU) += sh_tmu.o
> > obj-$(CONFIG_EM_TIMER_STI) += em_sti.o
> > obj-$(CONFIG_CLKBLD_I8253) += i8253.o
> > obj-$(CONFIG_CLKSRC_MMIO) += mmio.o
> >+obj-$(CONFIG_ARCH_DIGICOLOR) += timer-digicolor.o
>
> Ah, one minor change I forgot to mention in the last review (sorry about
> that).
>
> Don't depend on the ARCH, add and select a TIMER_DIGICOLOR (or whatever the
> name you prefer) in the mach-digicolor/Kconfig and use it here.
OK. I'll make the change. I'm just curious: what is the advantage of having a
separate config symbol for the timer?
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2015-01-26 13:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 11:57 [PATCH v5 0/2] clocksource: Conexant CX92755 timers support Baruch Siach
2015-01-26 11:57 ` Baruch Siach
2015-01-26 11:57 ` [PATCH v5 1/2] clocksource: devicetree: document Conexant Digicolor timer binding Baruch Siach
2015-01-26 11:57 ` Baruch Siach
2015-01-26 11:57 ` [PATCH v5 2/2] clocksource: driver for Conexant Digicolor SoC timer Baruch Siach
2015-01-26 11:57 ` Baruch Siach
2015-01-26 13:44 ` Daniel Lezcano
2015-01-26 13:44 ` Daniel Lezcano
2015-01-26 13:47 ` Baruch Siach [this message]
2015-01-26 13:47 ` Baruch Siach
2015-01-26 13:58 ` Daniel Lezcano
2015-01-26 13:58 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150126134751.GE3148@tarshish \
--to=baruch@tkos.co.il \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.