From: Minchan Kim <minchan@kernel.org>
To: Ganesh Mahendran <opensource.ganesh@gmail.com>
Cc: ngupta@vflare.org, akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] zram: free meta table in zram_meta_free
Date: Tue, 27 Jan 2015 00:45:19 +0900 [thread overview]
Message-ID: <20150126154506.GA528@blaptop> (raw)
In-Reply-To: <1422107153-9701-1-git-send-email-opensource.ganesh@gmail.com>
Hello,
On Sat, Jan 24, 2015 at 09:45:53PM +0800, Ganesh Mahendran wrote:
> zram_meta_alloc() and zram_meta_free() are a pair.
> In zram_meta_alloc(), meta table is allocated. So it it better to free
> it in zram_meta_free().
>
> Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com>
> Cc: Nitin Gupta <ngupta@vflare.org>
> Cc: Minchan Kim <minchan@kernel.org>
Looks good to me but it seems the patch is based on my recent work
"zram: free meta out of init_lock".
Please resend it on recent mmotm because I will respin my patch and
your patch is orthogonal with mine.
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Ganesh Mahendran <opensource.ganesh@gmail.com>
Cc: ngupta@vflare.org, akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] zram: free meta table in zram_meta_free
Date: Tue, 27 Jan 2015 00:45:19 +0900 [thread overview]
Message-ID: <20150126154506.GA528@blaptop> (raw)
In-Reply-To: <1422107153-9701-1-git-send-email-opensource.ganesh@gmail.com>
Hello,
On Sat, Jan 24, 2015 at 09:45:53PM +0800, Ganesh Mahendran wrote:
> zram_meta_alloc() and zram_meta_free() are a pair.
> In zram_meta_alloc(), meta table is allocated. So it it better to free
> it in zram_meta_free().
>
> Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com>
> Cc: Nitin Gupta <ngupta@vflare.org>
> Cc: Minchan Kim <minchan@kernel.org>
Looks good to me but it seems the patch is based on my recent work
"zram: free meta out of init_lock".
Please resend it on recent mmotm because I will respin my patch and
your patch is orthogonal with mine.
Thanks.
next prev parent reply other threads:[~2015-01-26 15:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-24 13:45 [PATCH] zram: free meta table in zram_meta_free Ganesh Mahendran
2015-01-24 13:45 ` Ganesh Mahendran
2015-01-26 15:45 ` Minchan Kim [this message]
2015-01-26 15:45 ` Minchan Kim
2015-01-27 1:42 ` Ganesh Mahendran
2015-01-27 1:42 ` Ganesh Mahendran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150126154506.GA528@blaptop \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ngupta@vflare.org \
--cc=opensource.ganesh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.