From: Lukasz Majewski <l.majewski@samsung.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Eduardo Valentin <edubezval@gmail.com>,
Linux PM list <linux-pm@vger.kernel.org>,
Lukasz Majewski <l.majewski@majess.pl>,
Abhilash Kesavan <kesavan.abhilash@gmail.com>,
Abhilash Kesavan <a.kesavan@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Thomas Abraham <thomas.ab@samsung.com>,
Kevin Hilman <khilman@linaro.org>,
Kevin Hilman <khilman@kernel.org>,
a.nitecki@samsung.com
Subject: Re: [PATCH 3/3] doc: cpufreq: tests: Provide cpufreq tests README
Date: Tue, 27 Jan 2015 09:35:23 +0100 [thread overview]
Message-ID: <20150127093523.55cb3a10@amdc2363> (raw)
In-Reply-To: <CAKohpon6e1kX0DdB46t-60ddeZf1PG4yzSxX_nmVxsHst4cjwQ@mail.gmail.com>
Hi Viresh,
> On 26 January 2015 at 16:11, Lukasz Majewski <l.majewski@samsung.com>
> wrote:
> > This commit adds README to ./tools/testing/cpufreq directory.
>
> You might want to have a look at this..
>
> https://git.linaro.org/people/viresh.kumar/cpufreq-tests.git
>
>
> I had been working on this recently ..
Very nice pack of tests.
What I can say after a glimpse look on them is that your tests already
implement case for "governors switching".
However the 'cpufreq_freq_test.sh' do a bit more - it uses performance,
then forces 100% CPU usage and then switch from one single frequency to
all available (including BOOST modes). For that reason I think that it
would be valuable to add this test to your suite (of course on your
discretion).
Viresh, do you plan to add your tests to
kernel's ./tools/testing/cpufreq/ directory? It would enhance
recognition of your work and encourage others to use it before
submitting patches.
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
next prev parent reply other threads:[~2015-01-27 8:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 10:41 [PATCH 1/3] cpufreq: tests: Cpufreq test to check if all declared freqs can be set Lukasz Majewski
2015-01-26 10:41 ` [PATCH 2/3] cpufreq: tests: Provide test to check if all supported governors are working Lukasz Majewski
2015-01-26 10:41 ` [PATCH 3/3] doc: cpufreq: tests: Provide cpufreq tests README Lukasz Majewski
2015-01-27 3:56 ` Viresh Kumar
2015-01-27 8:35 ` Lukasz Majewski [this message]
2015-01-27 8:40 ` Viresh Kumar
2015-01-27 8:57 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150127093523.55cb3a10@amdc2363 \
--to=l.majewski@samsung.com \
--cc=a.kesavan@samsung.com \
--cc=a.nitecki@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=edubezval@gmail.com \
--cc=kesavan.abhilash@gmail.com \
--cc=khilman@kernel.org \
--cc=khilman@linaro.org \
--cc=l.majewski@majess.pl \
--cc=linux-pm@vger.kernel.org \
--cc=thomas.ab@samsung.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.