Re: [PATCH 3/3] doc: cpufreq: tests: Provide cpufreq tests README

[Lukasz Majewski <l.majewski@samsung.com>]

Hi Viresh,

> On 27 January 2015 at 14:05, Lukasz Majewski <l.majewski@samsung.com>
> wrote:
> > Very nice pack of tests.
> 
> Thanks.
> 
> > What I can say after a glimpse look on them is that your tests
> > already implement case for "governors switching".
> 
> Correct and much more than that :)
> 
> > However the 'cpufreq_freq_test.sh' do a bit more - it uses
> > performance, then forces 100% CPU usage and then switch from one
> > single frequency to all available (including BOOST modes). For that
> > reason I think that it would be valuable to add this test to your
> > suite (of course on your discretion).
> 
> Will you be able to send a patch for that to me (*without* the lists)?

I rather thought about running this test as your run yours with runme.sh

> 
> > Viresh, do you plan to add your tests to
> > kernel's ./tools/testing/cpufreq/ directory? It would enhance
> > recognition of your work and encourage others to use it before
> > submitting patches.
> 
> Yeah, I do plan to. I have been doing some major reworks of cpufreq
> core and so I built them. I haven't found time yet to get them in, but
> they will surely be there in some time :)

I had similar problem with UDC/USB development in u-boot. I had a set
of "private/not ready to publish/etc" tests against regressions.

Only when I've posted those tests to the mailing list and they were
included to development tree, people started to use them before
submitting patches. I have less maintanence work and also developers
helped me a lot with improving the tests itself.

I'm a good example - I wasn't aware about your tests, and hence didn't
use them.
I believe that those tests shall land under ./tools/testing/cpufreq/
directory ASAP.

> 
> --
> viresh



-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group