From: Florian Westphal <fw@strlen.de>
To: David Laight <David.Laight@ACULAB.COM>
Cc: 'Fan Du' <fan.du@intel.com>,
"steffen.klassert@secunet.com" <steffen.klassert@secunet.com>,
"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"fengyuleidian0615@gmail.com" <fengyuleidian0615@gmail.com>
Subject: Re: [PATCHv3 ipsec-next] xfrm: Do not parse 32bits compiled xfrm netlink msg on 64bits host
Date: Tue, 27 Jan 2015 12:04:13 +0100 [thread overview]
Message-ID: <20150127110413.GF1373@breakpoint.cc> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D1CAD3B2B@AcuExch.aculab.com>
David Laight <David.Laight@ACULAB.COM> wrote:
> From: Fan Du
> > structure like xfrm_usersa_info or xfrm_userpolicy_info
> > has different sizeof when compiled as 32bits and 64bits
> > due to not appending pack attribute in their definition.
>
> Don't 'pack' the structure, just ensure that all the fields
> are fixed sized and on their natural boundary.
How do you propose to do this without breaking ABI?
> Possibly add a compile-time check that the structure is
> of the expected size.
Uh, what?
next prev parent reply other threads:[~2015-01-27 11:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150127.001226.711259930266409202.davem () davemloft ! net>
2015-01-27 9:00 ` [PATCHv3 ipsec-next] xfrm: Do not parse 32bits compiled xfrm netlink msg on 64bits host Fan Du
2015-01-27 9:46 ` David Laight
2015-01-27 11:04 ` Florian Westphal [this message]
2015-01-27 11:54 ` David Laight
2015-01-27 19:24 ` David Miller
2015-01-28 9:53 ` David Laight
2015-01-28 4:34 ` Fan Du
2015-01-29 10:29 ` [PATCHv3, " Nicolas Dichtel
2015-01-29 13:56 ` David Laight
2015-01-29 14:14 ` Nicolas Dichtel
2015-01-30 2:11 ` Fan Du
2015-02-02 8:44 ` Steffen Klassert
2015-02-02 9:02 ` Nicolas Dichtel
2015-02-02 19:45 ` David Miller
2015-02-03 12:24 ` Steffen Klassert
2015-02-03 14:02 ` Nicolas Dichtel
2015-03-06 6:13 ` [PATCHv3 " Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150127110413.GF1373@breakpoint.cc \
--to=fw@strlen.de \
--cc=David.Laight@ACULAB.COM \
--cc=davem@davemloft.net \
--cc=fan.du@intel.com \
--cc=fengyuleidian0615@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.