All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steffen Klassert <steffen.klassert@secunet.com>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: Fan Du <fan.du@intel.com>, <herbert@gondor.apana.org.au>,
	<davem@davemloft.net>, <netdev@vger.kernel.org>,
	<fengyuleidian0615@gmail.com>
Subject: Re: [PATCHv3, ipsec-next] xfrm: Do not parse 32bits compiled xfrm netlink msg on 64bits host
Date: Tue, 3 Feb 2015 13:24:32 +0100	[thread overview]
Message-ID: <20150203122432.GV13046@secunet.com> (raw)
In-Reply-To: <54CF3D3A.5040607@6wind.com>

On Mon, Feb 02, 2015 at 10:02:50AM +0100, Nicolas Dichtel wrote:
> Le 02/02/2015 09:44, Steffen Klassert a écrit :
> >On Thu, Jan 29, 2015 at 11:29:51AM +0100, Nicolas Dichtel wrote:
> [snip]
> >>
> >>The point I try to make is that patching userland apps allows to use xfrm on a
> >>32bits userland / 64bits kernel.
> >
> >Ugh, I did not know that this is used that way. Which applications do this?
> >So the situation is worse than I thought. What happens to such applications
> >if we add a compat layer in the kernel? I'd guess they will break, right?
> A compat layer will be perfect. I just wanted to highlight the fact that without
> this patch, it's possible to have a workaround to use netlink-xfrm and after it,
> it will be impossible.

You did not answer my question about the applications that do this.
If it is just possible, but there are no actual users, we should
apply this patch as soon as possible to avoid any abuse of this ABI.

I tend to apply this patch unless you can come up with a real world
application that will break if we do so.

  parent reply	other threads:[~2015-02-03 12:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150127.001226.711259930266409202.davem () davemloft ! net>
2015-01-27  9:00 ` [PATCHv3 ipsec-next] xfrm: Do not parse 32bits compiled xfrm netlink msg on 64bits host Fan Du
2015-01-27  9:46   ` David Laight
2015-01-27 11:04     ` Florian Westphal
2015-01-27 11:54       ` David Laight
2015-01-27 19:24     ` David Miller
2015-01-28  9:53       ` David Laight
2015-01-28  4:34     ` Fan Du
2015-01-29 10:29   ` [PATCHv3, " Nicolas Dichtel
2015-01-29 13:56     ` David Laight
2015-01-29 14:14       ` Nicolas Dichtel
2015-01-30  2:11     ` Fan Du
2015-02-02  8:44     ` Steffen Klassert
2015-02-02  9:02       ` Nicolas Dichtel
2015-02-02 19:45         ` David Miller
2015-02-03 12:24         ` Steffen Klassert [this message]
2015-02-03 14:02           ` Nicolas Dichtel
2015-03-06  6:13   ` [PATCHv3 " Steffen Klassert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150203122432.GV13046@secunet.com \
    --to=steffen.klassert@secunet.com \
    --cc=davem@davemloft.net \
    --cc=fan.du@intel.com \
    --cc=fengyuleidian0615@gmail.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.