All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
	andy.yan@rock-chips.com, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: bridge/dw_hdmi: Fix return error path
Date: Wed, 28 Jan 2015 09:00:53 +0100	[thread overview]
Message-ID: <20150128080052.GB23469@ulmo> (raw)
In-Reply-To: <1422371871.3751.55.camel@pengutronix.de>


[-- Attachment #1.1: Type: text/plain, Size: 1208 bytes --]

On Tue, Jan 27, 2015 at 04:17:51PM +0100, Philipp Zabel wrote:
> Hi Fabio,
> 
> Am Dienstag, den 27.01.2015, 10:54 -0200 schrieb Fabio Estevam:
> > If devm_request_threaded_irq() fails we should jump to 'err_iahb' label that 
> > will disable the clocks that were previously enabled.
> > 
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> > ---
> >  drivers/gpu/drm/bridge/dw_hdmi.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c
> > index ed3dfe7..cd6a706 100644
> > --- a/drivers/gpu/drm/bridge/dw_hdmi.c
> > +++ b/drivers/gpu/drm/bridge/dw_hdmi.c
> > @@ -1642,7 +1642,7 @@ int dw_hdmi_bind(struct device *dev, struct device *master,
> >  					dw_hdmi_irq, IRQF_SHARED,
> >  					dev_name(dev), hdmi);
> >  	if (ret)
> > -		return ret;
> > +		goto err_iahb;
> >  
> >  	/*
> >  	 * To prevent overflows in HDMI_IH_FC_STAT2, set the clk regenerator
> 
> Thanks for the fix. I have applied this to my tree since I've introduced
> the bug in there.

I'm currently redoing the drm/{panel,bridge} pull request anyway, so I
could apply this while at it.

Thierry

[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2015-01-28  8:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-27 12:54 [PATCH] drm: bridge/dw_hdmi: Fix return error path Fabio Estevam
2015-01-27 15:17 ` Philipp Zabel
2015-01-28  8:00   ` Thierry Reding [this message]
2015-01-28  8:45     ` Philipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150128080052.GB23469@ulmo \
    --to=thierry.reding@gmail.com \
    --cc=andy.yan@rock-chips.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fabio.estevam@freescale.com \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.