All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <bhelgaas@google.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Rob Herring <robh@kernel.org>, Krzysztof Halasa <khalasa@piap.pl>,
	linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH] ARM: cns3xxx: fix typo in PCI config accessor
Date: Wed, 28 Jan 2015 09:17:12 -0600	[thread overview]
Message-ID: <20150128151712.GA12050@google.com> (raw)
In-Reply-To: <2000255.rnmr9HfSOg@wuerfel>

On Wed, Jan 28, 2015 at 02:53:07PM +0100, Arnd Bergmann wrote:
> The recent patch to convert the cns3xxx PCI code added an
> extraneous opening bracket, which makes the build fail,
> so remove this.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 10e2c5540d48 ("ARM: cns3xxx: Convert PCI to use generic config accessors")
> ---
> 
> Hi Bjorn,
> 
> The broken patch just showed up in linux-next. Please apply this one on top,
> or fold it into the original patch if you don't mind rebasing.

I folded it in, thanks!  I guess Fengguang's autobuilder must not build
this config, because I got a success report from it.

> diff --git a/arch/arm/mach-cns3xxx/pcie.c b/arch/arm/mach-cns3xxx/pcie.c
> index e41fc339d100..c622c306c390 100644
> --- a/arch/arm/mach-cns3xxx/pcie.c
> +++ b/arch/arm/mach-cns3xxx/pcie.c
> @@ -101,7 +101,7 @@ static int cns3xxx_pci_read_config(struct pci_bus *bus, unsigned int devfn,
>  		 * for a PCIe bridge. So we must fixup the class code
>  		 * to 0x604 here.
>  		 */
> -		*val = (((((*val << shift) & 0xff) | (0x604 << 16)) >> shift) & mask;
> +		*val = ((((*val << shift) & 0xff) | (0x604 << 16)) >> shift) & mask;
>  
>  	return ret;
>  }
> 

WARNING: multiple messages have this Message-ID (diff)
From: bhelgaas@google.com (Bjorn Helgaas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: cns3xxx: fix typo in PCI config accessor
Date: Wed, 28 Jan 2015 09:17:12 -0600	[thread overview]
Message-ID: <20150128151712.GA12050@google.com> (raw)
In-Reply-To: <2000255.rnmr9HfSOg@wuerfel>

On Wed, Jan 28, 2015 at 02:53:07PM +0100, Arnd Bergmann wrote:
> The recent patch to convert the cns3xxx PCI code added an
> extraneous opening bracket, which makes the build fail,
> so remove this.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 10e2c5540d48 ("ARM: cns3xxx: Convert PCI to use generic config accessors")
> ---
> 
> Hi Bjorn,
> 
> The broken patch just showed up in linux-next. Please apply this one on top,
> or fold it into the original patch if you don't mind rebasing.

I folded it in, thanks!  I guess Fengguang's autobuilder must not build
this config, because I got a success report from it.

> diff --git a/arch/arm/mach-cns3xxx/pcie.c b/arch/arm/mach-cns3xxx/pcie.c
> index e41fc339d100..c622c306c390 100644
> --- a/arch/arm/mach-cns3xxx/pcie.c
> +++ b/arch/arm/mach-cns3xxx/pcie.c
> @@ -101,7 +101,7 @@ static int cns3xxx_pci_read_config(struct pci_bus *bus, unsigned int devfn,
>  		 * for a PCIe bridge. So we must fixup the class code
>  		 * to 0x604 here.
>  		 */
> -		*val = (((((*val << shift) & 0xff) | (0x604 << 16)) >> shift) & mask;
> +		*val = ((((*val << shift) & 0xff) | (0x604 << 16)) >> shift) & mask;
>  
>  	return ret;
>  }
> 

  reply	other threads:[~2015-01-29  2:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-28 13:53 [PATCH] ARM: cns3xxx: fix typo in PCI config accessor Arnd Bergmann
2015-01-28 13:53 ` Arnd Bergmann
2015-01-28 15:17 ` Bjorn Helgaas [this message]
2015-01-28 15:17   ` Bjorn Helgaas
2015-01-28 15:34   ` Rob Herring
2015-01-28 15:34     ` Rob Herring
2015-01-28 15:38     ` Bjorn Helgaas
2015-01-28 15:38       ` Bjorn Helgaas
2015-01-29  6:37 ` Krzysztof Hałasa
2015-01-29  6:37   ` Krzysztof Hałasa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150128151712.GA12050@google.com \
    --to=bhelgaas@google.com \
    --cc=arnd@arndb.de \
    --cc=khalasa@piap.pl \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.